make params mandatory

This commit is contained in:
Jörg Breitbart
2019-07-02 16:14:28 +02:00
parent 5827b4b0d1
commit 7dd5dfab7a
2 changed files with 49 additions and 48 deletions
+13 -12
View File
@@ -1237,13 +1237,13 @@ export class InputHandler extends Disposable implements IInputHandler {
*/
public setMode(params: IParams, collect?: string): void {
for (let i = 0; i < params.length; i++) {
this._setMode([params.params[i]], collect);
this._setMode(params.params[i], collect);
}
}
private _setMode(params: number[], collect?: string): void {
private _setMode(param: number, collect?: string): void {
if (!collect) {
switch (params[0]) {
switch (param) {
case 4:
this._terminal.insertMode = true;
break;
@@ -1252,7 +1252,7 @@ export class InputHandler extends Disposable implements IInputHandler {
break;
}
} else if (collect === '?') {
switch (params[0]) {
switch (param) {
case 1:
this._terminal.applicationCursor = true;
break;
@@ -1295,9 +1295,9 @@ export class InputHandler extends Disposable implements IInputHandler {
// TODO: Why are params[0] compares nested within a switch for params[0]?
this._terminal.x10Mouse = params[0] === 9;
this._terminal.vt200Mouse = params[0] === 1000;
this._terminal.normalMouse = params[0] > 1000;
this._terminal.x10Mouse = param === 9;
this._terminal.vt200Mouse = param === 1000;
this._terminal.normalMouse = param > 1000;
this._terminal.mouseEvents = true;
if (this._terminal.element) {
this._terminal.element.classList.add('enable-mouse-events');
@@ -1440,13 +1440,13 @@ export class InputHandler extends Disposable implements IInputHandler {
*/
public resetMode(params: IParams, collect?: string): void {
for (let i = 0; i < params.length; i++) {
this._resetMode([params.params[i]], collect);
this._resetMode(params.params[i], collect);
}
}
private _resetMode(params: number[], collect?: string): void {
private _resetMode(param: number, collect?: string): void {
if (!collect) {
switch (params[0]) {
switch (param) {
case 4:
this._terminal.insertMode = false;
break;
@@ -1455,7 +1455,7 @@ export class InputHandler extends Disposable implements IInputHandler {
break;
}
} else if (collect === '?') {
switch (params[0]) {
switch (param) {
case 1:
this._terminal.applicationCursor = false;
break;
@@ -1520,7 +1520,7 @@ export class InputHandler extends Disposable implements IInputHandler {
case 1047: // normal screen buffer - clearing it first
// Ensure the selection manager has the correct buffer
this._terminal.buffers.activateNormalBuffer();
if (params[0] === 1049) {
if (param === 1049) {
this.restoreCursor();
}
this._terminal.refresh(0, this._terminal.rows - 1);
@@ -1900,6 +1900,7 @@ export class InputHandler extends Disposable implements IInputHandler {
* Set Scrolling Region [top;bottom] (default = full size of win-
* dow) (DECSTBM).
* CSI ? Pm r
* currently skipped
*/
public setScrollRegion(params: IParams, collect?: string): void {
if (collect) {
+36 -36
View File
@@ -113,42 +113,42 @@ export interface IInputHandler {
/** C0 SO */ shiftOut(): void;
/** C0 SI */ shiftIn(): void;
/** CSI @ */ insertChars(params?: IParams): void;
/** CSI A */ cursorUp(params?: IParams): void;
/** CSI B */ cursorDown(params?: IParams): void;
/** CSI C */ cursorForward(params?: IParams): void;
/** CSI D */ cursorBackward(params?: IParams): void;
/** CSI E */ cursorNextLine(params?: IParams): void;
/** CSI F */ cursorPrecedingLine(params?: IParams): void;
/** CSI G */ cursorCharAbsolute(params?: IParams): void;
/** CSI H */ cursorPosition(params?: IParams): void;
/** CSI I */ cursorForwardTab(params?: IParams): void;
/** CSI J */ eraseInDisplay(params?: IParams): void;
/** CSI K */ eraseInLine(params?: IParams): void;
/** CSI L */ insertLines(params?: IParams): void;
/** CSI M */ deleteLines(params?: IParams): void;
/** CSI P */ deleteChars(params?: IParams): void;
/** CSI S */ scrollUp(params?: IParams): void;
/** CSI T */ scrollDown(params?: IParams, collect?: string): void;
/** CSI X */ eraseChars(params?: IParams): void;
/** CSI Z */ cursorBackwardTab(params?: IParams): void;
/** CSI ` */ charPosAbsolute(params?: IParams): void;
/** CSI a */ hPositionRelative(params?: IParams): void;
/** CSI b */ repeatPrecedingCharacter(params?: IParams): void;
/** CSI c */ sendDeviceAttributes(params?: IParams, collect?: string): void;
/** CSI d */ linePosAbsolute(params?: IParams): void;
/** CSI e */ vPositionRelative(params?: IParams): void;
/** CSI f */ hVPosition(params?: IParams): void;
/** CSI g */ tabClear(params?: IParams): void;
/** CSI h */ setMode(params?: IParams, collect?: string): void;
/** CSI l */ resetMode(params?: IParams, collect?: string): void;
/** CSI m */ charAttributes(params?: IParams): void;
/** CSI n */ deviceStatus(params?: IParams, collect?: string): void;
/** CSI p */ softReset(params?: IParams, collect?: string): void;
/** CSI q */ setCursorStyle(params?: IParams, collect?: string): void;
/** CSI r */ setScrollRegion(params?: IParams, collect?: string): void;
/** CSI s */ saveCursor(params?: IParams): void;
/** CSI u */ restoreCursor(params?: IParams): void;
/** CSI @ */ insertChars(params: IParams): void;
/** CSI A */ cursorUp(params: IParams): void;
/** CSI B */ cursorDown(params: IParams): void;
/** CSI C */ cursorForward(params: IParams): void;
/** CSI D */ cursorBackward(params: IParams): void;
/** CSI E */ cursorNextLine(params: IParams): void;
/** CSI F */ cursorPrecedingLine(params: IParams): void;
/** CSI G */ cursorCharAbsolute(params: IParams): void;
/** CSI H */ cursorPosition(params: IParams): void;
/** CSI I */ cursorForwardTab(params: IParams): void;
/** CSI J */ eraseInDisplay(params: IParams): void;
/** CSI K */ eraseInLine(params: IParams): void;
/** CSI L */ insertLines(params: IParams): void;
/** CSI M */ deleteLines(params: IParams): void;
/** CSI P */ deleteChars(params: IParams): void;
/** CSI S */ scrollUp(params: IParams): void;
/** CSI T */ scrollDown(params: IParams, collect?: string): void;
/** CSI X */ eraseChars(params: IParams): void;
/** CSI Z */ cursorBackwardTab(params: IParams): void;
/** CSI ` */ charPosAbsolute(params: IParams): void;
/** CSI a */ hPositionRelative(params: IParams): void;
/** CSI b */ repeatPrecedingCharacter(params: IParams): void;
/** CSI c */ sendDeviceAttributes(params: IParams, collect?: string): void;
/** CSI d */ linePosAbsolute(params: IParams): void;
/** CSI e */ vPositionRelative(params: IParams): void;
/** CSI f */ hVPosition(params: IParams): void;
/** CSI g */ tabClear(params: IParams): void;
/** CSI h */ setMode(params: IParams, collect?: string): void;
/** CSI l */ resetMode(params: IParams, collect?: string): void;
/** CSI m */ charAttributes(params: IParams): void;
/** CSI n */ deviceStatus(params: IParams, collect?: string): void;
/** CSI p */ softReset(params: IParams, collect?: string): void;
/** CSI q */ setCursorStyle(params: IParams, collect?: string): void;
/** CSI r */ setScrollRegion(params: IParams, collect?: string): void;
/** CSI s */ saveCursor(params: IParams): void;
/** CSI u */ restoreCursor(params: IParams): void;
/** OSC 0
OSC 2 */ setTitle(data: string): void;
/** ESC E */ nextLine(): void;