Merge pull request #5578 from Tyriar/5576

Lint demo code

demo/client/components/window/addonSerializeWindow.ts

@@ -3,10 +3,8 @@
  * @license MIT
  */
 
-import type { Terminal } from '@xterm/xterm';
 import { BaseWindow } from './baseWindow';
 import type { IControlWindow } from '../controlBar';
-import type { AddonCollection } from '../../types';
 
 export class AddonSerializeWindow extends BaseWindow implements IControlWindow {
   public readonly id = 'addon-serialize';

demo/client/components/window/cellInspectorWindow.ts

@@ -5,8 +5,7 @@
 
 import { BaseWindow } from './baseWindow';
 import type { IControlWindow } from '../controlBar';
-import type { Terminal, IBufferCell } from '@xterm/xterm';
-import type { AddonCollection } from '../../types';
+import type { IBufferCell } from '@xterm/xterm';
 
 // Underline style values from common/buffer/Constants.ts
 const enum UnderlineStyle {
@@ -40,13 +39,6 @@ export class CellInspectorWindow extends BaseWindow implements IControlWindow {
   private _bgEl: HTMLElement;
   private _attrsEl: HTMLElement;
 
-  constructor(
-    terminal: Terminal,
-    addons: AddonCollection,
-  ) {
-    super(terminal, addons);
-  }
-
   public build(container: HTMLElement): void {
     this._container = container;
 

demo/client/components/window/gpuWindow.ts

@@ -43,7 +43,9 @@ export class GpuWindow extends BaseWindow implements IControlWindow {
   }
 
   private _styleAtlasPage(canvas: HTMLCanvasElement): void {
-    canvas.style.width = `${canvas.width / window.devicePixelRatio}px`;
-    canvas.style.height = `${canvas.height / window.devicePixelRatio}px`;
+    // eslint-disable-next-line no-restricted-syntax
+    const dpr = window.devicePixelRatio;
+    canvas.style.width = `${canvas.width / dpr}px`;
+    canvas.style.height = `${canvas.height / dpr}px`;
   }
 }

demo/client/components/window/optionsWindow.ts

@@ -88,11 +88,11 @@ export class OptionsWindow extends BaseWindow implements IControlWindow {
     terminal: Terminal,
     addons: AddonCollection,
     private readonly _handlers: {
-      updateTerminalSize: () => void,
-      updateTerminalContainerBackground: () => void
+      updateTerminalSize: () => void;
+      updateTerminalContainerBackground: () => void;
     },
   ) {
-    super(terminal, addons)
+    super(terminal, addons);
   }
 
   public build(container: HTMLElement): void {
@@ -238,7 +238,7 @@ export class OptionsWindow extends BaseWindow implements IControlWindow {
     this._autoResize = value;
   }
 
-  private _getTheme() {
+  private _getTheme(): ITheme {
     const input = document.querySelector<HTMLInputElement>('#opt-theme');
     let theme: ITheme;
     switch (input.value) {

demo/client/components/window/testWindow.ts

@@ -3,8 +3,6 @@
  * @license MIT
  */
 
-/// <reference path="../../../../typings/xterm.d.ts"/>
-
 import { writeUnicodeTable } from '../../unicodeTable';
 import type { IControlWindow } from '../controlBar';
 import { BaseWindow } from './baseWindow';
@@ -21,8 +19,8 @@ export class TestWindow extends BaseWindow implements IControlWindow {
     terminal: Terminal,
     addons: AddonCollection,
     private readonly _handlers: {
-      disposeRecreateButtonHandler: () => void,
-      createNewWindowButtonHandler: () => void,
+      disposeRecreateButtonHandler: () => void;
+      createNewWindowButtonHandler: () => void;
     },
   ) {
     super(terminal, addons);
@@ -501,7 +499,7 @@ function customGlyphAlignmentHandler(term: Terminal): void {
   term.write(' \u{F5F9}\u{F5F9} \n\r');
   term.write('\x1b[0m');
   term.write('\n\r');
-  
+
   term.write('\x1b[0mProgress bar alignment tests:\x1b[33m\n\r');
   term.write('\u{EE00}\u{EE01}\u{EE02} \u{EE03}\u{EE04}\u{EE05}');
 

demo/client/components/window/vtWindow.ts

@@ -22,7 +22,7 @@ export class VtWindow extends BaseWindow implements IControlWindow {
     container.appendChild(vtContainer);
 
     const vtFragment = document.createDocumentFragment();
-    const buttonSpecs: { [key: string]: { label: string; description: string; paramCount?: number } } = {
+    const buttonSpecs: { [key: string]: { label: string, description: string, paramCount?: number } } = {
       'A': { label: 'CUU ↑', description: 'Cursor Up Ps Times' },
       'B': { label: 'CUD ↓', description: 'Cursor Down Ps Times' },
       'C': { label: 'CUF →', description: 'Cursor Forward Ps Times' },

demo/client/components/window/webglWindow.ts

@@ -43,7 +43,9 @@ export class WebglWindow extends BaseWindow implements IControlWindow {
   }
 
   private _styleAtlasPage(canvas: HTMLCanvasElement): void {
-    canvas.style.width = `${canvas.width / window.devicePixelRatio}px`;
-    canvas.style.height = `${canvas.height / window.devicePixelRatio}px`;
+    // eslint-disable-next-line no-restricted-syntax
+    const dpr = window.devicePixelRatio;
+    canvas.style.width = `${canvas.width / dpr}px`;
+    canvas.style.height = `${canvas.height / dpr}px`;
   }
 }

package.json

@@ -47,8 +47,8 @@
     "esbuild-demo-server-watch": "node bin/esbuild.mjs --demo-server --watch",
     "test": "npm run test-unit",
     "posttest": "npm run lint",
-    "lint": "eslint --max-warnings 0 src/ addons/",
-    "lint-fix": "eslint --fix src/ addons/",
+    "lint": "eslint --max-warnings 0 src/ addons/ demo/",
+    "lint-fix": "eslint --fix src/ addons/ demo/",
     "lint-api": "eslint --config eslint.config.typings.mjs --max-warnings 0 typings/",
     "test-unit": "node ./bin/test_unit.js",
     "test-unit-coverage": "node ./bin/test_unit.js --coverage",