waveterm/xterm.js
0
0
Fork 0
mirror of https://github.com/wavetermdev/xterm.js.git synced 2026-08-05 13:43:48 -07:00
Code Issues Packages Projects Releases Wiki Activity

Simplify checks

Browse Source 
Co-authored-by: Megan Rogge <merogge@microsoft.com>
This commit is contained in:
Daniel Imms
2021-01-15 09:39:34 -08:00
co-authored by Megan Rogge
parent 0cb38cfdcb
commit 66c80d8b78
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/browser/services/SelectionService.ts
+13 -3
View File
@@ -690,16 +690,26 @@ export class SelectionService extends Disposable implements ISelectionService {
}
private _fireIfSelectionChanged(): void {
// Fire if there is no selection
const hasSelection = this.hasSelection;
if (!hasSelection && !this._oldHasSelection) {
if (!hasSelection) {
if (this._oldHasSelection) {
this._onSelectionChange.fire();
}
return;
}
const start = this._model.finalSelectionStart;
const end = this._model.finalSelectionEnd;
if (start?.[0] !== this._oldSelectionStart?.[0] || start?.[1] !== this._oldSelectionStart?.[1] ||
end?.[0] !== this._oldSelectionEnd?.[0] || end?.[1] !== this._oldSelectionEnd?.[1]) {
// Sanity check, these should not be undefined as there is a selection
if (!start || !end) {
return;
}
if (!this._oldSelectionStart || !this._oldSelectionEnd || (
start[0] !== this._oldSelectionStart[0] || start[1] !== this._oldSelectionStart[1] ||
end[0] !== this._oldSelectionEnd[0] || end[1] !== this._oldSelectionEnd[1])) {
this._oldSelectionStart = start;
this._oldSelectionEnd = end;