Ignore all the build directories in Docker

This allows for reproducible builds.
Also, fix Dockerfile to first build and then run tests and a typo in the entrypoint.

Thanks @BenHall for reporting the issue with the Docker build!
This commit is contained in:
Antonis Kalipetis
2016-12-29 16:13:58 +02:00
parent a4c958c54f
commit 61c213f9e3
2 changed files with 18 additions and 4 deletions
+16 -2
View File
@@ -1,2 +1,16 @@
node_modules
.git
node_modules/
*.swp
.lock-wscript
lib/
Makefile.gyp
*.Makefile
*.target.gyp.mk
*.node
example/*.log
docs/
npm-debug.log
/.idea/
.env
build/
.vscode/
.git/
+2 -2
View File
@@ -10,7 +10,7 @@ RUN apt-get update \
WORKDIR /usr/src/app
# Set an entrypoint, to automatically install node modules
ENTRYPOINT ["/bin/bash", "-c", "if [[ ! -d node_modules ]]; then npm install; fi; exec \"$@\";"]
ENTRYPOINT ["/bin/bash", "-c", "if [[ ! -d node_modules ]]; then npm install; fi; exec \"${@:0}\";"]
CMD ["npm", "run", "dev"]
# First, install dependencies to improve layer caching
@@ -21,4 +21,4 @@ RUN npm install
COPY . /usr/src/app
# Run the tests and build, to make sure everything is working nicely
RUN npm run test && npm run build
RUN npm run build && npm run test