waveterm/xterm.js
0
0
Fork 0
mirror of https://github.com/wavetermdev/xterm.js.git synced 2026-08-05 13:43:48 -07:00
Code Issues Packages Projects Releases Wiki Activity

Only removeChild valid children in DomRenderer dispose

Browse Source
This commit is contained in:
Josh Goldberg
2020-06-03 16:05:53 -04:00
parent 106d74caa2
commit 5af1554bbf
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/browser/renderer/dom/DomRenderer.ts
+14 -4
View File
@@ -95,10 +95,20 @@ export class DomRenderer extends Disposable implements IRenderer {
public dispose(): void {
this._element.classList.remove(TERMINAL_CLASS_PREFIX + this._terminalClass);
this._screenElement.removeChild(this._rowContainer);
this._screenElement.removeChild(this._selectionContainer);
this._screenElement.removeChild(this._themeStyleElement);
this._screenElement.removeChild(this._dimensionsStyleElement);
// Outside influences such as React unmounts may manipulate the DOM before our disposal.
// https://github.com/xtermjs/xterm.js/issues/2960
for (const element of [
this._rowContainer,
this._selectionContainer,
this._themeStyleElement,
this._dimensionsStyleElement,
]) {
if (element.parentElement === this._screenElement) {
this._screenElement.removeChild(element);
}
}
super.dispose();
}