Remove remaining parts of renderer API, fix webgl tests

This commit is contained in:
Daniel Imms
2019-06-14 22:18:53 -07:00
parent 6c232a0e11
commit 3a7aa77950
6 changed files with 4 additions and 16 deletions
-6
View File
@@ -686,12 +686,6 @@ export class Terminal extends Disposable implements ITerminal, IDisposable, IInp
}
public setRenderer(renderer: IRenderer): void {
this._renderService.setRenderer(renderer);
// this._renderCoordinator.onOptionsChanged();
this.refresh(0, this.rows - 1);
}
private _createRenderer(): IRenderer {
switch (this.options.rendererType) {
case 'canvas': return new Renderer(this, this._colorManager.colors, this._charSizeService); break;
-3
View File
@@ -24,9 +24,6 @@ export class TestTerminal extends Terminal {
}
export class MockTerminal implements ITerminal {
setRenderer(renderer: any): void {
throw new Error('Method not implemented.');
}
onBlur: IEvent<void>;
onFocus: IEvent<void>;
onA11yChar: IEvent<string>;
-1
View File
@@ -271,7 +271,6 @@ export interface IPublicTerminal extends IDisposable {
writeUtf8(data: Uint8Array): void;
refresh(start: number, end: number): void;
reset(): void;
setRenderer(renderer: any): void;
}
export interface IBufferAccessor {
+3 -2
View File
@@ -105,13 +105,14 @@ export class RenderService extends Disposable implements IRenderService {
// TODO: RenderCoordinator should be the only one to dispose the renderer
this._renderer.dispose();
this._renderer = renderer;
this.refreshRows(0, this._rowCount - 1);
}
private _fullRefresh(): void {
if (this._isPaused) {
this._needsFullRefresh = true;
} else {
this.refreshRows(0, this._rowCount);
this.refreshRows(0, this._rowCount - 1);
}
}
@@ -122,7 +123,7 @@ export class RenderService extends Disposable implements IRenderService {
public onDevicePixelRatioChange(): void {
this._renderer.onDevicePixelRatioChange();
this.refreshRows(0, this._rowCount);
this.refreshRows(0, this._rowCount - 1);
}
public onResize(cols: number, rows: number): void {
-3
View File
@@ -162,9 +162,6 @@ export class Terminal implements ITerminalApi {
public loadAddon(addon: ITerminalAddon): void {
return this._addonManager.loadAddon(this, addon);
}
public setRenderer(renderer: any): void {
this._core.setRenderer(renderer);
}
public loadWebgl(preserveDrawingBuffer?: boolean): void {
this.loadAddon(new WebglRendererAddon(preserveDrawingBuffer));
}
+1 -1
View File
@@ -18,7 +18,7 @@ export class WebglRendererAddon implements ITerminalAddon {
throw new Error('Cannot activate WebglRendererAddon before Terminal.open');
}
this._terminal = terminal;
(<any>this._terminal)._renderService.setRenderer(new WebglRenderer(terminal, (terminal as any)._core._colorManager.colors, this._preserveDrawingBuffer));
(<any>this._terminal)._core._renderService.setRenderer(new WebglRenderer(terminal, (terminal as any)._core._colorManager.colors, this._preserveDrawingBuffer));
}
public dispose(): void {