waveterm/xterm.js
0
0
Fork 0
mirror of https://github.com/wavetermdev/xterm.js.git synced 2026-08-05 13:43:48 -07:00
Code Issues Packages Projects Releases Wiki Activity

Rename startRow/endRow in TextRenderLayer

Browse Source 
Renaming these to firstRow/lastRow makes the inclusivity of the range
clearer.

Addresses this comment:
https://github.com/xtermjs/xterm.js/pull/1393#discussion_r182471582
This commit is contained in:
Benjamin Woodruff
2018-04-18 20:22:55 -07:00
parent b853aa4929
commit 0fe59df2e9
1 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderer/TextRenderLayer.ts
+11 -11
View File
@@ -50,8 +50,8 @@ export class TextRenderLayer extends BaseRenderLayer {
private _forEachCell(
terminal: ITerminal,
startRow: number,
endRow: number,
firstRow: number,
lastRow: number,
callback: (
code: number,
char: string,
@@ -63,7 +63,7 @@ export class TextRenderLayer extends BaseRenderLayer {
flags: number
) => void
): void {
for (let y = startRow; y <= endRow; y++) {
for (let y = firstRow; y <= lastRow; y++) {
const row = y + terminal.buffer.ydisp;
const line = terminal.buffer.lines.get(row);
for (let x = 0; x < terminal.cols; x++) {
@@ -128,8 +128,8 @@ export class TextRenderLayer extends BaseRenderLayer {
}
}
private _drawBackground(terminal: ITerminal, startRow: number, endRow: number): void {
this._forEachCell(terminal, startRow, endRow, (code, char, width, x, y, fg, bg, flags) => {
private _drawBackground(terminal: ITerminal, firstRow: number, lastRow: number): void {
this._forEachCell(terminal, firstRow, lastRow, (code, char, width, x, y, fg, bg, flags) => {
// libvte and xterm both draw the background (but not foreground) of invisible characters,
// so we should too.
const isDefaultBackground = bg >= 256;
@@ -142,8 +142,8 @@ export class TextRenderLayer extends BaseRenderLayer {
});
}
private _drawForeground(terminal: ITerminal, startRow: number, endRow: number): void {
this._forEachCell(terminal, startRow, endRow, (code, char, width, x, y, fg, bg, flags) => {
private _drawForeground(terminal: ITerminal, firstRow: number, lastRow: number): void {
this._forEachCell(terminal, firstRow, lastRow, (code, char, width, x, y, fg, bg, flags) => {
if (flags & FLAGS.INVISIBLE) {
return;
}
@@ -169,15 +169,15 @@ export class TextRenderLayer extends BaseRenderLayer {
});
}
public onGridChanged(terminal: ITerminal, startRow: number, endRow: number): void {
public onGridChanged(terminal: ITerminal, firstRow: number, lastRow: number): void {
// Resize has not been called yet
if (this._state.cache.length === 0) {
return;
}
this.clearCells(0, startRow, terminal.cols, endRow - startRow + 1); // endRow is inclusive
this._drawBackground(terminal, startRow, endRow);
this._drawForeground(terminal, startRow, endRow);
this.clearCells(0, firstRow, terminal.cols, lastRow - firstRow + 1);
this._drawBackground(terminal, firstRow, lastRow);
this._drawForeground(terminal, firstRow, lastRow);
}
public onOptionsChanged(terminal: ITerminal): void {