Compare commits

..

5 Commits

Author SHA1 Message Date
Lea Anthony c129a35fb9 Update PR branch check 2022-09-23 10:24:49 +10:00
Lea Anthony 48b3fb0f51 Add PR checks (#1879)
* Add PR checks

* Update PR workflow

* Update PR workflow

* Update PR workflow

* Add branch name check + doc check

* Update PR branch check

* Update PR branch check

* Update PR branch check
2022-09-23 08:52:01 +10:00
Lea Anthony 8bbbb0f148 Fix i18n blog 2022-09-22 18:34:04 +10:00
Lea Anthony 495c129ec6 Update blog 2022-09-22 11:27:40 +10:00
Lea Anthony 74133c9ae3 v2.0.0 2022-09-22 11:00:57 +10:00
6 changed files with 82 additions and 5 deletions
+23
View File
@@ -0,0 +1,23 @@
name: Check Docs
on:
pull_request:
branches: [ 'feature/*' ]
jobs:
docs:
name: Website Updated
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Verify Changed files
uses: tj-actions/verify-changed-files@v11.1
id: verify-changed-files
with:
files: |
v2/website/*.mdx
- name: Run step only when files change.
if: steps.verify-changed-files.outputs.files_changed != 'true'
run: |
echo "Feature branch does not contain any changes to the website."
+40
View File
@@ -0,0 +1,40 @@
name: PR Checks
on:
pull_request:
jobs:
check_branch_name:
runs-on: ubuntu-latest
name: Check branch name
steps:
- run: |
if ! [[ "$(echo ${GITHUB_HEAD_REF} | cut -d "/" -f1)" =~ (feature|bugfix|release|chore) ]]; then
echo "PRs are only accepted for branches starting with: feature/, bugfix/, chore/ or release/"
exit 1
fi
shell: bash
test:
name: Run Go Tests
runs-on: ${{ matrix.os }}
needs: check_branch_name
strategy:
matrix:
os: [ ubuntu-latest, windows-latest, macos-latest ]
go-version: [ 1.18, 1.19 ]
steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Install linux dependencies
if: matrix.os == 'ubuntu-latest'
run: sudo apt-get update -y && sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.0-dev build-essential pkg-config
- name: Set up Go 1.18
uses: actions/setup-go@v3
with:
go-version: ${{ matrix.go-version }}
- name: Run tests
run: go test -v ./...
@@ -10,7 +10,6 @@ tags: [wails, v2]
<img
src={require("@site/static/img/blog/montage.png").default}
width="75%"
class="screenshot"
/>
</div>
<br />
@@ -13,7 +13,6 @@ tags:
<img
src={require("@site/static/img/blog/montage.png").default}
width="75%"
class="screenshot"
/>
</div>
<br />
@@ -13,7 +13,6 @@ tags:
<img
src={require("@site/static/img/blog/montage.png").default}
width="75%"
class="screenshot"
/>
</div>
<br />
+19 -2
View File
@@ -56,8 +56,8 @@ The process for adding new features are as follows:
person who opened the ticket. Sometimes placeholder tickets are created and require more details
- Comment on the ticket stating if you wish to develop the feature
- Clone the repository and create a branch with the format `feature/<ticket_number>_<ticket_title>`
- New features often require documentation so please ensure you have also added or updated the documentation as part of
the changes
- New features will require documentation so please ensure you have also added or updated the documentation as part of
the changes. Feature PRs without changes to the documentation will not be accepted.
- Once the feature is ready for testing, create a draft PR. Please ensure the PR description has the test scenarios and
test cases listed with checkmarks, so that others can know what still needs to be tested.
- Once all the testing is completed, please update the status of the PR from draft and leave a message.
@@ -99,6 +99,23 @@ bugfixes should be discussed as the approach may have unintended side effects.
Any PRs opened without a corresponding ticket may be rejected.
:::
### Chores
Chores are tasks that need to be done but are not directly related to the codebase. Examples
include:
- Updating documentation
- Writing tutorials / guides
- Updating GitHub templates or actions
- Adding scripts to help with development
If you wish to work on a chore, please open a ticket and comment on it stating you wish to do so.
Chores are not assigned to anyone and are open to anyone who wishes to work on them. If you have
any questions, please ask in the [Contributing to Wails](https://github.com/wailsapp/wails/discussions/1520)
discussion or on slack.
PRs for chores should be done from a `chore/<ticket_number>_<ticket_title>` branch.
### Testing
Testing is vitally important to ensure quality in the project. There are a couple of