waveterm/wails
0
0
Fork 0
mirror of https://github.com/wavetermdev/wails.git synced 2026-08-05 13:53:43 -07:00
Code Issues Packages Projects Releases Wiki Activity

Update icon.ico file mode (#1154)

Browse Source 
* Add os.O_WRONLY to icon.ico to avoid bad file descriptor error

* Wrap errors coming from winres.LoadICO()

If the file exists but is empty, a blunt "Unexpected EOF" is returned, and propagated as is.

This is not super helpful when trying to pin point what's going on.

Wrapping the error helps to locate the problem.
This commit is contained in:
Valentin Trinqué
2022-02-16 06:02:45 +11:00
committed by GitHub
parent f923a431f7
commit e6424dc8ab
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
v2/pkg/commands/build/packager.go
+2 -2
View File
@@ -260,7 +260,7 @@ func generateIcoFile(options *Options) error {
if err != nil {
return err
}
output, err := os.OpenFile(icoFile, os.O_CREATE, 0644)
output, err := os.OpenFile(icoFile, os.O_CREATE|os.O_WRONLY, 0644)
if err != nil {
return err
}
@@ -295,7 +295,7 @@ func compileResources(options *Options) error {
defer iconFile.Close()
ico, err := winres.LoadICO(iconFile)
if err != nil {
return err
return fmt.Errorf("couldn't load icon from icon.ico: %w", err)
}
err = rs.SetIcon(winres.RT_ICON, ico)
if err != nil {