waveterm/inshellisense
0
0
Fork 0
mirror of https://github.com/wavetermdev/inshellisense.git synced 2026-08-05 13:43:30 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: improper screen clearing results in blank cells (#121)

Browse Source 
Signed-off-by: Chapman Pendery <cpendery@vt.edu>
This commit is contained in:
Chapman Pendery
2023-12-14 10:35:05 -08:00
committed by GitHub
parent 5c35624fc5
commit 68d1142499
1 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ui/ui-root.ts
+12 -10
View File
@@ -24,20 +24,22 @@ export const render = async (shell: Shell) => {
writeOutput(ansi.clearTerminal);
term.onData((data) => {
const commandState = term.getCommandState();
if ((commandState.hasOutput || hasActiveSuggestions) && !commandState.persistentOutput) {
if (term.getCursorState().remainingLines < previousSuggestionsRows) {
if (hasActiveSuggestions) {
// Considers when data includes newlines which have shifted the cursor position downwards
const newlines = Math.max((data.match(/\r/g) || []).length, (data.match(/\n/g) || []).length);
const linesOfInterest = MAX_LINES + newlines;
if (term.getCursorState().remainingLines <= previousSuggestionsRows) {
writeOutput(
ansi.cursorHide +
data +
ansi.cursorHide +
ansi.cursorSavePosition +
ansi.cursorPrevLine.repeat(MAX_LINES) +
term.getCells(MAX_LINES, "above") +
ansi.cursorPrevLine.repeat(linesOfInterest) +
term.getCells(linesOfInterest, "above") +
ansi.cursorRestorePosition +
ansi.cursorShow +
data,
ansi.cursorShow,
);
} else {
writeOutput(ansi.cursorHide + ansi.cursorSavePosition + eraseLinesBelow(MAX_LINES + 1) + ansi.cursorRestorePosition + ansi.cursorShow + data);
writeOutput(ansi.cursorHide + ansi.cursorSavePosition + eraseLinesBelow(linesOfInterest + 1) + ansi.cursorRestorePosition + ansi.cursorShow + data);
}
} else {
writeOutput(data);
@@ -91,7 +93,7 @@ export const render = async (shell: Shell) => {
hasActiveSuggestions = true;
} else {
if (hasActiveSuggestions) {
if (term.getCursorState().remainingLines < previousSuggestionsRows) {
if (term.getCursorState().remainingLines <= previousSuggestionsRows) {
writeOutput(
ansi.cursorHide +
ansi.cursorSavePosition +