fix: final cleanup

This commit is contained in:
jongomez
2023-10-25 15:55:13 +01:00
parent ebeb007931
commit bb9bccfd07
3 changed files with 24 additions and 13 deletions
@@ -353,4 +353,4 @@ import {
Build on Waku
</CallToActionButton>
</Box>
<JobsPerDepartment jobBoard="status72" useDummyData />
<JobsPerDepartment jobBoard="codex" useDummyData />
@@ -4,6 +4,24 @@ import useFetchJobs, { JobDepartmentArray } from './useFetchJobs'
import React from 'react'
import { jobsPerDepartmentDummyData } from './jobsPerDepartmentDummyData'
type JobsPerDepartmentHeaderProps = {
message?: string
}
const JobsPerDepartmentHeader: React.FC<JobsPerDepartmentHeaderProps> = ({
message,
}) => {
return (
<>
<Typography variant="h1" className="mdx-jpd__header">
Current job openings
</Typography>
{!!message && <Typography variant="body1">{message}</Typography>}
</>
)
}
const hasJobs = (jobsPerDepartment: JobDepartmentArray): boolean => {
if (!jobsPerDepartment) return false
@@ -35,27 +53,21 @@ export const JobsPerDepartment: React.FC<JobsPerDepartmentProps> = ({
useDummyData ? jobsPerDepartmentDummyData : null,
)
console.log('data', data)
console.log('error', error)
console.log('isLoading', isLoading)
if (isLoading) {
return <div>Loading...</div>
return <JobsPerDepartmentHeader message="Fetching jobs..." />
}
if (error) {
return <div>Error fetching data</div>
return <JobsPerDepartmentHeader message="Error fetching data" />
}
if (!data || !hasJobs(data)) {
return <div>No job openings to show</div>
return <JobsPerDepartmentHeader message="No job openings to show" />
}
return (
<div {...props}>
<Typography variant="h1" className="mdx-jpd__header">
Current job openings
</Typography>
<JobsPerDepartmentHeader />
{data.map((department) => {
return (
<SingleDepartmentJobs key={department.name} department={department} />
@@ -1,7 +1,7 @@
import { useEffect, useRef, useState } from 'react'
/*
// Array of possible job boards:
// Here's an array with some possible job boards:
const allJobBoards = [
'testacidinfo', // Acid Test job board
'logos',
@@ -107,7 +107,6 @@ export const useFetchJobs = (
}> => {
try {
if (dummyResponse) {
console.log('dummy data bruh:', dummyResponse)
return { jobsPerDepartment: dummyResponse, errorData: null }
}