maybe changing nodejs is causing problems

Addresses some security notices

.github/workflows/build-helper.yml

@@ -16,6 +16,10 @@ jobs:
                       arch: "amd64"
                       runner: "ubuntu-latest"
                       scripthaus: "build-package-linux"
+                    - platform: "linux"
+                      arch: "arm64"
+                      runner: ubuntu-24.04-arm64-16core
+                      scripthaus: "build-package-linux"
         runs-on: ${{ matrix.runner }}
         steps:
             - uses: actions/checkout@v4
@@ -28,6 +32,8 @@ jobs:
               run: |
                   sudo apt-get update
                   sudo apt-get install --no-install-recommends -y libarchive-tools libopenjp2-tools rpm
+            - name: Install FPM # The version of FPM that comes bundled with electron-builder doesn't include a Linux ARM target. Installing Gems onto the runner is super quick so we'll just do this for all targets.
+              run: sudo gem install fpm
             - uses: actions/setup-go@v5
               with:
                   go-version: ${{env.GO_VERSION}}
@@ -58,6 +64,7 @@ jobs:
               run: scripthaus run ${{ matrix.scripthaus }}
               env:
                   GOARCH: ${{ matrix.arch }}
+                  USE_SYSTEM_FPM: true # Ensure that the installed version of FPM is used rather than the bundled one.
                   CSC_LINK: ${{ matrix.platform == 'darwin' && secrets.PROD_MACOS_CERTIFICATE}}
                   CSC_KEY_PASSWORD: ${{ matrix.platform == 'darwin' && secrets.PROD_MACOS_CERTIFICATE_PWD }}
                   APPLE_ID: ${{ matrix.platform == 'darwin' && secrets.PROD_MACOS_NOTARIZATION_APPLE_ID }}

.github/workflows/regression.yml

@@ -1,66 +0,0 @@
-name: TestDriver.ai Regression Testing
-on:
-    push:
-        branches:
-            - main
-    pull_request:
-        branches:
-            - main
-    schedule:
-        - cron: 0 21 * * *
-    workflow_dispatch: null
-
-permissions:
-    contents: read # To allow the action to read repository contents
-    pull-requests: write # To allow the action to create/update pull request comments
-
-jobs:
-    test:
-        name: TestDriver
-        runs-on: ubuntu-latest
-        steps:
-            - uses: dashcamio/testdriver@main
-              id: testdriver
-              with:
-                version: v2.12.12
-                prerun: |
-                      rm ~/Desktop/WITH-LOVE-FROM-AMERICA.txt
-                      cd ~/actions-runner/_work/testdriver/testdriver/
-                      brew install go
-                      brew tap scripthaus-dev/scripthaus
-                      brew install corepack
-                      brew install scripthaus
-                      corepack enable
-                      yarn install
-                      scripthaus run build-backend
-                      echo "Yarn"
-                      yarn
-                      echo "Rebuild"
-                      scripthaus run electron-rebuild
-                      echo "Webpack"
-                      scripthaus run webpack-build
-                      echo "Starting Electron"
-                      scripthaus run electron 1>/dev/null 2>&1 &
-                      echo "Electron Done"
-                      exit
-                prompt: |
-                      1. wait 10 seconds
-                      1. click "Get Started"
-                      1. validate that overlapping text does not appear in the application
-                      1. focus the Wave input with the keyboard shorcut Command + I
-                      1. type 'ls' into the input
-                      1. press return
-                      1. validate Wave shows the result of 'ls'
-              env:
-                  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-            - uses: peter-evans/create-or-update-comment@v4
-              if: ${{always()}}
-              with:
-                  issue-number: ${{ github.event.pull_request.number }}
-                  body: |
-                      ## TestDriver Summary
-                      ${{ steps.testdriver.outputs.markdown }}
-                      ${{ steps.testdriver.outputs.summary }}
-                  reactions: |
-                      +1
-                      -1

.github/workflows/testdriver.yml

@@ -0,0 +1,49 @@
+name: TestDriver.ai Regression Testing - Waveterm
+on:
+    push:
+        branches:
+            - main
+    pull_request:
+        branches:
+            - main
+    schedule:
+        - cron: 0 21 * * *
+    workflow_dispatch: null
+
+permissions:
+    contents: read # To allow the action to read repository contents
+    pull-requests: write # To allow the action to create/update pull request comments
+
+jobs:
+  test:
+    name: "TestDriver"
+    runs-on: ubuntu-latest
+    steps:
+      - uses: dashcamio/testdriver@main
+        id: testdriver
+        with:
+          key: ${{secrets.DASHCAM_API}}
+          os: mac
+          prerun: |
+            cd ~/actions-runner/_work/testdriver/testdriver/
+            brew install go
+            brew tap scripthaus-dev/scripthaus
+            brew install corepack
+            brew install scripthaus
+            corepack enable
+            yarn install
+            scripthaus run build-backend
+            echo "Yarn"
+            yarn
+            echo "Rebuild"
+            scripthaus run electron-rebuild
+            echo "Webpack"
+            scripthaus run webpack-build
+            echo "Starting Electron"
+            scripthaus run electron 1>/dev/null 2>&1 &
+            echo "Electron Done"
+            npm install testdriverai -g
+            npm install dashcam -g
+            exit       
+          prompt: |
+            1. /run testdriver/theme.yml

.testdriver/prerun.sh

@@ -1,18 +0,0 @@
-rm ~/Desktop/WITH-LOVE-FROM-AMERICA.txt
-cd ~/actions-runner/_work/testdriver/testdriver/
-brew install go
-brew tap scripthaus-dev/scripthaus
-brew install scripthaus
-corepack enable
-yarn install
-scripthaus run build-backend
-echo "Yarn"
-yarn
-echo "Rebuild"
-scripthaus run electron-rebuild
-echo "Webpack"
-scripthaus run webpack-build
-echo "Starting Electron"
-scripthaus run electron 1>/dev/null 2>&1 &
-echo "Electron Done"
-exit

build-linux.md

@@ -34,20 +34,23 @@ You'll now have to move the built `scripthaus` binary to a directory in your pat
 sudo cp scripthaus /usr/local/bin
 ```
 
-## Install nodejs, npm, and yarn
+## Install nodejs and yarn
 
-We use [nvm](https://github.com/nvm-sh/nvm) to install nodejs on Linux (you can use an alternate installer if you wish). You must have a relatively recent version of node in order to build the terminal. Different distributions and shells will require different setup instructions. These instructions work for Ubuntu 22 using bash (will install node v20.8.1):
+You also need a relatively modern nodejs with npm and yarn installed.
 
-```
-wget -qO- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.5/install.sh | bash
-source ~/.bashrc
-nvm install v20.8.1
-```
+Node can be installed from [https://nodejs.org](https://nodejs.org).
 
-Now we can install yarn:
+We use Yarn Modern to manage our packages. The recommended way to install Yarn Modern is using Corepack, a new utility shipped by NodeJS that lets you manage your package manager versioning as you would any packages.
 
-```
-npm install -g yarn
+If you installed NodeJS from the official feed (via the website or using NVM), this should come preinstalled. If you use Homebrew or some other feed, you may need to manually install Corepack using `npm install -g corepack`.
+
+For more information on Corepack, check out [this link](https://yarnpkg.com/corepack).
+
+Once you've verified that you have Corepack installed, run the following script to set up Yarn for the repository:
+
+```sh
+corepack enable
+yarn install
 ```
 
 ## Clone the Wave Repo

package.json

@@ -18,95 +18,95 @@
         "appId": "dev.commandline.waveterm"
     },
     "dependencies": {
-        "@lexical/react": "^0.14.3",
-        "@monaco-editor/react": "^4.5.1",
+        "@lexical/react": "^0.17.0",
+        "@monaco-editor/react": "^4.6.0",
         "@table-nav/core": "^0.0.7",
         "@table-nav/react": "^0.0.7",
-        "@tanstack/match-sorter-utils": "^8.8.4",
-        "@tanstack/react-table": "^8.10.3",
-        "@withfig/autocomplete": "^2.652.3",
+        "@tanstack/match-sorter-utils": "^8.19.4",
+        "@tanstack/react-table": "^8.20.1",
+        "@withfig/autocomplete": "^2.672.0",
         "autobind-decorator": "^2.4.0",
         "base64-js": "^1.5.1",
         "clsx": "^2.1.1",
-        "dayjs": "^1.11.3",
-        "dompurify": "^3.0.2",
-        "electron-squirrel-startup": "^1.0.0",
-        "electron-updater": "^6.1.8",
-        "framer-motion": "^10.16.16",
+        "dayjs": "^1.11.12",
+        "dompurify": "^3.1.6",
+        "electron-squirrel-startup": "^1.0.1",
+        "electron-updater": "^6.3.2",
+        "framer-motion": "^10.18.0",
         "lexical": "0.14.5",
-        "mobx": "6.12",
-        "mobx-react": "^7.5.0",
+        "mobx": "6.12.5",
+        "mobx-react": "^7.6.0",
         "monaco-editor": "0.48.0",
         "mustache": "^4.2.0",
-        "node-fetch": "^3.2.10",
-        "overlayscrollbars": "^2.6.1",
-        "overlayscrollbars-react": "^0.5.5",
+        "node-fetch": "^3.3.2",
+        "overlayscrollbars": "^2.10.0",
+        "overlayscrollbars-react": "^0.5.6",
         "papaparse": "^5.4.1",
-        "react": "^18.1.0",
-        "react-dom": "^18.1.0",
-        "react-markdown": "^9.0.0",
+        "react": "^18.3.1",
+        "react-dom": "^18.3.1",
+        "react-markdown": "^9.0.1",
         "remark": "^15.0.1",
         "remark-gfm": "^4.0.0",
-        "sprintf-js": "^1.1.2",
-        "throttle-debounce": "^5.0.0",
+        "sprintf-js": "^1.1.3",
+        "throttle-debounce": "^5.0.2",
         "tinycolor2": "^1.6.0",
         "tsx-control-statements": "^5.1.1",
-        "uuid": "^9.0.0",
-        "winston": "^3.8.2",
+        "uuid": "^9.0.1",
+        "winston": "^3.13.1",
         "xterm": "^5.3.0",
         "xterm-addon-serialize": "^0.11.0",
         "xterm-addon-web-links": "^0.9.0",
         "xterm-addon-webgl": "^0.16.0"
     },
     "devDependencies": {
-        "@babel/cli": "^7.17.10",
-        "@babel/core": "^7.18.2",
+        "@babel/cli": "^7.24.8",
+        "@babel/core": "^7.25.2",
         "@babel/plugin-proposal-class-properties": "^7.18.6",
-        "@babel/plugin-proposal-decorators": "^7.18.2",
+        "@babel/plugin-proposal-decorators": "^7.24.7",
         "@babel/plugin-proposal-private-methods": "^7.18.6",
         "@babel/plugin-proposal-private-property-in-object": "^7.21.11",
-        "@babel/plugin-transform-react-jsx": "^7.17.12",
-        "@babel/plugin-transform-runtime": "^7.23.4",
-        "@babel/preset-env": "^7.18.2",
-        "@babel/preset-react": "^7.23.3",
-        "@babel/preset-typescript": "^7.17.12",
+        "@babel/plugin-transform-react-jsx": "^7.25.2",
+        "@babel/plugin-transform-runtime": "^7.24.7",
+        "@babel/preset-env": "^7.25.3",
+        "@babel/preset-react": "^7.24.7",
+        "@babel/preset-typescript": "^7.24.7",
         "@electron/rebuild": "^3.6.0",
         "@svgr/webpack": "^8.1.0",
         "@types/electron": "^1.6.10",
-        "@types/node": "^20.11.0",
-        "@types/papaparse": "^5.3.10",
-        "@types/react": "^18.0.12",
-        "@types/semver": "^7.5.6",
-        "@types/sprintf-js": "^1.1.3",
-        "@types/throttle-debounce": "^5.0.1",
-        "@types/tinycolor2": "^1",
-        "@types/uuid": "^9.0.7",
-        "@types/webpack-env": "^1.18.3",
-        "@withfig/autocomplete-types": "^1.30.0",
+        "@types/node": "^22.1.0",
+        "@types/papaparse": "^5.3.14",
+        "@types/react": "^18.3.3",
+        "@types/semver": "^7.5.8",
+        "@types/sprintf-js": "^1.1.4",
+        "@types/throttle-debounce": "^5.0.2",
+        "@types/tinycolor2": "^1.4.6",
+        "@types/uuid": "^9.0.8",
+        "@types/webpack-env": "^1.18.5",
+        "@withfig/autocomplete-types": "^1.31.0",
         "babel-loader": "^9.1.3",
         "babel-plugin-jsx-control-statements": "^4.1.2",
-        "copy-webpack-plugin": "^12.0.0",
-        "css-loader": "^7.1.0",
-        "electron": "^30.0.8",
+        "copy-webpack-plugin": "^12.0.2",
+        "css-loader": "^7.1.2",
+        "electron": "^31.3.1",
         "electron-builder": "^24.13.3",
-        "electron-builder-squirrel-windows": "^24.13.3",
+        "electron-builder-squirrel-windows": "25.0.0-alpha.10",
         "file-loader": "^6.2.0",
         "http-server": "^14.1.1",
-        "less": "^4.1.2",
-        "less-loader": "^12.0.0",
+        "less": "^4.2.0",
+        "less-loader": "^12.2.0",
         "lodash-webpack-plugin": "^0.11.6",
-        "mini-css-extract-plugin": "^2.6.0",
+        "mini-css-extract-plugin": "^2.9.0",
         "prettier": "^2.8.8",
         "raw-loader": "^4.0.2",
         "react-split-it": "^2.0.0",
         "style-loader": "4.0.0",
-        "typescript": "^5.0.0",
-        "webpack": "^5.73.0",
-        "webpack-bundle-analyzer": "^4.10.1",
+        "typescript": "^5.5.4",
+        "webpack": "^5.94.0",
+        "webpack-bundle-analyzer": "^4.10.2",
         "webpack-cli": "^5.1.4",
         "webpack-dev-server": "^5.0.4",
-        "webpack-merge": "^5.8.0",
-        "yaml": "^2.4.0"
+        "webpack-merge": "^5.10.0",
+        "yaml": "^2.5.0"
     },
     "scripts": {
         "postinstall": "electron-builder install-app-deps"

src/app/line/linecomps.tsx

@@ -178,7 +178,7 @@ class LineActions extends React.Component<{ screen: LineContainerType; line: Lin
             <div className="line-actions">
                 <Choose>
                     <When condition={containerType == appconst.LineContainer_Main}>
-                        <div key="chat" title="Restart Command" className="line-icon" onClick={this.clickChat}>
+                        <div key="chat" title="Ask Wave AI" className="line-icon" onClick={this.clickChat}>
                             <i className="fa-sharp fa-regular fa-sparkles fa-fw" />
                         </div>
                         <div key="restart" title="Restart Command" className="line-icon" onClick={this.clickRestart}>

testdriver/theme.yml

@@ -0,0 +1,39 @@
+version: 4.0.0
+steps:
+  - prompt: "onboarding"
+    commands:
+    - command: focus-application
+      name: Electron
+    - command: hover-text
+      description: Get started CTA
+      text: Get Started
+      action: click
+  - prompt: "change theme"
+    commands:
+    - command: hover-text
+      description: Settings button
+      text: Settings
+      action: click
+    - command: hover-text
+      description: font size 13
+      text: 13px
+      action: click
+    - command: hover-text
+      description: font size 12
+      text: 12px
+      action: click
+    - command: hover-text
+      description: theme selector
+      text: Dark
+      action: click
+    - command: hover-text
+      description: theme color white
+      text: Light
+      action: click
+    - command: hover-text
+      description: workspace
+      text: workspace-1
+      action: click
+    - command: assert
+      expect: the terminal is white
+

wavesrv/pkg/cmdrunner/cmdrunner.go

@@ -132,7 +132,7 @@ var SetVarScopes = []SetVarScope{
 	{ScopeName: "remote", VarNames: []string{}},
 }
 
-var userHostRe = regexp.MustCompile(`^(sudo@)?([a-zA-Z0-9][a-zA-Z0-9._@\\-]*@)?([a-z0-9][a-z0-9.-]*)(?::([0-9]+))?$`)
+var userHostRe = regexp.MustCompile(`^(sudo@)?([a-zA-Z0-9][a-zA-Z0-9._@:\\-]*@)?([a-z0-9][a-z0-9.-]*)(?::([0-9]+))?$`)
 var remoteAliasRe = regexp.MustCompile("^[a-zA-Z0-9][a-zA-Z0-9._-]*$")
 var genericNameRe = regexp.MustCompile("^[a-zA-Z][a-zA-Z0-9_ .()<>,/\"'\\[\\]{}=+$@!*-]*$")
 var rendererRe = regexp.MustCompile("^[a-zA-Z][a-zA-Z0-9_.:-]*$")