uutils/uutils.github.io
0
0
Fork 0
mirror of https://github.com/uutils/uutils.github.io.git synced 2026-06-10 16:12:28 -07:00
Code Issues Packages Projects Releases Wiki Activity

reviews: discourage silencing clippy with allow(dead_code)

Browse Source
This commit is contained in:
Sylvestre Ledru
2026-05-30 11:19:01 +02:00
parent 071044606b
commit 773a88d028
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
content/reviews.md
+3
View File
@@ -86,6 +86,9 @@ check these before requesting a review, your PR will move much faster.
- **`OsStr`/`Path` over `str`/`String`** for paths, since paths may not be valid - **`OsStr`/`Path` over `str`/`String`** for paths, since paths may not be valid
UTF-8. UTF-8.
- **Macros sparingly**, and **comments that explain *why***, kept up to date. - **Macros sparingly**, and **comments that explain *why***, kept up to date.
- **Don't silence clippy with `#[allow(...)]`.** In particular, we don't want to
see `#[allow(dead_code)]`; fix the underlying issue (or remove the unused code)
instead of suppressing the lint.
## For contributors: getting your PR reviewed ## For contributors: getting your PR reviewed