From 773a88d028efc2a4b38472f36fb42a631094e681 Mon Sep 17 00:00:00 2001 From: Sylvestre Ledru Date: Sat, 30 May 2026 11:19:01 +0200 Subject: [PATCH] reviews: discourage silencing clippy with allow(dead_code) --- content/reviews.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/content/reviews.md b/content/reviews.md index 0f9624732..6e0f02073 100644 --- a/content/reviews.md +++ b/content/reviews.md @@ -86,6 +86,9 @@ check these before requesting a review, your PR will move much faster. - **`OsStr`/`Path` over `str`/`String`** for paths, since paths may not be valid UTF-8. - **Macros sparingly**, and **comments that explain *why***, kept up to date. +- **Don't silence clippy with `#[allow(...)]`.** In particular, we don't want to + see `#[allow(dead_code)]`; fix the underlying issue (or remove the unused code) + instead of suppressing the lint. ## For contributors: getting your PR reviewed