When a range command is first evaluated on a line after its numeric first
address (inside a block, or after d, n, N, c or a branch skipped it), start
the range on the current line, as GNU sed does, unless a numeric second
address has also been passed. The range can start this way only once.
Fixes#541
The substitution and transliteration compilers read the delimiter with
ScriptCharProvider::current() even when the command letter was the last
character on the line. This indexed past the end of the line and
aborted.
Check for the end of the line first and report an unterminated command,
as GNU sed does. Scripts such as `s`, `1y`, and `p;s` now exit 1 with a
diagnostic instead of aborting.
The address-parser aborts from #570 were fixed separately in #578.
When stderr is a terminal (or UUTILS_DIAG=always), quote the offending
script line and underline the faulty character, in the layout uucore's
diagnostics use. Pipes and the test suite still get the single-line
message.
Both error constructors handle this, so no call site changes.
ScriptLocation now carries the line text, captured only when diagnostics
are on and shared between commands from the same line, so semantic
errors raised after compilation can still be drawn.
Anything that cannot be drawn (non-UTF-8 script, empty line, no line
recorded) leaves the message unchanged.
A range address that ended early made the parser panic: `1~` read past
the end of the line, and `1~p`, `1,~p` or `1,p` handed a command letter
to the address parser, which only knew how to panic on it. A missing
~step now counts as 0, and a comma with no address after it is reported
as an unexpected `,'. The address parser returns an error instead of
panicking.
A step of 0 was not handled either: `2,~0` ran to the end of the input
instead of selecting line 2 alone, and `0~0`, which can select no line,
was accepted.
Start an mdBook under docs/, laid out as in coreutils, and move the list of
extensions and incompatibilities out of the README into it. The README keeps
a pointer.
A Documentation workflow builds the book with mdbook 0.5.0, the version the
uutils website uses, whenever docs/ changes, and uploads it as an artifact.
mdbook 0.5 rejects the `multilingual` field coreutils still carries (the
website strips it before building), so the book leaves it out.
sed -i with more than one file treated them as one continuous stream:
line numbers continued across files, $ matched only the last line of
the last file, and N could join lines from different files. GNU sed
documents -i as implying -s, so enable separate-file processing for
--in-place as well as --separate.
There was a second bug when automatic output was suppressed. At the end
of a file, process_file cleared a pending N action only when
!context.quiet. With -n, the action carried into the next file and
joined with its first line. Clear the action in either mode, but write
the pattern space only when automatic output is enabled.
The same bug can be reproduced without -i. With f1 containing a1, a2,
a3 and f2 containing b1, b2, b3:
sed -n -s -e 'N;s/\n/+/;p' f1 f2
Before this change it prints a1+a2, a3+b1, b2+b3. GNU prints a1+a2,
b1+b2.
Add coverage for line numbers, $, ranges, N across file boundaries,
hold space, Q, backup suffixes, and -n.
The R command reads one line at a time from a named file. All R commands
naming the same file share a single cursor so they read successive lines,
matching GNU sed. Rejected under --sandbox like the other file commands.
Includes unit and integration tests. Makes the GNU sed testsuite `cmd-R`
test pass.
Adjust `l` command to list Unicode characters by default as
octal byte sequences of the corresponding UTF-8 bytes.
A new -U --uutil-extensions option allows listing them
with the common Unicode \u and \U hex escapes.
Without en_US.UTF-8, ru_RU.UTF-8 and el_GR.iso88597 the testsuite silently
skips eight multibyte tests, hiding both regressions and improvements.
Also make require_el_iso88597_locale_ probe locale -a instead of always
skipping.
Replace `NamedTempFile` with a regular file inside a `TempDir`, so the
file is closed and can be renamed or replaced by in-place editing on
Windows. `TempDir` also simplifies cleanup by automatically removing
the file, backup, and directory when dropped.
Point cargo-binstall at the archives published by dist in the GitHub
releases, so 'cargo binstall sed' fetches a prebuilt binary instead of
building from source.
* feat: add T command (branch on no-substitution)
Implements the GNU `T LABEL` command: branch to LABEL if no s///
substitution has succeeded since the last input line was read or the
last t/T was taken. It is the inverse of `t` and shares the same
address and label parsing.
Wires 'T' into get_cmd_spec, resolve_branch_targets, and the processor
branch logic, resetting the substitution flag on evaluation just like
't'. Adds integration tests (simple branch + flag-clear) and a cmd-spec
unit test.
Closes#395
Co-authored-by: Diomidis Spinellis <dds@aueb.gr>
* ci: re-trigger checks (windows runner crates.io download flake)
* Disable T in POSIX mode
---------
Co-authored-by: mukunda katta <mukunda.vjcs6@gmail.com>
* implement version command
* add tests for version option
* fix patch comparsion
* absurd extreme comparsion fix
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* accept missing minor or patch
* guard 'v' with if posix
* add a few tests
* add test_default_version
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* check if minor is empty and push zero instead of shadowing
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* chore: fix typo
* add: standalone e command
Implement the 'e' command. No argument implies execution of pattern space and any respective argument is to run with the output written to stream. Rejected under --posix and --sandbox.
Also stop silently swallowing shell stderr for e and s///e.
Signed-off-by: PranavRJoshi <pranavrjoshi1@gmail.com>
* add: e command tests
Includes 17 new tests. Cover both forms of the new 'e' command: with-argument execution (including shell side effects, addressing, ';' not separating the argument, escape decoding, and backslash continuation) and the no-argument pattern-space form. Also cover --posix/--sandbox rejection and stderr surfacing on command failure.
Signed-off-by: PranavRJoshi <pranavrjoshi1@gmail.com>
* chore: gate LF-related tests to UNIIX only
* address e command review
Validate shell output as utf-8 and error out instead of lossily converting it. Make CRLF strip conditionally compile to Windows only. Rename execute_pattern_as_shell to execute_pattern_as_shell_command. Add tests for non-utf-8 error paths.
Signed-off-by: PranavRJoshi <pranavrjoshi1@gmail.com>
* add: Windows tests for e command with argument
Signed-off-by: PranavRJoshi <pranavrjoshi1@gmail.com>
* fix: broken pipe race in sandbox e command test
Signed-off-by: PranavRJoshi <pranavrjoshi1@gmail.com>
* Apply s/// p and e flags in written order
GNU sed applies the 'p' and 'e' substitution flags in the order they appear. 'pe' prints the pre-execution text then executes, while 'ep' executes then prints the result. Record whether 'p' precedes 'e' and apply them accordingly.
Signed-off-by: PranavRJoshi <pranavrjoshi1@gmail.com>
---------
Signed-off-by: PranavRJoshi <pranavrjoshi1@gmail.com>
The original Rust implementation assummed a UTF-8 environment, as is
common in modern systems. This commit improves GNU sed compatibility
by changing most processing to run on bytes rather than Rust's Unicode
characters and strings. This change also improves the handling of binary
files. The commit adds a simple POSIX-compatible locale configuration
to support UTF-8 processing when specified. While at it, also fix
script-specified file handling to take place through OsString and
add a few missing unit tests.
The change fixes two failing GNU test suite cases.
The multiline matching resulted in a large performance regression due to
the indiscriminate use of the dotall (?s) flag. Change the regex
selection process to use only the flag when probably needed.
* reject 'i', 'I', 'm', 'M' and 'E' when --posix flag is set
* add test for issue 401
* formatting
* add a test for 'm' flag in test_posix_reject_flags
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Update compiler.rs
* cargo fmt
* add a const variable with the err msg
* Update compiler.rs
* cargo fmt
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* feat: introduce e substituion for sed
When the s command is requested for sed, the e substitution flag enables execution of the result of substitution as a shell command. It matches the GNU sed behavior.
On src/sed/command.rs, add 'execute' field to 'Substitution' structure.
On src/sed/compiler.rs, handle 'e' in 'compile_subst_flags' and reject it if --posix or --sandbox flag is used in sed.
On src/sed/processor.rs, spawn /bin/sh with -c flag for a successful match and replace the pattern space with the command's standard output stream.
Signed-off-by: PranavRJoshi <pranavrjoshi1@gmail.com>
* chore: comply with rustfmt
Signed-off-by: PranavRJoshi <pranavrjoshi1@gmail.com>
* chore: support for Windows command-line
Instead of calling bourne shell, define a new function: shell_command() with two definitions; conditionally compiling to UNIX-like and Windows. On UNIX-like, executes the bourne shell, whereas command prompt is executed on Windows.
Signed-off-by: PranavRJoshi <pranavrjoshi1@gmail.com>
* chore: check newline for Windows
Unix-like system only uses the newline character whereas Windows uses the carriage return as well as newline. Hence, when working on Windows, we need to truncate the last two characters.
Signed-off-by: PranavRJoshi <pranavrjoshi1@gmail.com>
* add: 'e' flag tests
Nine new tests have been introduced in regards to new 'e' substitution option. 'test_subst_e_flag_multiline_outuput' is conditionally compiled as printf command is not guaranteed to be present on all Windows systems.
Signed-off-by: PranavRJoshi <pranavrjoshi1@gmail.com>
* chore: fallback for shell_command
Executing a shell or a command prompt requires appropriate platforms. WASM does not currently support it.
Also fix a linting issue.
Signed-off-by: PranavRJoshi <pranavrjoshi1@gmail.com>
* chore: linting cleanup
Signed-off-by: PranavRJoshi <pranavrjoshi1@gmail.com>
---------
Signed-off-by: PranavRJoshi <pranavrjoshi1@gmail.com>
* feat: support zero-address file insertion
Signed-off-by: PranavRJoshi <pranavrjoshi1@gmail.com>
* Polish the handling of 0r
- Use common constant for error message.
- Simplify command check at compile and runtime.
- Separate runtime handling into a function.
---------
Signed-off-by: PranavRJoshi <pranavrjoshi1@gmail.com>
Co-authored-by: PranavRJoshi <pranavrjoshi1@gmail.com>
* exit with code 1 when no arguments
* add a test for no arguments.
* Update test_sed.rs
* cargo fmt
* pass -n for missing script arguments test
Issue: #274
PR: #409
The previous harness tried to extract sed commands from GNU test scripts
via regex pattern matching, which produced false negatives (comparing
against empty expected output) and false positives. This led to inflated
test counts and unreliable pass/fail signals.
The new approach:
- Provides a lightweight shim for the gnulib test framework (init.sh)
with implementations of compare_, returns_, skip_, framework_failure_,
and all require_* functions
- Executes each .sh test script from the GNU testsuite directly,
injecting our Rust sed binary via PATH
- Uses a clean srcdir with symlinks to real test data files
- Adds per-test timeout (10s) to catch infinite loops, with SIGTERM
isolation so timeout signals don't kill the parent script
- Properly propagates exit codes (0=pass, 77=skip, 99=framework failure)
Results are now consistent with CI tracking (~12% pass rate) with
clear PASS/FAIL/SKIP/timeout categorization.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix: remove newline swap in exchange and swap content only
* fix: support non empty hold spaces and newline appended hold spaces
* nit: period in comment
* nit: useless comment removal
* chore: clarify newline swap logic for `x`
Loaded 20 of 58 files, more files were not shown because too many files have changed in this diff.
Show more
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
renovate[bot]
oech3
Anthony DePasquale
sap1110
Sylvestre Ledru
Sichen
Daniel Hofstetter
xtqqczze
Jorge Polanco
Diomidis Spinellis
Franklin-Qi
Develandpre-commit-ci[bot]
Pranav Ram Joshi
Loukas Papadopoulos
pocopepe
YumeYuka
白彩恋
Kevin BurkeandClaude Opus 4.6
Alexander Wang
dependabot[bot]