Merge pull request #560 from cakebaker/move_lints_from_ci_to_cargo_toml

Move lints from CI to `Cargo.toml`

.github/workflows/code-quality.yml

@@ -74,9 +74,8 @@ jobs:
         run: |
           ## `cargo clippy` lint testing
           unset fault
-          CLIPPY_FLAGS="-W clippy::default_trait_access -W clippy::manual_string_new -W clippy::cognitive_complexity -W clippy::implicit_clone -W clippy::range-plus-one -W clippy::redundant-clone -W clippy::match_bool -W clippy::semicolon_if_nothing_returned"
           fault_type="${{ steps.vars.outputs.FAULT_TYPE }}"
           fault_prefix=$(echo "$fault_type" | tr '[:lower:]' '[:upper:]')
           # * convert any warnings to GHA UI annotations; ref: <https://help.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-a-warning-message>
-          S=$(cargo clippy --all-targets -pprocps -- ${CLIPPY_FLAGS} -D warnings 2>&1) && printf "%s\n" "$S" || { printf "%s\n" "$S" ; printf "%s" "$S" | sed -E -n -e '/^error:/{' -e "N; s/^error:[[:space:]]+(.*)\\n[[:space:]]+-->[[:space:]]+(.*):([0-9]+):([0-9]+).*$/::${fault_type} file=\2,line=\3,col=\4::${fault_prefix}: \`cargo clippy\`: \1 (file:'\2', line:\3)/p;" -e '}' ; fault=true ; }
+          S=$(cargo clippy --all-targets -pprocps -- -D warnings 2>&1) && printf "%s\n" "$S" || { printf "%s\n" "$S" ; printf "%s" "$S" | sed -E -n -e '/^error:/{' -e "N; s/^error:[[:space:]]+(.*)\\n[[:space:]]+-->[[:space:]]+(.*):([0-9]+):([0-9]+).*$/::${fault_type} file=\2,line=\3,col=\4::${fault_prefix}: \`cargo clippy\`: \1 (file:'\2', line:\3)/p;" -e '}' ; fault=true ; }
           if [ -n "${{ steps.vars.outputs.FAIL_ON_FAULT }}" ] && [ -n "$fault" ]; then exit 1 ; fi

Cargo.toml

@@ -159,3 +159,16 @@ inherits = "release"
 opt-level = "z"
 panic = "abort"
 strip = true
+
+[lints]
+workspace = true
+
+[workspace.lints.clippy]
+default_trait_access = "warn"
+manual_string_new = "warn"
+cognitive_complexity = "warn"
+implicit_clone = "warn"
+range-plus-one = "warn"
+redundant-clone = "warn"
+match_bool = "warn"
+semicolon_if_nothing_returned = "warn"

src/uu/free/Cargo.toml

@@ -10,6 +10,9 @@ keywords.workspace = true
 license.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 bytesize = { workspace = true }
 clap = { workspace = true }

src/uu/pgrep/Cargo.toml

@@ -10,6 +10,9 @@ keywords.workspace = true
 license.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 uucore = { workspace = true, features = ["entries", "signals", "process"] }
 clap = { workspace = true }

src/uu/pidof/Cargo.toml

@@ -10,6 +10,9 @@ keywords.workspace = true
 license.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 uucore = { workspace = true, features = ["process"] }
 clap = { workspace = true }

src/uu/pidwait/Cargo.toml

@@ -10,6 +10,9 @@ keywords.workspace = true
 license.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 nix = { workspace = true }
 uucore = { workspace = true, features = ["entries"] }

src/uu/pkill/Cargo.toml

@@ -10,6 +10,9 @@ keywords.workspace = true
 license.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 uucore = { workspace = true, features = ["entries"] }
 clap = { workspace = true }

src/uu/pmap/Cargo.toml

@@ -10,6 +10,9 @@ keywords.workspace = true
 license.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 uucore = { workspace = true }
 clap = { workspace = true }

src/uu/ps/Cargo.toml

@@ -10,6 +10,9 @@ keywords.workspace = true
 license.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 uucore = { workspace = true, features = ["utmpx"] }
 clap = { workspace = true }

src/uu/pwdx/Cargo.toml

@@ -10,6 +10,9 @@ keywords.workspace = true
 license.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 uucore = { workspace = true }
 clap = { workspace = true }

src/uu/skill/Cargo.toml

@@ -10,6 +10,9 @@ keywords.workspace = true
 license.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 uucore = { workspace = true, features = ["signals"] }
 clap = { workspace = true }

src/uu/slabtop/Cargo.toml

@@ -10,6 +10,9 @@ keywords.workspace = true
 license.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 uucore = { workspace = true }
 clap = { workspace = true }

src/uu/snice/Cargo.toml

@@ -10,6 +10,9 @@ keywords.workspace = true
 license.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 uucore = { workspace = true, features = ["signals"] }
 clap = { workspace = true }

src/uu/sysctl/Cargo.toml

@@ -10,6 +10,9 @@ keywords.workspace = true
 license.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 uucore = { workspace = true }
 clap = { workspace = true }

src/uu/tload/Cargo.toml

@@ -10,6 +10,9 @@ keywords.workspace = true
 license.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 clap = { workspace = true }
 crossterm = { workspace = true }

src/uu/top/Cargo.toml

@@ -10,6 +10,9 @@ keywords.workspace = true
 license.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 uucore = { workspace = true, features = ["utmpx", "uptime", "signals"] }
 clap = { workspace = true }

src/uu/vmstat/Cargo.toml

@@ -10,6 +10,9 @@ keywords.workspace = true
 license.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 bytesize = { workspace = true }
 clap = { workspace = true }

src/uu/w/Cargo.toml

@@ -10,6 +10,9 @@ keywords.workspace = true
 license.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 uucore = { workspace = true, features = ["utmpx", "uptime"] }
 clap = { workspace = true }

src/uu/watch/Cargo.toml

@@ -10,6 +10,9 @@ keywords.workspace = true
 license.workspace = true
 version.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 uucore = { workspace = true }
 clap = { workspace = true }