Dawid Esterhuizen
c034d50bdc
staging: rtl8712: Statements should start on a tabstop
...
This path fixes four checkpatch.pl warnings:
Statements should start on a tabstop
Signed-off-by: Dawid Esterhuizen <desterhuizen@gmail.com >
Link: https://lore.kernel.org/r/YVXGsMZDGmdGjErJ@kkobus.whirley.local
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-10-05 12:32:42 +02:00
Michael Straube
b9ba687515
staging: r8188eu: remove inirp_deinit from struct hal_ops
...
Remove inirp_deinit from struct hal_ops and remove the wrappers
rtw_hal_inirp_deinit() and rtl8188eu_inirp_deinit(). Call
rtw_read_port_cancel() directly instead.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20210929192657.9569-8-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-10-05 12:32:28 +02:00
Michael Straube
3a587ff652
staging: r8188eu: remove inirp_init from struct hal_ops
...
Remove inirp_init from struct hal_ops and remove its wrapper
rtw_hal_inirp_init(). Call rtl8188eu_inirp_init() directly instead.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20210929192657.9569-7-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-10-05 12:32:28 +02:00
Michael Straube
5d44452604
staging: r8188eu: remove free_recv_priv from struct hal_ops
...
Remove free_recv_priv from struct hal_ops and remove its wrapper
rtw_hal_free_recv_priv(). Call rtl8188eu_free_recv_priv() directly
instead.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20210929192657.9569-6-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-10-05 12:32:28 +02:00
Michael Straube
69a400415f
staging: r8188eu: remove init_recv_priv from struct hal_ops
...
Remove init_recv_priv from struct hal_ops and remove its wrapper
rtw_hal_init_recv_priv(). Call rtl8188eu_init_recv_priv() directly
instead.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20210929192657.9569-5-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-10-05 12:32:28 +02:00
Michael Straube
2918246179
staging: r8188eu: remove init_xmit_priv from struct hal_ops
...
Remove init_xmit_priv from struct hal_ops an remove its wrapper
rtw_hal_init_xmit_priv(). Call rtl8188eu_init_xmit_priv() directly
instead.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20210929192657.9569-4-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-10-05 12:32:28 +02:00
Michael Straube
9d67c44c3d
staging: r8188eu: remove GetHalDefVarHandler from struct hal_ops
...
Remove GetHalDefVarHandler from struct hal_ops and remove its wrapper
rtw_hal_get_def_var(). Call GetHalDefVar8188EUsb() directly instead.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20210929192657.9569-3-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-10-05 12:32:28 +02:00
Michael Straube
515d3cf7fa
staging: r8188eu: remove SetHalDefVarHandler from struct hal_ops
...
Remove SetHalDefVarHandler from struct hal_ops and remove its wrapper
rtw_hal_set_def_var(). Call SetHalDefVar8188EUsb() directly instead.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20210929192657.9569-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-10-05 12:32:27 +02:00
Michael Straube
f49435793b
staging: r8188eu: remove odm_GlobalAdapterCheck()
...
Function odm_GlobalAdapterCheck() is empty, remove it.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20210928131930.8866-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-10-05 12:31:59 +02:00
Michael Straube
a19d513367
staging: r8188eu: remove odm_DynamicBBPowerSaving()
...
SupportICType is ODM_RTL8188E in this driver. So function
odm_DynamicBBPowerSaving() does nothing, remove it. It is the only
user of odm_1R_CCA(), remove that function as well.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20210928131930.8866-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-10-05 12:31:59 +02:00
Saurav Girepunje
bb09212a6f
staging: rtl8192u: remove unused static variable
...
remove unused static variable channels.
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com >
Link: https://lore.kernel.org/r/YVjN9FT4KjLGX/Zg@user
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-10-05 12:31:13 +02:00
Saurav Girepunje
11dc495619
staging: rtl8192e: remove unused variable ieee
...
Remove unused local variable ieee from ActivateBAEntry().
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com >
Link: https://lore.kernel.org/r/YVmAhOSRB8yc/iwU@user
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-10-05 12:30:50 +02:00
Gustavo A. R. Silva
c08976563d
staging: r8188eu: Replace zero-length array with flexible-array member
...
One-element and zero-length arrays are deprecated and should be
replaced with flexible-array members[1].
Replace zero-length array with flexible-array member and make use
of the struct_size() helper in kmalloc().
[1] https://www.kernel.org/doc/html/v5.10/process/deprecated.html#zero-length-and-one-element-arrays
Link: https://github.com/KSPP/linux/issues/78
Link: https://github.com/KSPP/linux/issues/160
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org >
Link: https://lore.kernel.org/r/20210929193658.GA339070@embeddedor
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-10-05 12:28:48 +02:00
Saurav Girepunje
403aa62da3
staging: rtl8723bs: core: remove reassignment of same value to variable
...
Remove reassignment of same value to variable pstat->auth_seq.
On if (seq == 1) assigning the value 2. At the end of if statement
also assigning the value pstat->auth_seq = seq + 1 that is again
assigning the value 2.
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com >
Link: https://lore.kernel.org/r/YVnX1HIYoisW621x@user
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-10-05 12:28:22 +02:00
Saurav Girepunje
d98f096cf5
staging: rtl8723bs: core: remove condition never execute
...
Remove condition which never get execute.
as pattrib->mdata is always zero before if condition check.
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com >
Link: https://lore.kernel.org/r/YVnTJCoz2qsXDXGc@user
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-10-05 12:28:15 +02:00
Gustavo A. R. Silva
0d197f2088
staging: rtl8723bs: Replace zero-length array with flexible-array member
...
One-element and zero-length arrays are deprecated and should be
replaced with flexible-array members[1].
Replace zero-length array with flexible-array member and make use
of the struct_size() helper.
[1] https://www.kernel.org/doc/html/v5.10/process/deprecated.html#zero-length-and-one-element-arrays
Link: https://github.com/KSPP/linux/issues/78
Link: https://github.com/KSPP/linux/issues/160
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org >
Link: https://lore.kernel.org/r/20210929194118.GA340431@embeddedor
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-10-05 12:28:06 +02:00
Longji Guo
42bdb41d2e
staging: rtl8723bs: remove meaningless pstat->passoc_req check in OnAssocReq()
...
kfree(NULL) is safe and the check 'if (pstat->passoc_req)' before kfree
is not necessary.
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Signed-off-by: Longji Guo <guolongji@uniontech.com >
Link: https://lore.kernel.org/r/20210929110613.29979-1-guolongji@uniontech.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-10-05 12:27:50 +02:00
Stefan Wahren
6649335e1f
staging: vchiq_arm: move platform structs to vchiq_arm.c
...
After merging vchiq_2835_arm.c into vchiq_arm.c some platform structs
doesn't need to exported anymore. So move them into the C file.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com >
Link: https://lore.kernel.org/r/1633264369-998-4-git-send-email-stefan.wahren@i2se.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-10-05 12:21:46 +02:00
Stefan Wahren
89cc4218f6
staging: vchiq_arm: drop unnecessary declarations
...
vchiq_arm.h contains some unnecessary declarations, so drop them.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com >
Link: https://lore.kernel.org/r/1633264369-998-3-git-send-email-stefan.wahren@i2se.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-10-05 12:21:46 +02:00
Stefan Wahren
631c5a5312
staging: vchiq_arm: re-order vchiq_arm_init_state
...
This moves vchiq_arm_init_state() above its caller, so we can drop the
now unnecessary forward declaration and make the function static.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com >
Link: https://lore.kernel.org/r/1633264369-998-2-git-send-email-stefan.wahren@i2se.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-10-05 12:21:46 +02:00
Tommaso Merciai
fbf6fafe5a
staging: vt6655: fix camelcase in pbyCxtBuf
...
Replace camel case variable name for variable pbyCxtBuf
with snake case equivalent, in mac.h
Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com >
Link: https://lore.kernel.org/r/20211001202504.410383-1-tomm.merciai@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-10-05 12:21:20 +02:00
Larry Finger
42ce32b1ae
staging: r8188eu: Remove unused macros and defines from odm.h
...
This header defines a number of symbols/macros that are not used and can
be removed. In addition, it defines a number of synonym symbols that are
used interchangeably in the source. Only one is now selected.
In addition to the above, a number of comments that have no meaning for
this chip have been removed.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net >
Link: https://lore.kernel.org/r/20210927214527.5341-1-Larry.Finger@lwfinger.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-09-28 09:13:08 +02:00
Nikita Yushchenko
bd46a1f12c
staging: most: dim2: use if statements instead of ?: expressions
...
For better maintainability, replace conditional expressions with if
statements in the drivers' probe routine.
Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com >
Link: https://lore.kernel.org/r/20210927160649.29209-1-nikita.yoush@cogentembedded.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-09-28 09:11:26 +02:00
Nikita Yushchenko
9b27a62d11
staging: most: dim2: force fcnt=3 on Renesas GEN3
...
Per Renesas datasheet, MLBC0 register's fcnt field in the embedded
dim2 module must be never set to value different from 3.
Enforce that, via an optional field in struct dim2_platform_data.
Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com >
Link: https://lore.kernel.org/r/20210927155804.27877-1-nikita.yoush@cogentembedded.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-09-28 09:11:05 +02:00
Pavel Skripkin
c090666ba9
staging: r8188eu: remove mutex 'usb_vendor_req_mutex'
...
Remove mutex 'usb_vendor_req_mutex'.
It was used to protect a shared buffer for USB requests and, since that
buffer is removed in previous patch, this mutex is now useless.
Furthermore, because it was used to serialize the calls to the Core USB
API, we thoroughly tested the enabling of concurrent firing of USB requests
without the mutex and found no problems of any kind in common use cases.
Co-developed-by: Fabio M. De Francesco <fmdefrancesco@gmail.com >
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com >
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com >
Link: https://lore.kernel.org/r/20210924122705.3781-17-fmdefrancesco@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-09-27 17:37:12 +02:00