Files
snapd/timeutil/synchronized.go
Michael Vogt ec78fe20c8 timeutil: remove (debug) logging from IsNTPSynchronized
The logging in this generic helper is unneeded and excessive. It
can also be called a lot which spams the logger.
2021-12-09 19:32:44 +01:00

74 lines
1.9 KiB
Go

// -*- Mode: Go; indent-tabs-mode: t -*-
/*
* Copyright (C) 2021 Canonical Ltd
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
package timeutil
import (
"fmt"
"github.com/godbus/dbus"
"github.com/snapcore/snapd/dbusutil"
)
func isNoServiceOrUnknownPropertyDbusErr(err error) bool {
derr, ok := err.(dbus.Error)
if !ok {
return false
}
switch derr.Name {
case "org.freedesktop.DBus.Error.ServiceUnknown", "org.freedesktop.DBus.Error.UnknownProperty":
return true
}
return false
}
type NoTimedate1Error struct {
Err error
}
func (e NoTimedate1Error) Error() string {
return fmt.Sprintf("cannot find org.freedesktop.timedate1 dbus service: %v", e.Err)
}
// IsNTPSynchronized returns true if the time is syncronized according to
// systemd-timedated.
func IsNTPSynchronized() (bool, error) {
// shared connection, no need to close
conn, err := dbusutil.SystemBus()
if err != nil {
return false, NoTimedate1Error{err}
}
tdObj := conn.Object("org.freedesktop.timedate1", "/org/freedesktop/timedate1")
dbusV, err := tdObj.GetProperty("org.freedesktop.timedate1.NTPSynchronized")
if err != nil {
if isNoServiceOrUnknownPropertyDbusErr(err) {
return false, NoTimedate1Error{err}
}
return false, fmt.Errorf("cannot check for ntp sync: %v", err)
}
v, ok := dbusV.Value().(bool)
if !ok {
return false, fmt.Errorf("timedate1 returned invalid value for NTPSynchronized property: %s", dbusV)
}
return v, nil
}