snapd

mirror of https://github.com/token2/snapd.git synced 2026-03-13 11:15:47 -07:00

Files

Maciej Borzecki 0434dc4575 timeutil: fix data race in unit tests

Exported object is running in a separate goroutine, accesses to fields need to
by synchronized.

```
==================
WARNING: DATA RACE
Read at 0x00c000536430 by goroutine 36:
  github.com/snapcore/snapd/timeutil_test.timedate1Api.Get()
      /home/maciek/work/canonical/snapd/timeutil/synchronized_test.go:87 +0x126
  runtime.call64()
      /usr/lib/go/src/runtime/asm_amd64.s:772 +0x42
  reflect.Value.Call()
      /usr/lib/go/src/reflect/value.go:380 +0xb5
  github.com/godbus/dbus.exportedMethod.Call()
      /home/maciek/work/canonical/snapd/vendor/github.com/godbus/dbus/default_handler.go:128 +0x219
  github.com/godbus/dbus.(*exportedMethod).Call()
      <autogenerated>:1 +0x84
  github.com/godbus/dbus.(*Conn).handleCall()
      /home/maciek/work/canonical/snapd/vendor/github.com/godbus/dbus/export.go:153 +0x591
  github.com/godbus/dbus.(*Conn).inWorker.gowrap1()
      /home/maciek/work/canonical/snapd/vendor/github.com/godbus/dbus/conn.go:334 +0x44

Previous write at 0x00c000536430 by goroutine 30:
  github.com/snapcore/snapd/timeutil_test.(*syncedSuite).TestIsNTPSynchronized()
      /home/maciek/work/canonical/snapd/timeutil/synchronized_test.go:118 +0x298
  runtime.call16()
      /usr/lib/go/src/runtime/asm_amd64.s:770 +0x42
  reflect.Value.Call()
      /usr/lib/go/src/reflect/value.go:380 +0xb5
  gopkg.in/check%2ev1.(*suiteRunner).forkTest.func1()
      /home/maciek/work/canonical/snapd/vendor/gopkg.in/check.v1/check.go:775 +0x9c5
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /home/maciek/work/canonical/snapd/vendor/gopkg.in/check.v1/check.go:669 +0xe9

Goroutine 36 (running) created at:
  github.com/godbus/dbus.(*Conn).inWorker()
      /home/maciek/work/canonical/snapd/vendor/github.com/godbus/dbus/conn.go:334 +0x346
  github.com/godbus/dbus.(*Conn).Auth.gowrap1()
      /home/maciek/work/canonical/snapd/vendor/github.com/godbus/dbus/auth.go:118 +0x33

Goroutine 30 (running) created at:
  gopkg.in/check%2ev1.(*suiteRunner).forkCall()
      /home/maciek/work/canonical/snapd/vendor/gopkg.in/check.v1/check.go:666 +0x5ba
  gopkg.in/check%2ev1.(*suiteRunner).forkTest()
      /home/maciek/work/canonical/snapd/vendor/gopkg.in/check.v1/check.go:757 +0x155
  gopkg.in/check%2ev1.(*suiteRunner).runTest()
      /home/maciek/work/canonical/snapd/vendor/gopkg.in/check.v1/check.go:812 +0x419
  gopkg.in/check%2ev1.(*suiteRunner).run()
      /home/maciek/work/canonical/snapd/vendor/gopkg.in/check.v1/check.go:618 +0x3c6
  gopkg.in/check%2ev1.Run()
      /home/maciek/work/canonical/snapd/vendor/gopkg.in/check.v1/run.go:92 +0x44
  gopkg.in/check%2ev1.RunAll()
      /home/maciek/work/canonical/snapd/vendor/gopkg.in/check.v1/run.go:84 +0x124
  gopkg.in/check%2ev1.TestingT()
      /home/maciek/work/canonical/snapd/vendor/gopkg.in/check.v1/run.go:72 +0x5d3
  github.com/snapcore/snapd/timeutil_test.Test()
      /home/maciek/work/canonical/snapd/timeutil/schedule_test.go:33 +0x26
  testing.tRunner()
      /usr/lib/go/src/testing/testing.go:1689 +0x21e
  testing.(*T).Run.gowrap1()
      /usr/lib/go/src/testing/testing.go:1742 +0x44
==================
```

Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>

2024-04-08 09:46:27 +02:00

export_test.go

cmd/snap: show user+gating hold info in 'snap info'

2022-12-12 12:37:20 +01:00

human_test.go

many: replace use of "sanity" with more inclusive naming

2022-03-14 18:22:34 +01:00

human.go

many: correct struct fields and output key

2022-12-12 12:37:20 +01:00

schedule_test.go

timeutil: check error result in test