token2/snapd
0
0
Fork 0
mirror of https://github.com/token2/snapd.git synced 2026-03-13 11:15:47 -07:00
Code Issues Packages Projects Releases Wiki Activity

tests/lib/tools/tests.invariant: use better broken snaps check implementation

Browse Source 
Until the referenced PR has landed, we can use this better version from Maciej
which also gets the revision numbers of the broken snaps as well.

Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
This commit is contained in:
Ian Johnson
2021-12-13 18:30:29 -06:00
parent d6eb2b3f4a
commit 2b0df17882
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/lib/tools/tests.invariant
View File

@@ -126,10 +126,12 @@ check_leftover_defer_sh() {
check_broken_snaps() {
n="$1" # invariant name
(
# awk is hard - this just gives us the names of snaps that are broken
for broke_snap in $(snap list --all | tail -n +2 | awk '{print $(NF) " " $1}' | grep 'broken ' | awk '{print $(NF)}' | sort | uniq); do
# could be multiple broken revisions
echo "snap ${broke_snap} is broken"
# fist column is the snap name, revision is 3rd from the end, we cannot use $3 as
# broken snaps have empty version column
# TODO: when https://github.com/snapcore/snapd/pull/11166 is landed,
# this can be simplified
snap list --all | awk '/,?broken,?/ { print $1, $(NF-3) }' | while read -r name rev; do
echo "snap $name ($rev) is broken"
done
) > "$TESTSTMP/tests.invariant.$n"
if [ -s "$TESTSTMP/tests.invariant.$n" ]; then