token2/snapd
0
0
Fork 0
mirror of https://github.com/token2/snapd.git synced 2026-03-13 11:15:47 -07:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #10672 from pedronis/store-unexpectedly-set

Browse Source 
store: make sure expectedZeroFields in tests gets updated

* drop Assumes
* change the test so that the case where a field is now set gets noticed
This commit is contained in:
Ian Johnson
2021-08-24 08:43:30 -05:00
committed by GitHub
parent 4f11dd447b 730bc734f5
commit 077634b4d9
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
store/details_v2_test.go
View File

@@ -288,7 +288,6 @@ func (s *detailsV2Suite) TestInfoFromStoreSnap(c *C) {
expectedZeroFields := []string{
"SuggestedName",
"InstanceKey",
"Assumes",
"OriginalTitle",
"OriginalSummary",
"OriginalDescription",
@@ -324,9 +323,11 @@ func (s *detailsV2Suite) TestInfoFromStoreSnap(c *C) {
checker(pfx+f.Name+".", v)
continue
}
name := pfx + f.Name
if reflect.DeepEqual(v.Interface(), reflect.Zero(f.Type).Interface()) {
name := pfx + f.Name
c.Check(expectedZeroFields, testutil.Contains, name, Commentf("%s not set", name))
} else {
c.Check(expectedZeroFields, Not(testutil.Contains), name, Commentf("%s unexpectedly set", name))
}
}
}