rfidrig/proxmark3
0
0
Fork 0
mirror of https://github.com/RfidResearchGroup/proxmark3.git synced 2026-05-12 11:18:11 -07:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3167 from AlxCzl/master

Browse Source 
Fix `smart pcsc`: card is never detected and a buffer overflow with 20+ bytes ATRs
This commit is contained in:
Iceman
2026-03-25 07:32:34 +07:00
committed by GitHub
parent 7bedde39a7 232bb1959c
commit f246e431db
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/cmdsmartcard.c
+4 -2
View File
@@ -1312,7 +1312,9 @@ static int CmdPCSC(const char *Cmd) {
}
}
uint8_t res[22] = {0};
// ISO 7816-3 specifies that ATRs can be 2 to 33 bytes long
// but some custom cards may support up to 256 bytes long ATRs
uint8_t res[2 + 256] = {0};
res[1] = atrLen;
memcpy(res + 2, atr, atrLen);
mbedtls_net_send(&netCtx, res, 2 + atrLen);
@@ -1393,7 +1395,7 @@ static int CmdPCSC(const char *Cmd) {
// ISO 15.
if (use_contact && IfPm3Iso14443() && smart_select(false, &card) == PM3_SUCCESS) {
if (use_contact && IfPm3Iso14443() && smart_select(false, &card)) {
have_card = true;
card_type = CC_CONTACT;
}