Fix data being xored twice

When printing the BCD encoded Card ID, data is being XOR'd twice: once with a for-loop, and a second time for printing, cancelling the operation and displaying garbage

Signed-off-by: Jean-Michel Picod <jmichel.p@gmail.com>
This commit is contained in:
Jean-Michel Picod
2025-09-20 23:21:31 +02:00
committed by GitHub
parent 45fe423cd4
commit 0c061d9cde
+3 -3
View File
@@ -300,9 +300,9 @@ static int decode_and_print_memory(uint16_t card_size, const uint8_t *input_buff
// does this one work? (Answer: Only if KGH/BGH is used with BCD encoded card number! So maybe this will show just garbage...)
if (wrp_len == 8) {
PrintAndLogEx(SUCCESS, "Card ID: " _YELLOW_("%2X%02X%02X"),
data[i - 4] ^ crc,
data[i - 3] ^ crc,
data[i - 2] ^ crc
data[i - 4],
data[i - 3],
data[i - 2]
);
}
}