print_n_panic/Microtransactions64
0
0
Fork 0
mirror of https://github.com/Print-and-Panic/Microtransactions64.git synced 2026-01-21 10:17:19 -08:00
Code Issues Packages Projects Releases Wiki Activity

Catch major reverb buffer allocation bug

Browse Source
This commit is contained in:
gheskett
2021-08-03 16:09:53 -05:00
parent f828ad38e3
commit 4b51444250
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/audio/heap.c
View File

@@ -1443,7 +1443,7 @@ void audio_reset_session(void) {
#ifdef BETTER_REVERB
if (consoleBetterReverb) {
for (i = 0; i < NUM_ALLPASS; ++i)
delays[i] = delaysBaseline[i] / (1 << (gReverbDownsampleRate - 1));
delays[i] = delaysBaseline[i] / gReverbDownsampleRate;
delayBufs = (s32***) soundAlloc(&gAudioSessionPool, 2 * sizeof(s32**));
delayBufs[0] = (s32**) soundAlloc(&gAudioSessionPool, NUM_ALLPASS * sizeof(s32*));

3
src/audio/synthesis.c
View File

@@ -46,7 +46,7 @@ struct VolumeChange {
/* ----------------------------------------------------------REVERB PARAMETERS----------------------------------------------------------------- */
s32 gReverbRevIndex = 0x9A; // Affects decay time mostly; can be messed with at any time
s32 gReverbRevIndex = 0x9A; // Affects decay time mostly; can be messed with at any time (and also probably the most useful parameter here)
s32 gReverbGainIndex = 0xA6; // Affects signal retransmitted back into buffers; can be messed with at any time
s32 gReverbWetSignal = 0xF3; // Amount of reverb specific output in final signal; can be messed with at any time
s32 gReverbDrySignal = 0x26; // Amount of original input in final signal (large values can cause terrible feedback!); can be messed with at any time
@@ -299,6 +299,7 @@ void prepare_reverb_ring_buffer(s32 chunkLen, u32 updateIndex) {
#ifdef BETTER_REVERB
if (consoleBetterReverb) {
item = &gSynthesisReverb.items[gSynthesisReverb.curFrame][updateIndex];
osInvalDCache(item->toDownsampleLeft, DEFAULT_LEN_2CH);
if (gReverbDownsampleRate != 1) {
for (srcPos = 0, dstPos = item->startPos; dstPos < item->lengthA / 2 + item->startPos;
srcPos += gReverbDownsampleRate, dstPos++) {