pokecrystal-board/data
Andrew Cook 0f5540740b
Some Mobile code labeling and removed magic numbers (#993)
* Macro loop for EmptyAllSRAMBanks

* Many things labeled and magic numbers removed

* Conform to the style guide

* Rename URLs in mobile_46

* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS

* Update engine/menus/empty_sram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update ram/wram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Remove underscore from Set*DownloadURL symbols

* Begin Labeling TradeCornerHoldMon routines

* Add wMobileMon party_struct

* Add TRADE_CORNER_REQUEST_LENGTH constant

* Name battle tower action functions

* Label trade corner send/receive buffer

* Label the saved copy of the trade corner pokemon

also fix mailmsg_jp

* So many copies of decodeBase64Character

* Label another buffer

* Fix Alignment and use MOBILE_EMAIL_LENGTH

* `Function11ad8a` -> `MobileIncJumptableIndex`

* Apply Rangi Suggestions pass 1

Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>

* Apply Suggestions 2

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
2022-09-14 19:49:58 -05:00
..
battle Clean up bugs commented in the source code (#912) 2022-07-09 16:12:02 -05:00
battle_anims Split "gfx anims" into "pic anims" and "sprite anims" 2022-07-04 01:11:42 -04:00
battle_tower Verify data table sizes with table_width and assert_table_length macros 2021-03-04 00:15:03 -05:00
collision RGBDS syntax updates (#905) 2022-06-06 17:25:42 -04:00
decorations RGBDS syntax updates (#905) 2022-06-06 17:25:42 -04:00
events Some Mobile code labeling and removed magic numbers (#993) 2022-09-14 19:49:58 -05:00
items Clean up bugs commented in the source code (#912) 2022-07-09 16:12:02 -05:00
maps Refer to "Rival", not "Silver" (#983) 2022-08-10 21:24:56 -04:00
moves PP must be 40 or less 2022-08-10 21:20:53 -04:00
phone RGBDS syntax updates (#905) 2022-06-06 17:25:42 -04:00
pokemon RGBDS syntax updates (#905) 2022-06-06 17:25:42 -04:00
radio Miscellaneous cleanup 2021-03-22 16:41:17 -04:00
sprite_anims spriteanimoam macro corresponds to battleanimoam 2022-07-04 01:11:42 -04:00
sprites Refer to "Rival", not "Silver" (#983) 2022-08-10 21:24:56 -04:00
text Clean up bugs commented in the source code (#912) 2022-07-09 16:12:02 -05:00
tilesets unused_dark_cave -> unused_johto (goes with the beta Johto town+city maps) 2020-02-25 19:18:24 -05:00
trainers Refer to "Rival", not "Silver" (#983) 2022-08-10 21:24:56 -04:00
types Verify data table sizes with table_width and assert_table_length macros 2021-03-04 00:15:03 -05:00
wild RGBDS syntax updates (#905) 2022-06-06 17:25:42 -04:00
credits_script.asm Remove all address comments 2018-06-24 16:13:22 +02:00
credits_strings.asm Verify data table sizes with table_width and assert_table_length macros 2021-03-04 00:15:03 -05:00
default_options.asm Verify data table sizes with table_width and assert_table_length macros 2021-03-04 00:15:03 -05:00
growth_rates.asm RGBDS syntax updates (#905) 2022-06-06 17:25:42 -04:00
icon_pointers.asm Verify data table sizes with table_width and assert_table_length macros 2021-03-04 00:15:03 -05:00
mon_menu.asm RGBDS syntax updates (#905) 2022-06-06 17:25:42 -04:00
party_menu_qualities.asm RGBDS syntax updates (#905) 2022-06-06 17:25:42 -04:00
player_names.asm Verify uneven list sizes with list_start, li, and assert_list_length macros 2021-03-22 17:17:08 -04:00
predef_pointers.asm RGBDS syntax updates (#905) 2022-06-06 17:25:42 -04:00
sgb_ctrl_packets.asm RGBDS syntax updates (#905) 2022-06-06 17:25:42 -04:00
text_buffers.asm Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
tilesets.asm RGBDS syntax updates (#905) 2022-06-06 17:25:42 -04:00