Rangi
bcc0d633e9
Identify the remaining (non-mobile) uses of another WRAM union
2020-10-29 14:51:41 -04:00
Rangi
ea426a8879
Identify more WRAM labels, and start a <X>_DummyFunction label convention
2020-10-28 14:34:38 -04:00
Rangi
6d333bed5f
Replace many '; unused' with '; unreferenced'
2020-10-28 10:21:10 -04:00
Rangi
2738858985
Create data/collision/ for tile collision-related data
2020-10-27 10:00:56 -04:00
Rangi
c85ba78b77
Use more assertions to ensure correct code and data
2020-10-26 22:24:38 -04:00
Rangi
9dcdad5e60
Comment, remove, or revise many unreferenced labels
2020-10-26 20:29:58 -04:00
Rangi
bd3f634049
Identify remaining map object labels
2020-10-22 21:30:21 -04:00
Rangi
6b7ade66da
Identify more unnamed labels
2020-10-05 16:15:57 -04:00
Rangi
d9603e3e33
Identify more unnamed labels
2020-10-04 22:34:50 -04:00
Rangi
306c85750e
Identify some more unnamed labels
2020-10-04 20:10:39 -04:00
mid-kid
13c4a93cea
Fix some constants surrounding sprite animations
...
Also commented the use of the field surrounding the struct
initialization functions.
SPRITEANIMSTRUCT_0C -> SPRITEANIMSTRUCT_VAR1
SPRITEANIMSTRUCT_0D -> SPRITEANIMSTRUCT_VAR2
SPRITEANIMSTRUCT_0E -> SPRITEANIMSTRUCT_VAR3
SPRITEANIMSTRUCT_0F -> SPRITEANIMSTRUCT_VAR4
BATTLEANIMSTRUCT_01 -> BATTLEANIMSTRUCT_OAMFLAGS
BATTLEANIMSTRUCT_ANON_JT_INDEX -> BATTLEANIMSTRUCT_JUMPTABLE_INDEX
BATTLEANIMSTRUCT_0F -> BATTLEANIMSTRUCT_VAR1
BATTLEANIMSTRUCT_10 -> BATTLEANIMSTRUCT_VAR2
2020-08-27 13:59:33 +02:00
Rangi
0b31d12dac
Merge pull request #756 from mid-kid/master
...
Rub a dub dub, thanks for the grub
2020-08-18 16:35:15 -04:00
Rangi
7729dcd204
Consistent constants for radio data table sizes (could still be better)
2020-08-13 13:47:50 -04:00
Rangi
ed3e70b97c
Identify some time-related data
2020-08-11 14:12:59 -04:00
mid-kid
b6055b1944
Use TRUE for hCGBPalUpdate
2020-08-05 16:02:48 +02:00
Rangi
35821ec58c
Correct constants in DoNPCTrade
2020-07-25 18:36:49 -04:00
Rangi
dd369f3199
Move EngineFlags and SpecialsPointers into data/engine/
2020-07-22 20:24:53 -04:00
Rangi
11dc805de0
Revert "Factor out tables into data/overworld/"
...
This reverts commit b5a7e7de3e
2020-07-22 20:21:26 -04:00
Rangi
b5a7e7de3e
Factor out tables into data/overworld/
...
Fixes #749
2020-07-22 15:22:58 -04:00
Rangi
59d9932255
SPRITE_GYM_GUY -> SPRITE_GYM_GUIDE
2020-07-17 13:01:48 -04:00
Rangi
ef452ccbc7
return → endcallback, reloadandreturn → reloadend
2020-07-17 08:37:03 -04:00
Rangi
43a9295789
add_tm, add_hm, and add_mt define TM##_MOVE, HM##_MOVE, and MT##_MOVE constants, to avoid repeating the move names in tmhm_moves.asm
2020-07-06 16:53:05 -04:00
Rangi
fce6243b43
Identify more labels, and use the jumptable macro when possible
2020-07-01 13:13:49 -04:00
Rangi
e171c84c29
Identify more labels and constants
2020-06-29 19:35:47 -04:00
Rangi
f2efda1f68
Identify more unnamed labels
2020-06-29 12:25:58 -04:00
Rangi
c3c18dd196
Comment more ROM labels as unreferenced
...
(Some unreferenced labels are above code which is still used via fallthrough!)
2020-06-21 18:33:31 -04:00
Rangi
91774f206e
Replace "Unreferenced" labels with "; unreferenced" comments
2020-06-21 16:27:43 -04:00
Rangi
98af69691d
Remove some more raw addresses
2020-06-21 12:21:47 -04:00
Rangi
cc460a17b0
Harmonize engine/{movie, pokemon} with pokegold (renames GetSRAMBank to OpenSRAM)
...
To do: engine/{menus, overworld}
2020-06-17 17:03:38 -04:00
Rangi
f2550fc3c2
ReplaceKrisSprite -> UpdatePlayerSprite
2020-06-16 19:38:00 -04:00
Rangi
f76dabedcc
Harmonize engine/{battle, battle_anims, events, games} with pokegold
2020-06-16 19:32:36 -04:00
Rangi
0d683ea0c7
Remove redundant tile graphics file, reuse others
2020-06-11 10:55:32 -04:00
Rangi
518cee440e
Resolve #723 : treat std scripts like specials and predefs
2020-06-10 16:44:16 -04:00
Rangi
5f197c53f4
Clean up some percentage values
2020-05-07 14:21:24 -04:00
Rangi
576cbf5b3e
Miscellaneous fixes, including one for the Pokédex design flaw by ax6
2020-04-18 17:31:51 -04:00
Rangi
22615cecc5
More miscellaneous fixes (see #709 )
2020-04-17 10:52:59 -04:00
Rangi
58b377f25b
Fix #709 miscellaneous issues
2020-04-16 09:30:50 -04:00
Rangi
3144b54bd1
Enable rgbds warnings and remove CFLAGS=-O2 (default is now -O3)
2020-04-06 12:41:07 -04:00
Rangi
0ef004a4db
dsprite y, ypx, x, xpx, off, attr -> dbsprite x, y, xpx, ypx, off, attr
2020-04-04 16:00:30 -04:00
Rangi
0345e4fb0e
Add suffixes to some constants to avoid ambiguity
...
- `PSYCHIC` → `PSYCHIC_TYPE` (not the trainer `PSYCHIC_T` or the move `PSYCHIC_M`)
- `BLACKBELT` → `BLACKBELT_I` (not the trainer `BLACKBELT_T`)
- `CURSE_T` → `CURSE_TYPE` (not the move `CURSE`)
- `TOWN_MAP_D` → `TOWN_MAP_POSTER` (not the item `TOWN_MAP`)
This also uncovered a misidentified event: `EVENT_DECO_PLANT_4` → `EVENT_DECO_POSTER_1`. (There are three plants and four posters.)
2020-03-21 17:59:26 -04:00
Rangi
6a6ba10315
rgbds supports 'X - 1' instead of 'X + -1'
2020-03-21 14:01:05 -04:00
Rangi
624864307e
Combine Celebi frames into one PNG
2020-03-16 08:58:28 -04:00
Rangi
ad50e94b50
Add a LANDMARK_ prefix to landmark constants
...
Resolves #697
2020-03-15 19:50:39 -04:00
Rangi
1d4c1aeef4
'and BANK' -> 'aka BANK'
2020-02-28 11:51:42 -05:00
Rangi
81eaf83cd7
Identify gfx/unknown/4985a.asm as gfx/tilesets/forest-tree/unused.png
2020-02-26 15:41:22 -05:00
Rangi
ee622d6ba1
Identify some labels and constants for Battle Tower
2020-02-25 18:13:50 -05:00
mid-kid
9a927c1b3e
Merge pull request #685 from mid-kid/master
...
Moshi moshi? minoru enhansumentsu desu
2020-02-21 21:11:36 +01:00
mid-kid
c22e268083
RTC -> UpdateTimeAndPals
...
Rename clear misnomer.
Most of the related functions in that file aren't really aptly named but
I don't know good names right now.
2020-02-21 18:21:29 +01:00
Rangi
88bbdb6a2f
Define TileCollisionTable as a standard 'db' series
2020-02-13 19:07:19 -05:00
mid-kid
26b8bf003e
Standardize on lowercase Tilemap and Attrmap
...
We used to have a mixture of TileMap and and Tilemap, as well as the
similar AttrMap. Standardize on one.
2020-02-13 18:31:10 +01:00
