151 Commits

Author SHA1 Message Date
xCrystal
98fa7a9538 Rename the concept of Coins to Chips () 2023-09-02 18:23:25 +02:00
Idain
8c6242a152 Fix macro definitiosn for unused commands 2023-05-06 20:12:45 -04:00
Colton G. Rushton
6a9e929bf9
Remove rNR20/rNR40 and add rPCM12/rPCM34 () 2022-06-17 22:29:09 -04:00
Daniel Harding
c3bf7fd0bd
Fix channel 3 wave 9 id () 2022-06-06 17:09:33 -04:00
vulcandth
fbcc8d1b0e
Correct ClearChannels comment ()
The comment states that ClearChannels doesn't seem to to be used. This is not the case, as it is used by ExchangeMysteryGiftData and ExchangeNameCardData.
2022-05-06 13:11:22 -04:00
vulcandth
d226ccab0a
Prune trailing whitespace () 2022-05-06 13:09:51 -04:00
Rangi
e706b878d9 Use ~X instead of $ff ^ X 2021-11-23 20:37:18 -05:00
Rangi
af4558f0df Comment that unused music bytes are left over from more channels 2021-04-12 14:51:00 -04:00
Rangi
bf688645b1 Rename SOUND_REST to SOUND_CRY
Fixes 
2021-04-12 14:48:05 -04:00
Rangi
2fe0cbbb19 Add some comments regarding 16-bit increment/decrement 2021-03-24 18:34:33 -04:00
Rangi
dbe2360ecd Miscellaneous cleanup 2021-03-22 16:41:17 -04:00
Rangi
3684296583 Revise some constant definitions 2021-03-16 18:06:18 -04:00
Rangi
d132a20b7a Verify script command table sizes 2021-03-11 16:28:52 -05:00
Rangi
40902ffe24 Verify data table sizes with table_width and assert_table_length macros
This was discussed in 

It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants, as discussed in 
2021-03-04 00:15:03 -05:00
Rangi
99e66c2557 Rename some labels
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"

Fixes 
2020-12-23 16:29:30 -05:00
aljohnston112
7b9d8767d4
Identified two magic numbers and cleaned up some comments ()
Improve the audio engine's comments and replace some magic numbers with constants
2020-12-07 12:44:16 -05:00
Rangi
ba5bc304f9 Updates to more closely sync with pokegold 2020-10-29 23:23:57 -04:00
Rangi
ea426a8879 Identify more WRAM labels, and start a <X>_DummyFunction label convention 2020-10-28 14:34:38 -04:00
Rangi
6d333bed5f Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:10 -04:00
Rangi
c85ba78b77 Use more assertions to ensure correct code and data 2020-10-26 22:24:38 -04:00
Rangi
9dcdad5e60 Comment, remove, or revise many unreferenced labels 2020-10-26 20:29:58 -04:00
Rangi
ff2d850219 Identify some more unnamed labels 2020-10-05 12:02:56 -04:00
mid-kid
aae59de91e Label some audio commands as unused 2020-08-03 22:56:49 +02:00
Rangi
6ca82e5c86 Eliminate enum: use const instead, with case-by-case parallel const implementations 2020-07-08 15:30:23 -04:00
Rangi
e171c84c29 Identify more labels and constants 2020-06-29 19:35:47 -04:00