pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2024-11-16 11:27:33 -08:00
Code Issues Packages Projects Releases Wiki Activity
4,312 Commits 1 Branch 0 Tags 52 MiB
8e359978d6
Commit Graph

4312 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rangi
98e670f363
Merge pull request #548 from Rangi42/master 
Add meaningful aliases for wd265
 2018-07-29 19:56:54 -04:00
Rangi
e346cc7b41 Every diff line starts with +, -, or space 2018-07-29 19:52:30 -04:00
Rangi
366330e981 Pokedex_PutScrollbarOAM data values 2018-07-29 16:15:06 -04:00
Rangi
1d96a79a37 No wCurMove alias for wCurSpecies 2018-07-29 16:04:38 -04:00
Rangi
b5a9e83a94 Fix reviewed issues. 
Pokedex_PrintListing has a comment noting how it depends on wCurSpecies == wNamedObjectIndexBuffer; an assert would be more convenient, but is not possible since WRAM label addresses are not defined yet here.
 2018-07-29 16:00:11 -04:00
Rangi
c9cb67141b Make reviewed fixes; standardize on " + " 2018-07-29 01:40:23 -04:00
Rangi
8498394701 wSwitchMon 2018-07-29 01:27:33 -04:00
Rangi
8aa08addba wLuckyNumberDigitsBuffer 2018-07-29 01:13:25 -04:00
Rangi
0c746447e7 Improve wTrainerHUDTiles usage 2018-07-29 01:09:12 -04:00
Rangi
5145d69506 ; entries correspond to PLAYEREVENT_* constants 2018-07-29 00:57:28 -04:00
Rangi
8935e6f1ca wDeciramBuffer → wBreedingCompatibility in UnknownText_0x1bd0d8 2018-07-29 00:48:03 -04:00
Rangi
20ffc8bd8b Reformat some bugfix diffs 2018-07-29 00:27:13 -04:00
Rangi
9dec80b07e Add meaningful aliases for wd265 
Introduce MONICON_* constants
Introduce BATTLEPLAYERACTION_* constants
 2018-07-29 00:25:52 -04:00
Rangi
2ec900d96c
Merge pull request #535 from ketsuban/fix-battle-transition 
Add fix for battle transition bug
 2018-07-28 19:11:57 -04:00
Rangi
a9bc3e4932
Merge pull request #547 from mid-kid/master 
anim_ret_command is an index in a table after all
 2018-07-28 19:11:24 -04:00
Thomas Winwood
533fdd8b4c Add fix for battle transition bug 2018-07-28 19:01:02 +01:00
mid-kid
595127ba65 anim_ret_command is an index in a table after all 
For some reason I thought BattleAnim_Ret was never used, due to how the
battle anim loop would be exited early from. It seems I was wrong.
Removing commands before anim_ret without it being part of the `enum`
seems to break things.
 2018-07-28 12:14:04 +02:00
Rangi
ee8479f05e
Merge pull request #546 from Rangi42/master 
Reword bug docs now that they use diffs
 2018-07-28 01:06:54 -04:00
Rangi
cdfdfed17b Crystal fixed TruncateHL_BC in single player 2018-07-27 21:32:14 -04:00
Rangi
a2f63043d4 Separate Beat Up bugs 2018-07-27 17:53:26 -04:00
Rangi
b58f82e12f Reword bug docs now that they use diffs 2018-07-27 13:11:30 -04:00
Rangi
54d507cf61 Merge branch 'master' of https://github.com/pret/pokecrystal 2018-07-27 12:07:10 -04:00
Rangi
7641ce9bab
Merge pull request #545 from mid-kid/master 
bugs_and_glitches fixes
 2018-07-27 12:06:46 -04:00
mid-kid
0aac0f9cfc "Explain" diff format in bugs_and_glitches 2018-07-27 11:25:29 +02:00
mid-kid
9aa6b55d7b Merge branch 'master' of https://github.com/pret/pokecrystal 2018-07-27 11:24:59 +02:00
yenatch
748d424980
Merge pull request #544 from Rangi42/master 
Various fixes found while writing tutorials
 2018-07-26 21:25:12 -04:00
mid-kid
a91b59ab5d Remove a documented bug that's not really a bug 
I mean, technically, being able to read beyond a data table's size is
bad practice, but there's so many cases of this that it's not worth
mentioning.

For most of these cases, at least, it's safe to assume the index won't
ever get high enough to surpass such a table's length, because it's
either hardcoded or decided by the game without the use of
uncontrollable data. As such, they don't expose any actual bugs.
 2018-07-26 23:34:05 +02:00
mid-kid
e43c89bc80 Consistently use the diff format in bugs_and_glitches 2018-07-26 23:34:03 +02:00
Rangi
b4906ff54d Merge branch 'master' of https://github.com/pret/pokecrystal 2018-07-26 16:23:12 -04:00
Rangi
60ffde3752
Merge pull request #489 from i0brendan0/i0brendan0-patch-5 
Add Fix for Lock-On Bug
 2018-07-26 16:20:52 -04:00
Rangi
dc1d0217a1
Merge pull request #522 from ketsuban/the-diffening 
Convert code samples to diffs
 2018-07-26 16:20:33 -04:00
Rangi
9a1ae1332c Correct NUM_STATS 2018-07-24 22:54:15 -04:00
Rangi
c2925d6406 db $0, $0 → dn 0, 0, 0, 0 ; DVs 2018-07-24 14:28:04 -04:00
Rangi
2b88951f9f MON_STAT_EXP - 1 → MON_EXP + 2 2018-07-24 14:14:04 -04:00
Rangi
d5b98f5206 wPokeAnimStruct matches wPokeAnimStructEnd 2018-07-23 00:37:48 -04:00
Rangi
4f0c9cecf9 StringCmp → CompareBytes; CompareLong → CompareBytesLong 
hStringCmpString[1/2] → h[EnemyMon/PartyMon1]Speed
 2018-07-23 00:25:53 -04:00
Rangi
a1806d6e81 Consistent routine naming convention: 'Foo' wraps '_Foo' 2018-07-23 00:13:43 -04:00
Rangi
bdde60c64b ANIM_MON_UNUSED → ANIM_MON_HOF 2018-07-22 23:42:50 -04:00
Rangi
5ba5a7df46
Merge pull request #543 from Rangi42/master 
Add tools/free_space.awk
 2018-07-22 23:38:09 -04:00
i0brendan0
8755a88458
turns out none of the code is needed 2018-07-21 05:05:40 -05:00
i0brendan0
6e62eabb42
final change 2018-07-21 03:36:03 -05:00
IIMarckus
8aebc7ba56 Merge branch 'master' of hyperdriveguy/pokecrystal 2018-07-21 00:41:56 -06:00
Thomas Winwood
23ef2f50a7
Merge branch 'master' into the-diffening 2018-07-21 02:06:31 +01:00
Hyperdriveguy
57fc81d44e Add Counter and Mirror Coat bugfix 2018-07-20 17:39:53 -07:00
yenatch
2d73d040d1
Merge pull request #542 from mid-kid/master 
Miscellaneous fixes
 2018-07-19 00:46:59 -04:00
mid-kid
1cb364cc18 Fix usage of NUM_UNOWN 2018-07-18 19:06:56 +02:00
mid-kid
db8830ba53 Label more mobile WRAM 
Memes and a pipedream of a fully-documented wram.
 2018-07-18 10:56:26 +02:00
mid-kid
ffa63c51df Clean up TX_ commands 
Some of the TX_ commands didn't use the TX_ prefix for their
constants, and the label names were inconsistent. I've chosen to adopt
the `TextCommand_` prefix as opposed to `Text_`, as it has a clear
difference in namespace compared to the possibly-used `Text_` namespace
for actual dialogue text.
 2018-07-18 10:55:30 +02:00
mid-kid
1fc7430a2b Fix misnamed character codes 
Some character codes were erroneously named after their text command
counterparts. This has caused a lot of confusion with naming their
functions and with other things.

I've also removed the `dict2` macro and expanded the `dict` macro. This
really isn't something we should be doing for macros but I can't deny it
looks a lot neater than repeated code.
 2018-07-18 10:55:30 +02:00
mid-kid
778d57ba21 Remove some more address comments 2018-07-18 10:55:30 +02:00