149 Commits

Author SHA1 Message Date
Colton G. Rushton
6a9e929bf9
Remove rNR20/rNR40 and add rPCM12/rPCM34 () 2022-06-17 22:29:09 -04:00
Daniel Harding
c3bf7fd0bd
Fix channel 3 wave 9 id () 2022-06-06 17:09:33 -04:00
vulcandth
fbcc8d1b0e
Correct ClearChannels comment ()
The comment states that ClearChannels doesn't seem to to be used. This is not the case, as it is used by ExchangeMysteryGiftData and ExchangeNameCardData.
2022-05-06 13:11:22 -04:00
vulcandth
d226ccab0a
Prune trailing whitespace () 2022-05-06 13:09:51 -04:00
Rangi
e706b878d9 Use ~X instead of $ff ^ X 2021-11-23 20:37:18 -05:00
Rangi
af4558f0df Comment that unused music bytes are left over from more channels 2021-04-12 14:51:00 -04:00
Rangi
bf688645b1 Rename SOUND_REST to SOUND_CRY
Fixes 
2021-04-12 14:48:05 -04:00
Rangi
2fe0cbbb19 Add some comments regarding 16-bit increment/decrement 2021-03-24 18:34:33 -04:00
Rangi
dbe2360ecd Miscellaneous cleanup 2021-03-22 16:41:17 -04:00
Rangi
3684296583 Revise some constant definitions 2021-03-16 18:06:18 -04:00
Rangi
d132a20b7a Verify script command table sizes 2021-03-11 16:28:52 -05:00
Rangi
40902ffe24 Verify data table sizes with table_width and assert_table_length macros
This was discussed in 

It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants, as discussed in 
2021-03-04 00:15:03 -05:00
Rangi
99e66c2557 Rename some labels
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"

Fixes 
2020-12-23 16:29:30 -05:00
aljohnston112
7b9d8767d4
Identified two magic numbers and cleaned up some comments ()
Improve the audio engine's comments and replace some magic numbers with constants
2020-12-07 12:44:16 -05:00
Rangi
ba5bc304f9 Updates to more closely sync with pokegold 2020-10-29 23:23:57 -04:00
Rangi
ea426a8879 Identify more WRAM labels, and start a <X>_DummyFunction label convention 2020-10-28 14:34:38 -04:00
Rangi
6d333bed5f Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:10 -04:00
Rangi
c85ba78b77 Use more assertions to ensure correct code and data 2020-10-26 22:24:38 -04:00
Rangi
9dcdad5e60 Comment, remove, or revise many unreferenced labels 2020-10-26 20:29:58 -04:00
Rangi
ff2d850219 Identify some more unnamed labels 2020-10-05 12:02:56 -04:00
mid-kid
aae59de91e Label some audio commands as unused 2020-08-03 22:56:49 +02:00
Rangi
6ca82e5c86 Eliminate enum: use const instead, with case-by-case parallel const implementations 2020-07-08 15:30:23 -04:00
Rangi
e171c84c29 Identify more labels and constants 2020-06-29 19:35:47 -04:00
Rangi
f2efda1f68 Identify more unnamed labels 2020-06-29 12:25:58 -04:00
Rangi
75035a71a5 Label some mobile addresses, and revise some comments 2020-06-13 18:48:26 -04:00
Rangi
8a3c44fad3 Add "unused" comments for stray audio/sfx.asm data 2020-04-23 16:33:00 -04:00
Rangi
b50dd57cbb Miscellaneous updates and corrections 2020-04-23 16:14:50 -04:00
Rangi
6a6ba10315 rgbds supports 'X - 1' instead of 'X + -1' 2020-03-21 14:01:05 -04:00
mid-kid
44b361c1bb Merge branch 'master' into audio-macros 2020-02-04 16:03:01 +01:00
dannye
e7be25948d Merge branch 'master' into audio-macros 2020-01-06 22:07:33 -06:00
Rangi
cf18b9458a Replace "branch" labels in music files with local names 2020-01-05 14:17:40 -05:00
mid-kid
739a60b33c Make the map setup commands match the actual function names better
These functions used as map setup commands are used in other places,
too, so I can't prefix them under the same. The names should match
except I won't repeat "map" in a map setup command name.
2019-11-18 18:21:57 +01:00
mid-kid
7111ae8e58 Fix some mobile script and map sign things 2019-10-21 00:42:36 +02:00
Ryan Tandy
3fc2ba41f7 Clarify naming of SFX_GET_EGG_* pointers
In game, one receives eggs from the Aide and the Day-care Man, not the
Day-care Lady. SFX `0x96` is used for both. Rename it to reflect it is
not unique to the Day-care.

SFX `0x95` is an alias of the same sound and appears to be unused.
Rename the pointer to clarify that.
2019-09-23 10:03:19 -07:00
dannye
5645e1e213 Remove excessive newline from ends of sound files 2019-09-08 11:57:55 -05:00
dannye
5fd3e591df Use TRUE/FALSE constants for stereo_panning
and use dn instead of db for volume envelope and pitch sweep
2019-09-03 22:55:51 -05:00
dannye
e058393487 Rename dnote to drum_note and dspeed to drum_speed 2019-09-03 22:36:32 -05:00
dannye
fc051f2130 Update audio macros and arguments
and update related labels/constants/comments
this fixes a lot of mistakes and maximizes compatibility with red
2019-09-02 03:41:25 -05:00
IIMarckus
9ddbaacea8 GlassTing (Elm's PC when email arrives) isn't in G/S either. 2019-08-16 01:09:32 -06:00
Rangi
45e3f6aca9 Identify some more WRAM labels 2019-04-19 11:35:27 -04:00
Rangi
4b4c53c7ae Format music macros like movement macros 2018-12-09 17:56:13 -05:00
mid-kid
725cee7371 Define first_music_cmd
This replaces the uses of $d0 in the audio engine with proper constants.
2018-11-21 12:12:22 +01:00
mid-kid
dac6916c8b Fix usage of endchannel_cmd 2018-11-20 21:46:00 +01:00
Rangi
eb1e3636bb Use labels instead of constants for HRAM
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 14:28:22 -04:00
Rangi
c9cb67141b Make reviewed fixes; standardize on " + " 2018-07-29 01:40:23 -04:00
mid-kid
fdf10c9fac Fix missing newline 2018-07-18 10:55:30 +02:00
Rangi
187e30cac8 Replace more hex values with constants or decimal 2018-07-11 15:40:09 -04:00
Rangi
1caa50a647 No space between labels and bodies 2018-06-25 12:24:18 -04:00
Rangi
9f3e9145f9 Remove more triple newlines 2018-06-25 12:01:02 -04:00
Rangi
67d1364c7a Fix triple newlines left over from removing address comments 2018-06-24 23:22:50 -04:00