pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2024-09-09 09:51:34 -07:00
Code Issues Packages Projects Releases Wiki Activity
3,923 Commits 1 Branch 0 Tags 52 MiB
436f4829b5
Commit Graph

865 Commits

Author SHA1 Message Date
Remy Oukaour
22b607b664 Move radio channel data into data/ 2018-01-10 11:30:12 -05:00
Remy Oukaour
16eb97ae9c Constant swap explains this Battle Tower bug 2018-01-10 02:55:44 -05:00
Remy Oukaour
7de7441e72 gfx/*.asm files have INCBINs 2018-01-10 02:38:45 -05:00
Remy Oukaour
ee4ec65fc1 map_objects.pal is easier to find in gfx/overworld/ than gfx/sprites/ 2018-01-10 02:30:17 -05:00
Remy Oukaour
9af6d8d0f1 Split tilesets/ into gfx/tilesets and data/tilesets/ 2018-01-09 23:53:58 -05:00
Remy Oukaour
5c5f8b325f Move data/palettes/ .pal files into gfx/ 2018-01-09 23:21:32 -05:00
Remy Oukaour
f22485b08d Binary tilemaps 2018-01-09 22:44:06 -05:00
Remy Oukaour
feb34b49ba data/phone_text → data/phone/text 2018-01-09 19:51:30 -05:00
Remy Oukaour
cc0fd6e12c CRYSTAL11 → _CRYSTAL11 2018-01-09 17:26:40 -05:00
Remy Oukaour
a8cf8979d9 Do a little cleanup towards issue #465 2018-01-09 17:20:47 -05:00
Remy Oukaour
ce50d1b2cb Clearer Battle Tower code 2018-01-09 16:55:11 -05:00
Remy Oukaour
11556196ba Consistent sine wave code formatting 2018-01-09 16:39:36 -05:00
Remy Oukaour
a849c3557b More comments 
Fix some constants
 2018-01-09 15:39:48 -05:00
Remy Oukaour
5a73a62d9b Move battle engine data into data/ 
IsJohtoGymLeader → IsGymLeader
 2018-01-09 15:12:49 -05:00
Remy Oukaour
2f741dfa03 Remove old Python class names from script command param doc comments 2018-01-09 01:02:29 -05:00
Remy Oukaour
05e5eaf12f Eliminate version.asm (resolves #464) 2018-01-09 00:51:53 -05:00
Remy Oukaour
459d5d3164 default_names.asm → player_names.asm 2018-01-09 00:45:03 -05:00
Remy Oukaour
d0a8e8e744 includes.asm → constants.asm 2018-01-09 00:36:15 -05:00
Remy Oukaour
31edd7f803 Move text/ into data/ 2018-01-09 00:23:48 -05:00
Adelaide Walter
6c5cd7a963 Simplify comments per Rangi's rec. 2018-01-08 23:07:46 -05:00
Adelaide Walter
94f32db7bc Document hardcoded SRAM addresses. 2018-01-08 22:48:58 -05:00
Adelaide Walter
d6f20ae746 Use BANK for hardcoded SRAM banks (except for vestigial refs to JP's banks 4-7) 2018-01-08 17:13:37 -05:00
xCrystal
2c789b64b1 Predef_FlagAction -> Predef_SmallFarFlagAction 2018-01-07 11:53:20 +01:00
Remy Oukaour
bdd3a55333 Organize mobile/battle_tower_*.asm data and code 2018-01-06 18:53:30 -05:00
xCrystal
e9e8bf6eb1 Predef_Flag -> Predef_FlagAction 2018-01-05 11:05:01 +01:00
Adelaide Walter
ce985a09a7 Document switches to BANK(sScratch) via xor a 2018-01-04 16:51:50 -05:00
Adelaide Walter
36e91c971c Fix stray hardcoded WRAM bank. 2018-01-04 15:06:11 -05:00
Adelaide Walter
fb422e8d9c Use BANK for hardcoded WRAM banks preceding FarCopyWRAM/GetFarWRAMByte calls. 2018-01-04 14:53:50 -05:00
Adelaide Walter
5fd3bfa832 Clarify the purpose of writing 0 to rSVBK. 2018-01-03 20:47:44 -05:00
Adelaide Walter
9d0ba6bfd3 Use BANK for hardcoded WRAM banks (except where bankswitches appear unnecessary). 2018-01-03 19:12:45 -05:00
xCrystal
91f97f08f0 Special_MapCallbackSprites_LoadUsedSpritesGFX -> Special_LoadUsedSpritesGFX 2018-01-03 14:58:08 +01:00
Remy Oukaour
10bd011d06 More relevant data file locations 2018-01-03 02:23:54 -05:00
Adelaide Walter
cd8a22cd2e Replace magic reference to PackMenuGFX. 2018-01-03 01:29:52 -05:00
Remy Oukaour
8d095cd5b8 Better names 2018-01-03 01:27:12 -05:00
Adelaide Walter
76ee2f58c4 WRAM1_Begin -> wd000 2018-01-03 00:40:59 -05:00
Adelaide Walter
51106cccd0 Scrub WRAM addresses from comments & use WRAM1_Begin where appropriate. 2018-01-03 00:19:54 -05:00
Remy Oukaour
3fc06b0f9d Use constants 2018-01-02 20:35:57 -05:00
Remy Oukaour
a7fb9e124c Use dsprite for Pokédex cursor OAM data 2018-01-02 18:02:22 -05:00
Remy Oukaour
4f01dff6c2 Use OAM flags in dsprite data 2018-01-02 17:26:23 -05:00
Adelaide Walter
0caea0f820 Use BANK for all hardcoded banks with BANK in comments. 2018-01-02 16:46:40 -05:00
Remy Oukaour
648e71832a Comment correction 2018-01-02 14:50:04 -05:00
Remy Oukaour
776b8c7396 Egg hatch shell framgent data is not exactly dsprite 2018-01-02 14:48:24 -05:00
Remy Oukaour
2dd9ac08a4 More sprite anim documentation 2018-01-02 14:39:24 -05:00
Remy Oukaour
7ad8ea13c9 Document more sprite anim data 2018-01-02 14:25:58 -05:00
xCrystal
aa9a0a900d No more mobile EQUS ret (replace with Stubbed_ + ret) 2018-01-02 20:00:14 +01:00
xCrystal
b4e087167f More unreferenced labels and unused text 2018-01-02 19:38:56 +01:00
xCrystal
d7970f749a Consistent predef function names 2018-01-02 18:49:25 +01:00
Remy Oukaour
be2aeedcf0 More clarification 2018-01-02 11:53:06 -05:00
Remy Oukaour
d435bd8911 Reword Magikarp length comments 2018-01-02 11:50:08 -05:00
xCrystal
b4a49351c1 Finish consistent Special function names 2018-01-02 17:47:58 +01:00
xCrystal
f1ea15bbfe Consolidate Special function names 2018-01-02 17:13:57 +01:00
xCrystal
7c0e903c48 Clean up leftover code from main.asm 2018-01-02 16:25:40 +01:00
xCrystal
6f0b81504d More unreferenced labels cleanup 2018-01-02 16:04:21 +01:00
xCrystal
7a24703398 Clean up Predef function names 2018-01-02 15:05:14 +01:00
xCrystal
9a3088e50c Clean up XXX comments for unused content 2018-01-02 13:26:18 +01:00
Remy Oukaour
3c953efcba Consistent *_palette_map.asm 2018-01-01 18:33:42 -05:00
Remy Oukaour
0722de77ae Remove trailing whitespace 
find . -name '*.asm' -exec sed -i 's/[ \t]\+$//' {} \;
 2018-01-01 18:32:01 -05:00
xCrystal
a98ed77c83 Merge 2d0ed11 and 355acfc from Roukaour/master 2018-01-01 20:25:07 +01:00
xCrystal
37369d1ae0 Rename Pals labels in WRAM bank 5 2018-01-01 20:09:53 +01:00
xCrystal
6e12a51503 Use more palette(s) constants 2018-01-01 20:09:53 +01:00
Remy Oukaour
2d0ed1159e Use constants for rBGPI+rOBPI auto-increment 
Fix some documentation
 2018-01-01 13:43:02 -05:00
yenatch
8c3905c4cd
Merge pull request #451 from yenatch/document-battle-anim-macros 
Fix and document some battle animation macros
 2018-01-01 12:47:28 -05:00
yenatch
927e87eda5 AnimateEndOfExpBar palette constant 2018-01-01 04:40:30 -05:00
yenatch
92fba8821c
Merge pull request #450 from roukaour/master 
Constants for TextBoxFlags
 2017-12-30 21:32:45 -05:00
Remy Oukaour
b40181db41 Use input constants 2017-12-30 12:35:50 -05:00
Remy Oukaour
f01434f2c0 bgrows → * BG_MAP_WIDTH 
No dims macro
 2017-12-29 18:59:50 -05:00
xCrystal
2a7ba6685a Clean up changes in 3c6c80f 2017-12-29 19:22:33 +01:00
xCrystal
3c6c80f1b2 LY_BLANK and rLCDC constants 2017-12-29 18:53:21 +01:00
xCrystal
6464d077ee slot_reel offset constants 2017-12-29 16:48:47 +01:00
xCrystal
ee5bf71640 Consistently name unknown fields in macros/wram as Fieldxx 2017-12-29 16:19:51 +01:00
xCrystal
def3b60493 Clean up .Jumptable: spaces 2017-12-29 13:52:42 +01:00
Remy Oukaour
b9a68fec25 Consistent if/else/endc (matches rept/endr) and DEF (matches BANK/HIGH/LOW) 2017-12-28 22:13:39 -05:00
Remy Oukaour
4c35f3ac85 Merge branch 'master' of https://github.com/pret/pokecrystal 
# Conflicts:
#	macros/scripts/maps.asm
 2017-12-28 20:56:21 -05:00
xCrystal
50fc9c3389 endm -> ENDM 2017-12-28 22:31:16 +01:00
Remy Oukaour
bb005694b3 Avoid unused labels 2017-12-28 14:42:56 -05:00
Remy Oukaour
84e22eb578 Consistent (x, y) coordinate formatting in map scripts 2017-12-28 14:31:25 -05:00
xCrystal
43a1e5b5ba Fix accidentally renamed constant 2017-12-28 20:27:44 +01:00
xCrystal
bd783370f8 Consistent function name prefixes in slot machine code 2017-12-28 20:23:17 +01:00
xCrystal
83ef3b9a36 Suggest fixes to untranslated magikarp length filters 2017-12-28 20:03:27 +01:00
xCrystal
d6507e3882 More constants and documentation in slot machines 2017-12-28 19:38:15 +01:00
Remy Oukaour
fe92e4d848 Document design flaws 2017-12-28 11:28:23 -05:00
Remy Oukaour
b373984ab9 Rename pokemon animation files (fix #439) 2017-12-28 11:05:42 -05:00
xCrystal
731311cb15 Update Magikarp length documentation 2017-12-28 16:42:57 +01:00
xCrystal
333524f0be Lowercase v for VRAM addresses 2017-12-28 13:32:33 +01:00
xCrystal
7beb497d3a Uppercase MACRO and EQU(S) according to the style guide 2017-12-28 13:23:44 +01:00
xCrystal
9457679af8 Prefix engine_flags wram addresses with w 2017-12-28 13:15:46 +01:00
Remy Oukaour
2c4777f336 05:OBPals+6*8 == 01:wCurMessageScrollPosition (new) 2017-12-28 00:56:45 -05:00
Remy Oukaour
2ae2ce4fde Use constant 2017-12-27 20:43:56 -05:00
Remy Oukaour
e3e64fdf59 Move more decoration data to data/ 2017-12-27 11:56:03 -05:00
Remy Oukaour
e614dd1278 gfx/pokemon/animation.asm → engine/pic_animation.asm 
Correct comment in constants/pokemon_constants.asm
 2017-12-27 01:58:36 -05:00
Remy Oukaour
7a4d641251 Remove redundant data/ filename prefixes 2017-12-27 01:29:15 -05:00
Remy Oukaour
86fd37af16 Move events/ to engine/events/ 2017-12-27 00:09:12 -05:00
Remy Oukaour
47e4f21e62 Keep memory map values in hardware_constants.asm 2017-12-26 23:18:05 -05:00
Remy Oukaour
5d229dcef2 Copy sram.asm's global start/end constants for wram.asm and vram.asm 2017-12-26 23:07:46 -05:00
Remy Oukaour
172dba3c0b Rename some sections 
engine/battle_tower.asm fits better in events/
 2017-12-26 22:57:19 -05:00
Remy Oukaour
dae16acd6f event/ → events/, and move some appropriate engine/ files there 2017-12-26 21:55:57 -05:00
Remy Oukaour
b3f0e11567 Various cleanup 2017-12-26 20:33:41 -05:00
Remy Oukaour
8259136911 Name mail graphics 2017-12-26 20:02:00 -05:00
Remy Oukaour
9bc680bd6d Battle animation data is like sprite animation data 2017-12-26 19:27:56 -05:00
Remy Oukaour
35a3a19fda Use "battle_anims" and "sprite_anims" for clarity, not just "anims" 2017-12-26 18:45:04 -05:00
Remy Oukaour
b5417fafec Split battle/ into data/ and engine/ components 2017-12-26 17:47:05 -05:00
Remy Oukaour
38b84c5b11 Remove unused label (last few commits resolve #434) 2017-12-26 13:00:23 -05:00
Remy Oukaour
4d18bb2eda Rename: gfx/pics → gfx/pokemon 2017-12-26 12:55:02 -05:00
Remy Oukaour
24f0e7d045 Rename: emote_headers, sprite_headers, cry_headers, gfx_headers, tileset_headers 2017-12-26 12:50:32 -05:00
Remy Oukaour
17f45b5c95 MAX_LEVEL = 255 should still compile 2017-12-25 15:46:24 -05:00
Remy Oukaour
e34e68095d Resolve #428: Use HIGH(X) and LOW(X) instead of X / $100 and X % $100 or X >> 8 and X & $ff 2017-12-25 14:23:16 -05:00
Remy Oukaour
da2b01a36c Clean up color/palette code 2017-12-25 12:41:31 -05:00
Remy Oukaour
c6b12b07b3 Group Pokérus files in engine/pokerus/ 2017-12-24 20:11:03 -05:00
Remy Oukaour
aeee49d29b Change a few Unknown labels 2017-12-24 20:07:23 -05:00
Remy Oukaour
148fd299f9 Add more constants for some maximum values 2017-12-24 19:49:57 -05:00
Remy Oukaour
7d4486e6a3 Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) 
engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
 2017-12-24 19:35:35 -05:00
Remy Oukaour
040aa7cb17 LoadEDTile → CopyTilemapAtOnce (fix #345) 2017-12-24 18:11:17 -05:00
Remy Oukaour
0a1fef45fd Rename maps: 
- Underground -> UndergroundPath
- Route5UndergroundEntrance -> Route5UndergroundPathEntrance
- Route6UndergroundEntrance -> Route6UndergroundPathEntrance

- WarehouseEntrance -> GoldenrodUnderground
- UndergroundWarehouse -> GoldenrodUndergroundWarehouse
- UndergroundPathSwitchRoomEntrances -> GoldenrodUndergroundSwitchRoomEntrances
 2017-12-24 18:06:12 -05:00
Remy Oukaour
b805d343f3 Merge branch 'master' of https://github.com/pret/pokecrystal 2017-12-24 17:30:29 -05:00
Remy Oukaour
9973e43d5a Fix issue #345: 
- GetMonFrontpic → GetEnemyMonFrontpic
- GetMonBackpic → GetBattleMonBackpic
- FrontpicPredef → GetAnimatedFrontpicPredef
- GetFrontpic → GetMonFrontpic
- GetBackpic → GetMonBackpic
- CutAndPasteMap → PadMapForHDMATransfer
 2017-12-24 15:03:20 -05:00
Remy Oukaour
c05b7f41dd Renaming: (fix #412) 
- MapTriggers / maptrigger → SceneScripts / scene_script
- XYTriggers / xy_trigger → CoordEvents / coord_event
- Signposts / signpost → BGEvents / bg_event
- PersonEvents / person_event → ObjectEvents / object_event
 2017-12-24 14:33:17 -05:00
Remy Oukaour
20d6c1d876 Rename "map permissions" to "map environment" (fix #396) 2017-12-24 13:08:38 -05:00
Remy Oukaour
c66d195089 callba/callab → farcall/callfar 2017-12-24 12:47:30 -05:00
mid-kid
cbec3771e2 Misc fixes for the usage of constants 
Several improvements that will make it easier to edit some data
structures for everyone.
 2017-12-24 14:42:13 +01:00
yenatch
c51968f0de Merge remote-tracking branch 'origin/master' into master 2017-12-23 17:14:09 -05:00
Remy Oukaour
1d2df3bba1 Some more WRAM cleanup 2017-12-23 11:34:55 -05:00
Remy Oukaour
ff4d25eee3 Include bugfix in comments 2017-12-21 12:11:35 -05:00
Remy Oukaour
02609940db Document one more bug 2017-12-21 11:43:41 -05:00
Remy Oukaour
2fa1e97aeb Document two more bugs 2017-12-19 19:04:56 -05:00
Remy Oukaour
25a3960646 Move some more main.asm routines into individual files 2017-12-16 19:00:50 -05:00
Remy Oukaour
05d49f7d75 Move more code out of main.asm 2017-12-16 12:49:43 -05:00
Remy Oukaour
bd6dc94da0 Move tileset-specific palette code into tilesets/ 2017-12-16 00:52:16 -05:00
Remy Oukaour
fbf931f5d3 Ad some more constants for meaningful audio WRAM bits 2017-12-16 00:50:03 -05:00
Remy Oukaour
cbde91d7ed Only engine/decorations.asm uses PadCoords_de 2017-12-15 23:59:24 -05:00
Remy Oukaour
5aac8afae7 PLAYER_SLIP → PLAYER_SKATE (probably used for the beta skateboard; DoPlayerMovement.BikeCheck returns true for it) 2017-12-15 23:29:42 -05:00
surskitty
c883ab4d34 Reorganising phone stuff. 2017-12-15 23:06:53 -05:00
Remy Oukaour
fa98c29fa4 Add more palettes to data/palettes/ 2017-12-15 22:36:33 -05:00
Remy Oukaour
e44640b008 Move more main.asm code into individual files 2017-12-15 21:22:26 -05:00
Remy Oukaour
1038ebca5e Move more contiguous related code blocks from main.asm to engine/ and events/ 2017-12-15 20:10:54 -05:00
surskitty
cb5aa29228 Labelling the remaining stuff one sed at a time. 2017-12-15 18:16:27 -05:00
Remy Oukaour
2cf5cc1dc7 Move more unknown graphics into real subfolders 2017-12-15 17:50:45 -05:00
Remy Oukaour
59fe407812 Copy pokered's organization some more, with further constant and data files 2017-12-15 17:22:52 -05:00
Remy Oukaour
ebf3bfb6b2 Move some misc/ files into meaningful directories 2017-12-15 12:53:33 -05:00
Remy Oukaour
94722aa8f0 Move predef/ files into engine/ 
Get rid of single-file engine/ subdirectories
Move tilesets/ palettes unrelated to individual tilesets into data/palettes/ (more from engine/colors.asm can be moved here too)
 2017-12-15 12:31:18 -05:00
Remy Oukaour
6ab1d028bb Split items/ and trainers/ into their data/ and engine/ components 
Move some data into a pokemon/ subdirectory
 2017-12-14 23:00:54 -05:00
surskitty
75c56e86c4 The labelling never ends, but phone_scripts.asm does. 2017-12-14 21:19:46 -05:00
surskitty
955a0c9dd3 Another batch. 2017-12-14 15:39:46 -05:00
surskitty
f905a2353e One day we'll be through with this. Labels. 2017-12-14 15:25:46 -05:00
surskitty
62dd7a8bae phone_scripts is most of the way there, too. 2017-12-14 14:48:39 -05:00
surskitty
e1413e022d phone_callers.asm is now fully readable, if not fully labelled. 2017-12-14 14:13:10 -05:00
Remy Oukaour
e48a401290 Reorganize macros 2017-12-14 00:36:24 -05:00
surskitty
1116180e3c Renaming RandomPhoneRareWildMon to RandomRareWildMon. 2017-12-13 23:39:47 -05:00
surskitty
8e54adc22f Labels, including a comment explaining RandomPhoneRareWildMon. 2017-12-13 23:35:07 -05:00
surskitty
1f0fbfb602 Label label label. 2017-12-13 22:54:29 -05:00
surskitty
d69d81f3a0 Fix the spelling of Thursday 2017-12-13 22:41:15 -05:00
surskitty
a5c0461192 Labels labels labels 2017-12-13 22:40:11 -05:00
surskitty
771c4a7e05 Splitting phone scripts up. 2017-12-13 22:30:37 -05:00
surskitty
8fa7183d29 More phone script labelling. 2017-12-13 21:50:32 -05:00
surskitty
2b72d949b2 Another batch of labels. Jack's move trivia, mostly. 2017-12-13 21:12:42 -05:00
surskitty
cb1c6967ed Some more phone labels. 2017-12-13 20:49:10 -05:00
surskitty
4b36a9d2e1 Merge branch 'master' of github.com:pret/pokecrystal 2017-12-13 19:55:03 -05:00
surskitty
e3ee39f334 Labelling the bragging phone calls. 2017-12-13 19:54:28 -05:00
Remy Oukaour
76ea57688e Add table of contents (might remove if it's too cumbersome to maintain) 2017-12-13 00:28:48 -05:00
yenatch
725750d69d use an xor instead of the result 2017-12-12 23:45:32 -05:00
Remy Oukaour
10eb426e40 Document more bugs 2017-12-12 22:58:20 -05:00
Remy Oukaour
ad620243d9 Fix make compare 2017-12-12 20:21:08 -05:00
Remy Oukaour
78d489733c Merge branch 'master' of https://github.com/pret/pokecrystal 2017-12-12 20:15:15 -05:00
Remy Oukaour
93c32e3580 Document bugs and glitches 2017-12-12 20:15:07 -05:00
Remy Oukaour
b006415371 Define constants for collision types 2017-12-12 16:15:58 -05:00
Remy Oukaour
5b13a7a13b Identify more sprite-related constants 
Start more documentation
 2017-12-12 13:22:19 -05:00
Remy Oukaour
c5675927fe Identify more sprite-related constants 2017-12-12 12:18:11 -05:00
Remy Oukaour
48e40a7f09 Identify some SPRITE_ANIM_FRAME_IDX_* constants 2017-12-12 02:31:14 -05:00
Remy Oukaour
213dcc70d7 More consistent data tables 2017-12-11 22:59:30 -05:00
Remy Oukaour
f1f84743f7 Keep table labels in the same files as their contents. 2017-12-11 22:44:25 -05:00
Remy Oukaour
dc4357b7fa "Pic Pointers" and "Unown Pic Pointers" must start at the same address 
Use `|` not `+` to combine bitmasks
 2017-12-11 18:39:39 -05:00
Remy Oukaour
2d644f5077 Name some gfx/unknown/ files 2017-12-11 18:04:23 -05:00
Remy Oukaour
e6f6a75330 Move the rest of gfx/misc/ into specific directories 2017-12-11 17:51:04 -05:00
Remy Oukaour
4afc2f01ef Add member constants for the base data struct, same as most other structs 2017-12-11 17:35:35 -05:00
Remy Oukaour
5be98bae3c Move more data tables into data/ files. 2017-12-11 15:20:32 -05:00
Remy Oukaour
31cce83e9b Move lots of data tables into individual data/ files 
(This is not expected to be their final location, but it makes them easier to relocate when necessary, and easier for users to edit until the whole project's file structure is finalized.)
 2017-12-11 14:23:18 -05:00
Remy Oukaour
c2ad79c4f2 Add constants for time-of-day boundaries 
Split off more misc constants into proper files
 2017-12-11 12:20:01 -05:00
Remy Oukaour
41acb0667a Document macros/map.asm 
Rename MORN/DAY/NITE to MORN_F/DAY_F/NITE_F; use MORN/DAY/NITE for shifted values (cleaner for person_events)
Prefix FLOOR to the `elevfloor` constants
 2017-12-11 01:02:28 -05:00
Remy Oukaour
c6fefd0fe8 Rename overworld sprite files, consistent with their constants 2017-12-11 00:17:39 -05:00
Remy Oukaour
a551e345df PokeCenter → Pokecenter (consistent with the POKECENTER map constants) 2017-12-10 22:34:42 -05:00
Remy Oukaour
b4261d27d8 Use new palette constants 2017-12-10 20:50:08 -05:00
Remy Oukaour
699495bfcb Consistent capitalization for map names, matching their constants 2017-12-10 13:37:15 -05:00
Remy Oukaour
d554b997c5 Use correct WRAM labels for intro/title scenes 
Remove outdated WRAM alias comments
 2017-12-10 00:18:29 -05:00
Remy Oukaour
ab7025a144 Consistent code formatting: no redundant as and spaces after commas 2017-12-10 00:06:20 -05:00
Remy Oukaour
32ea595c47 Move some gfx/unknown/ files into meaningful directories 2017-12-09 23:37:08 -05:00
Remy Oukaour
31901f73b0 Move some gfx/misc/ files into meaningful directories 2017-12-09 22:57:41 -05:00
Remy Oukaour
59ee673775 Consistent pointer labels in WRAM 2017-12-09 22:24:43 -05:00
Remy Oukaour
cd2a748128 More WRAM cleanup 2017-12-09 22:00:36 -05:00
Remy Oukaour
880fb511e1 More WRAM organization 2017-12-09 15:28:03 -05:00
Remy Oukaour
e3c686f6df Further WRAM organization 2017-12-09 15:14:51 -05:00
Remy Oukaour
5a5df2ab87 More WRAM organization 2017-12-09 14:47:32 -05:00
Remy Oukaour
16c6696dd5 Start organizing WRAM 
- Use db and dw when they're more meaningful than ds 1/2
- Use unions to group related labels
 2017-12-09 13:58:49 -05:00
Remy Oukaour
6a41d4f63e Define more charmap characters and use them in place of hard-coded numbers 2017-12-09 12:57:23 -05:00
Remy Oukaour
512863989f Document constants with comments, actual names, and more thorough usage 2017-12-09 02:15:46 -05:00
mid-kid
a1fc73603e Label all of PARTYMENUACTION_* 
It's pretty clear what it's used for.
PartyMenuActionText is used for two things:
1) Storing what kind of action we're going to do (<$10)
2) Storing the text for some kind of healing stuff I'm not entirely sure (>=$f0)

In the former case, if GetPartyMenuTilemapPointers is ran, it will be
used to pick a sequence of actions that should be done, specified in the
table, and it'll print the corresponding string using the
PartyMenuStrings table. The items in the sequence of actions that should
be done are in WritePartyMenuTilemap.

Strangely enough, one possible value is left completely unused:
PARTYMENUACTION_GIVE_MON_FEMALE. It works in the exact same way as it's
male counterpart, and as such I don't believe it was used in the
japanese version either, since it doesn't matter which gender your 'mon
is when you put 'em in the daycare.
 2017-11-30 20:35:58 +01:00
mid-kid
2cc2f057e8 Fix some SPRITE_ANIM_FRAMESET_ constants 
Thanks to @roukaour for the fixes.
 2017-11-29 20:24:19 +01:00
mid-kid
09d9f2c1ef Add MobileError-related labels 
This function is called from a few different places in the mobile code,
including from one special that is only executed when the
BattleTowerRoomMenu special returns with a non-zero code.

Since that special causes a blue "error" screen to appear, that looks
the exact same as the one you'd get when trying to connect from the
mobile trade corner/battle colosseum in a Pokémon Center's top floor,
and this function contains a bunch of japanese strings in a jumptable, I
think it's reasonable to assume it should be called
"DisplayMobileError".
 2017-11-26 11:35:13 +01:00
mid-kid
afc92eadc1 Label BattleTowerRoomMenu 
All of the functions called by it are prefixed with BattleTowerRoomMenu,
but a bunch of them seem more generic than that, since they're part of
different mobile menus. Also called another menu jumptable
BattleTowerRoomMenu2 for the lack of a better name (only the Yes/No menu
functions are used in western crystal).
The names of the more generic functions should be fixed when we start
labelling other menus.
 2017-11-25 17:03:20 +01:00
Marcus Huderle
c28be02a19
Merge pull request #395 from surskitty/master 
Some Script Labels
 2017-11-21 17:18:29 -08:00
mid-kid
e21551db62 CeruleanCaveNane -> CeruleanCaveName 2017-11-16 18:19:33 +01:00
pfero
999c804f6f Label some functions in gfx/load_pics.asm 
A few projects I looked around in used these same labels for these
functions, and it looks like they describe these functions properly.
Also fixed usage of BANK() in a few places.
 2017-11-03 01:12:16 +01:00
pfero
88f1b8165b Define GetWarpSFX 
This function checks the current tile at the player's feet, and returns
an appropriate SFX that should be played when warping from it.
 2017-10-29 11:14:59 +01:00
pfero
7c9a156133 Fix WATERTILE/WALLTILE constants 
WATRTILE was wrongly defined as 15, and WALLTILE as 1. Those had to be
flipped around.
This has allowed for us to replace inmediate values with these constants
in several places to improve readability.

WATRTILE was renamed to WATERTILE in the name of readability.
 2017-10-28 18:08:24 -04:00
surskitty
6cdc14b920 Labelling a few mom scripts. 2017-10-25 00:34:32 -04:00
yenatch
17448c51a5 Merge pull request #389 from yenatch/rgbds-3 
rgbds 0.3.3
 2017-09-24 01:23:34 -04:00
PikalaxALT
0e470bc785 Fix section linking 
Create linker script and float all sections
 2017-09-23 23:04:10 -04:00
i0brendan0
0e33fd74f1 Fix unused Constant for Happiness 
The HAPPINESS_TO_EVOLVE constant is what's supposed to be used to give the number for when a Pokemon should evolve by happiness. The constant was not put in place so it is never used, instead the original 220 was put.
 2017-08-24 17:29:56 -05:00
yenatch
080704e49f Merge pull request #370 from yenatch/graphics 
png everywhere
 2017-06-24 17:36:21 -04:00
yenatch
a20664d415 Fix gfx/misc 2017-06-24 16:30:12 -04:00
yenatch
803c5154f4 pngs in gfx/unknown 2017-06-24 16:27:52 -04:00
yenatch
647f9b4452 pngs in gfx/title 2017-06-21 23:45:01 -04:00
yenatch
5738567985 pngs in gfx/splash 2017-06-21 00:13:09 -04:00
yenatch
99f6249de8 pngs in gfx/pokegear 
- flymap_label_border.2bpp was actually 1bpp
 2017-06-21 00:11:29 -04:00
Ben10do
e6ea1889fb
Replace ‘jp [hl]’ with ‘jp hl’ 
The former is arguably misleading (as you don’t access the memory location in hl to retrieve the jump location), and is consequently deprecated in newer versions of rgbds.

This fix silences these deprecation warnings.
 2017-06-09 22:01:10 +01:00
yenatch
74005945b7 Fix no newline at eof in engine/time.asm 2017-05-28 15:54:03 -04:00
Ben10do
288902139f Revert "Fix floating sections" 
This reverts commit e28b88f56d.
 2017-03-24 11:51:03 +00:00
AntonioND
e28b88f56d Fix floating sections 
This is needed so that rgblink doesn't move them around after modifying
it's placement algorithm.

Signed-off-by: AntonioND <antonio_nd@outlook.com>
 2017-03-15 00:52:26 +00:00
IIMarckus
a722f936a9 Strip address comments. 2017-02-22 21:49:44 -07:00
hatschky
f0209d6ed6 Labels for Trainer Rankings stat tracking functions 2017-01-16 21:11:34 +00:00
YamaArashi
65c38930a3 Merge branch 'master' of https://github.com/PikalaxALT/pokecrystal into PikalaxALT-master 2016-12-30 17:21:02 -08:00
Fredrik Ljungdahl
b439a7259f Fix an incorrect comment regarding breeding 
If Defense DV match and lower 3 DVs match father+mother, breeding
chance isn't maximized, but prevented. Possibly done to combat
in-breeding
 2016-10-29 01:52:13 +02:00
PikalaxALT
8f2d68a9e6 Person action and facing labels, part 2 2016-09-27 10:10:13 -04:00
PikalaxALT
ef98c44edd Person action and facing labels, part 1 2016-09-27 09:37:10 -04:00
PikalaxALT
d84ebd2124 pitchoffset macro to replace forceoctave 2016-07-29 10:40:54 -04:00
Scott Norton
a32b6ccbb5 These are actually .1bpp files 2016-06-25 20:19:52 -04:00
pikalaxalt
4e2487c056 hLCDCPointer and InitList 2016-06-13 22:53:33 -04:00
pikalaxalt
ca01a92880 Fix indentation in many places 2016-06-07 08:13:08 -04:00
pikalaxalt
b0e7d04ccf Some mystery gift functions 2016-06-07 08:08:51 -04:00
pikalaxalt
d7a01e92e9 Remaining layout constants 2016-06-06 18:23:00 -04:00
pikalaxalt
98f443f70c engine/events.asm labels finished 
fixed palred/green/blue macros
 2016-05-17 08:40:56 -04:00
pikalaxalt
2eeb78d1bc Evolution addresses 2016-05-16 15:46:13 -04:00
pikalaxalt
12396874cf HP bar animation addresses and AI switch 2016-05-16 09:36:24 -04:00
pikalaxalt
87b733994b SPRITE_ANIM_FRAME_IDX constants 2016-05-15 22:00:17 -04:00
pikalaxalt
1fa6aecbfc Unify directional movement macros 2016-05-14 13:46:14 -04:00
pikalaxalt
3108c9fa6a Unify step_sleep macro 2016-05-14 12:28:00 -04:00
pikalaxalt
1a84ca4e55 EZChat cursor object 2016-05-14 01:11:01 -04:00
pikalaxalt
c72912337e Refine labels in engine/trade/animation.asm 2016-05-13 23:23:26 -04:00
pikalaxalt
5ea3a953c3 Name all link trade animation related functions 2016-05-13 22:46:32 -04:00
pikalaxalt
1be6923c06 Inexplicably empty function with malformed predef pointer, but what are you gonna do about it? 2016-05-11 21:24:14 -04:00
pikalaxalt
6a3b3e3773 Save functions; feeble attempt at serial and link functions 2016-05-11 21:19:52 -04:00
pikalaxalt
af0119ca7e Name all printer functions 2016-05-11 17:16:03 -04:00
pikalaxalt
295604cbb5 Placeholder non-generic names for engine/color functions 2016-05-11 09:49:03 -04:00
pikalaxalt
46ecd5b869 Name all functions in event/ 2016-05-10 12:59:34 -04:00
pikalaxalt
ae36ef2c7f Labeled every function in ROM0 that's referenced in the source 2016-05-10 12:31:49 -04:00
pikalaxalt
e95d42e0af All functions in main.asm have non-generic names 2016-05-08 14:11:24 -04:00
pikalaxalt
8c26547645 Mobile and more battle anims 2016-05-05 15:07:37 -04:00
pikalaxalt
a613ed915c HDMA transfer functions 2016-05-04 22:34:09 -04:00
pikalaxalt
3713b71d9e More splitting of main.asm; remove unneeded rept 2 2016-05-04 11:46:23 -04:00
pikalaxalt
82f1534925 Copycat labels; macro for the Crystal-only Unown chamber unlock words 2016-04-30 21:20:12 -04:00
pikalaxalt
73c7ea2b43 Local labels starting with underscores have colons depending on whether the first alphanumeric character is capitalized or not 2016-04-10 15:11:37 -04:00
pikalaxalt
6be4cd4da9 Local labels starting with lowercase letters are no longer decorated with a trailing colon 2016-04-10 15:01:49 -04:00