Rangi
0e1445b796
spaces->tab, and remove redundant comment
2018-08-26 16:15:43 -04:00
Rangi
557ce82073
hQuotient is a four-byte buffer ( fixes #558 )
2018-08-26 13:49:38 -04:00
Rangi
cb32c895e4
Explain wCreditsBlankFrame2bpp
2018-08-26 13:23:40 -04:00
Rangi
d2053c12c2
wCreditsFaux2bpp -> wCreditsBlankFrame2bpp, with the right buffer size
...
Remove some unused WRAM labels
2018-08-26 13:08:01 -04:00
Rangi
296402bd31
_Divide results go in hQuotient and hRemainder, not in hDividend and hDivisor
...
Note that the result quotient is four bytes, but hQuotient is a three-byte buffer. This is because no Divide caller ever needed a four-byte quotient, so the buffer didn't include the high byte.
2018-08-25 22:58:26 -04:00
Rangi
4c8c5c10a8
Use rgbasm's GameBoy graphics literal for initializing wCreditsFaux2bpp
...
In the 2BPP format, two bytes %ABCDEFGH %abcdefgh define eight pixels %Aa %Bb %Cc %Dd %Ee %Ff %Gg %Hh.
Four valid colors: %00 = 0 = white, %01 = 1 = dark, %10 = 2 = light, %11 = 3 = black.
Thus `22222222 = pixels %10 %10 %10 %10 %10 %10 %10 %10 = bytes %11111111 %00000000 = $ff00.
2018-08-25 22:38:57 -04:00
Rangi
b2adcd6d6f
Reorganize math-related HRAM union (ffb3)
2018-08-25 21:49:26 -04:00
Rangi
a71901020b
These are signed offsets, not addresses (thanks, PikalaxALT)
2018-08-25 14:43:02 -04:00
Rangi
7aa1c1f388
Remove HRAM label address comments
2018-08-25 14:39:24 -04:00
Rangi
1c0fff7668
hLabel - $ff00 -> LOW(hLabel)
2018-08-25 14:34:25 -04:00
Rangi
eb1e3636bb
Use labels instead of constants for HRAM
...
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 14:28:22 -04:00
mid-kid
50da83cb23
CheckDestinyBond -> CheckFaint
...
Its main function is fainting the opponent and ending the move effect.
Updated the comment accordingly.
2018-08-17 20:16:37 +02:00
mid-kid
79cf90ab5e
Fix some StatUp-related labels
2018-08-17 17:48:41 +02:00
mid-kid
2e147d1128
GetDamageStatsCritical -> CheckDamageStatsCritical
...
Clarified its usage, as the comments surrounding it were factually
wrong.
2018-08-16 16:11:28 +02:00
mid-kid
3cf49b7245
Fix more uses of EFFECTIVE
2018-08-07 14:38:41 +02:00
mid-kid
bc0595564e
Fix constants in BattleCommand_MirrorCoat
2018-08-07 09:46:21 +02:00
mid-kid
f98a95b8ee
wWeeklyFlags -> wDailyFlags2
...
These are by far not always checked each week, and as such shouldn't be
called that.
Since they're almost always used through the `bit` instruction, it's
very inconvenient to just make wDailyFlags a `dw` instead.
2018-08-07 09:46:21 +02:00
mid-kid
23cdf06e5e
RestorePPofDepositedPokemon -> RestorePPOfDepositedPokemon
2018-08-07 09:46:21 +02:00
mid-kid
86c1b05fbc
Split print_move_description and mon_menu
2018-08-07 09:46:21 +02:00
Rangi
366330e981
Pokedex_PutScrollbarOAM data values
2018-07-29 16:15:06 -04:00
Rangi
1d96a79a37
No wCurMove alias for wCurSpecies
2018-07-29 16:04:38 -04:00
Rangi
b5a9e83a94
Fix reviewed issues.
...
Pokedex_PrintListing has a comment noting how it depends on wCurSpecies == wNamedObjectIndexBuffer; an assert would be more convenient, but is not possible since WRAM label addresses are not defined yet here.
2018-07-29 16:00:11 -04:00
Rangi
c9cb67141b
Make reviewed fixes; standardize on " + "
2018-07-29 01:40:23 -04:00
Rangi
8498394701
wSwitchMon
2018-07-29 01:27:33 -04:00
Rangi
8aa08addba
wLuckyNumberDigitsBuffer
2018-07-29 01:13:25 -04:00
