pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2024-11-16 11:27:33 -08:00
Code Issues Packages Projects Releases Wiki Activity

Replace some "idiotic", "wtf", "stupid interns" comments with more common "useless", "pointless", "could have done X instead"

Browse Source
This commit is contained in:
Rangi 2020-02-23 15:30:21 -05:00
parent 62fccbbd99
commit c3f389d615
8 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
engine/items/switch_items.asm
View File

@ -225,7 +225,6 @@ Function24a6c:
ret ret
ItemSwitch_ConvertItemFormatToDW: ItemSwitch_ConvertItemFormatToDW:
; This function is absolutely idiotic.
push hl push hl
ld a, [wMenuData_ScrollingMenuItemFormat] ld a, [wMenuData_ScrollingMenuItemFormat]
ld c, a ld c, a

5
engine/menus/init_gender.asm
View File

@ -10,12 +10,11 @@ InitCrystalData:
ld [wd478], a ld [wd478], a
ld [wd002], a ld [wd002], a
ld [wd003], a ld [wd003], a
; could have done "ld a, [wd479] \ and %11111100", saved four operations
ld a, [wd479] ld a, [wd479]
res 0, a res 0, a ; ???
ld [wd479], a ld [wd479], a
ld a, [wd479] ld a, [wd479]
res 1, a res 1, a ; ???
ld [wd479], a ld [wd479], a
ret ret

3
engine/overworld/player_object.asm
View File

@ -122,9 +122,10 @@ RefreshPlayerCoords:
ld hl, wPlayerLastMapY ld hl, wPlayerLastMapY
ld [hl], e ld [hl], e
ld e, a ld e, a
; the next three lines are useless
ld a, [wObjectFollow_Leader] ld a, [wObjectFollow_Leader]
cp $0 cp $0
ret nz ; wtf ret nz
ret ret
CopyObjectStruct:: CopyObjectStruct::

2
engine/phone/phone.asm
View File

@ -23,7 +23,7 @@ DelCellNum::
ret ret
CheckCellNum:: CheckCellNum::
jp _CheckCellNum ; wtf jp _CheckCellNum ; useless
_CheckCellNum: _CheckCellNum:
ld hl, wPhoneList ld hl, wPhoneList

4
engine/pokemon/stats_screen.asm
View File

@ -60,7 +60,7 @@ StatsScreenInit_gotaddress:
StatsScreenMain: StatsScreenMain:
xor a xor a
ld [wJumptableIndex], a ld [wJumptableIndex], a
; stupid interns ; ???
ld [wcf64], a ld [wcf64], a
ld a, [wcf64] ld a, [wcf64]
and %11111100 and %11111100
@ -80,7 +80,7 @@ StatsScreenMain:
StatsScreenMobile: StatsScreenMobile:
xor a xor a
ld [wJumptableIndex], a ld [wJumptableIndex], a
; stupid interns ; ???
ld [wcf64], a ld [wcf64], a
ld a, [wcf64] ld a, [wcf64]
and %11111100 and %11111100

2
home/map.asm
View File

@ -592,7 +592,7 @@ ReadObjectEvents::
jr z, .skip jr z, .skip
; jr c, .skip ; jr c, .skip
; stupid waste of time and space ; could have done "inc hl" instead
ld bc, 1 ld bc, 1
add hl, bc add hl, bc
; Fill the remaining sprite IDs and y coords with 0 and -1, respectively. ; Fill the remaining sprite IDs and y coords with 0 and -1, respectively.

2
mobile/mobile_40.asm
View File

@ -6469,7 +6469,7 @@ Function102e07:
jr .okay jr .okay
.link_battle .link_battle
; this is idiotic ; the next three operations are pointless
hlcoord 3, 10 hlcoord 3, 10
ld b, 1 ld b, 1
ld c, 11 ld c, 11

2
mobile/mobile_menu.asm
View File

@ -146,7 +146,7 @@ MobileMenu_InitMenuBuffers:
ld [hli], a ld [hli], a
ld a, $20 ; w2DMenuCursorOffsets ld a, $20 ; w2DMenuCursorOffsets
ld [hli], a ld [hli], a
; this is a stupid way to load $c3 ; could have done "ld a, A_BUTTON | D_UP | D_DOWN | B_BUTTON" instead
ld a, A_BUTTON ld a, A_BUTTON
add D_UP add D_UP
add D_DOWN add D_DOWN