pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2025-09-08 08:13:02 -07:00
Code Issues Packages Projects Releases Wiki Activity

No redundant item effect labels

Browse Source
This commit is contained in:
Rangi
2018-02-05 13:03:05 -05:00
parent f8f3294130
commit 96c058f0a7
4 changed files with 225 additions and 365 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
data/items/attributes.asm
View File

@@ -6,7 +6,7 @@ item_attribute: MACRO
ENDM ENDM
ItemAttributes: ; 67c1 ItemAttributes: ; 67c1
; entries correspond to constants/item_constants.asm ; entries correspond to item ids
; MASTER_BALL ; MASTER_BALL
item_attribute 0, 0, 0, CANT_SELECT, BALL, ITEMMENU_NOUSE, ITEMMENU_CLOSE item_attribute 0, 0, 0, CANT_SELECT, BALL, ITEMMENU_NOUSE, ITEMMENU_CLOSE
; ULTRA_BALL ; ULTRA_BALL

1
data/items/descriptions.asm
View File

@@ -1,4 +1,5 @@
ItemDescriptions: ItemDescriptions:
; entries correspond to item ids
dw MasterBallDesc dw MasterBallDesc
dw UltraBallDesc dw UltraBallDesc
dw BrightpowderDesc dw BrightpowderDesc

8
docs/bugs_and_glitches.md
View File

@@ -587,7 +587,7 @@ Text_StringBuffer2ExpPoints::
## BRN/PSN/PAR do not affect catch rate ## BRN/PSN/PAR do not affect catch rate
This is a bug with `PokeBall` in [engine/item_effects.asm](/engine/item_effects.asm): This is a bug with `PokeBallEffect` in [engine/item_effects.asm](/engine/item_effects.asm):
```asm ```asm
; This routine is buggy. It was intended that SLP and FRZ provide a higher ; This routine is buggy. It was intended that SLP and FRZ provide a higher
@@ -1135,7 +1135,7 @@ endr
This bug can affect Mew or Pokémon other than Ditto that used Transform via Mirror Move or Sketch. This bug can affect Mew or Pokémon other than Ditto that used Transform via Mirror Move or Sketch.
This is a bug with `PokeBall` in [engine/item_effects.asm](/engine/item_effects.asm): This is a bug with `PokeBallEffect` in [engine/item_effects.asm](/engine/item_effects.asm):
```asm ```asm
ld hl, wEnemySubStatus5 ld hl, wEnemySubStatus5
@@ -1207,7 +1207,7 @@ This is a bug with `PokeBall` in [engine/item_effects.asm](/engine/item_effects.
([Video](https://www.youtube.com/watch?v=v1ErZdLCIyU)) ([Video](https://www.youtube.com/watch?v=v1ErZdLCIyU))
This is a bug with `ParkBall` in [engine/item_effects.asm](/engine/item_effects.asm): This is a bug with `PokeBallEffect` in [engine/item_effects.asm](/engine/item_effects.asm):
```asm ```asm
.room_in_party .room_in_party
@@ -1232,7 +1232,7 @@ This is a bug with `ParkBall` in [engine/item_effects.asm](/engine/item_effects.
## `HELD_CATCH_CHANCE` has no effect ## `HELD_CATCH_CHANCE` has no effect
This is a bug with `PokeBall` in [engine/item_effects.asm](/engine/item_effects.asm): This is a bug with `PokeBallEffect` in [engine/item_effects.asm](/engine/item_effects.asm):
```asm ```asm
; BUG: farcall overwrites a, and GetItemHeldEffect takes b anyway. ; BUG: farcall overwrites a, and GetItemHeldEffect takes b anyway.

579
engine/item_effects.asm
View File

File diff suppressed because it is too large Load Diff