pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2024-09-09 09:51:34 -07:00
Code Issues Packages Projects Releases Wiki Activity

Document Tackle is missing part of its hit animation

Browse Source 
Co-Authored-By: SoupPotato <22991349+SoupPotato@users.noreply.github.com>
This commit is contained in:
vulcandth 2024-01-01 21:18:10 -06:00 committed by xCrystal
parent e44744c587
commit 5d94f1c7b4
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
data/moves/animations.asm
View File

@ -2082,6 +2082,7 @@ BattleAnim_Headbutt:
anim_ret
BattleAnim_Tackle:
; BUG: Tackle is missing part of its hit animation (see docs/bugs_and_glitches.md)
anim_1gfx BATTLE_ANIM_GFX_HIT
anim_call BattleAnim_TargetObj_2Row
anim_bgeffect BATTLE_BG_EFFECT_TACKLE, $0, BG_EFFECT_USER, $0

17
docs/bugs_and_glitches.md
View File

@ -78,6 +78,7 @@ Fixes in the [multi-player battle engine](#multi-player-battle-engine) category
- [Using a Park Ball in non-Contest battles has a corrupt animation](#using-a-park-ball-in-non-contest-battles-has-a-corrupt-animation)
- [Battle transitions fail to account for the enemy's level](#battle-transitions-fail-to-account-for-the-enemys-level)
- [Some trainer NPCs have inconsistent overworld sprites](#some-trainer-npcs-have-inconsistent-overworld-sprites)
- [Tackle is missing part of its hit animation](#tackle-is-missing-part-of-its-hit-animation)
- [Audio](#audio)
- [Slot machine payout sound effects cut each other off](#slot-machine-payout-sound-effects-cut-each-other-off)
- [Team Rocket battle music is not used for Executives or Scientists](#team-rocket-battle-music-is-not-used-for-executives-or-scientists)
@ -2064,6 +2065,22 @@ Most of the NPCs in [maps/NationalParkBugContest.asm](https://github.com/pret/po
(The use of `SPRITE_ROCKER` instead of `SPRITE_COOLTRAINER_M` for `COOLTRAINERM NICK` may also be an intentional reference to the player's brother from the [Space World '97 beta](https://github.com/pret/pokegold-spaceworld).)
### Tackle is missing part of its hit animation
Copying two rows causes `BATTLE_BG_EFFECT_TACKLE` to hit the horizontal sprite limit. This fix restores the animation to copy only one row like in Pokémon Gold and Silver.
**Fix:** Edit `BattleAnim_Tackle` in [data/moves/animations.asm](https://github.com/pret/pokecrystal/blob/master/data/moves/animations.asm):
```diff
BattleAnim_Tackle:
-; BUG: Tackle is missing part of its hit animation (see docs/bugs_and_glitches.md)
anim_1gfx BATTLE_ANIM_GFX_HIT
- anim_call BattleAnim_TargetObj_2Row
+ anim_call BattleAnim_TargetObj_1Row
anim_bgeffect BATTLE_BG_EFFECT_TACKLE, $0, BG_EFFECT_USER, $0
```
## Audio