You've already forked pokecrystal-board
mirror of
https://gitlab.com/xCrystal/pokecrystal-board.git
synced 2025-04-09 05:44:44 -07:00
Document HOF Master bug (close #494)
This commit is contained in:
@@ -33,6 +33,7 @@ These are known bugs and glitches in the original Pokémon Crystal game: code th
|
||||
- [Magikarp length limits have a unit conversion error](#magikarp-length-limits-have-a-unit-conversion-error)
|
||||
- [Magikarp lengths can be miscalculated](#magikarp-lengths-can-be-miscalculated)
|
||||
- [Battle transitions fail to account for the enemy's level](#battle-transitions-fail-to-account-for-the-enemys-level)
|
||||
- [A "HOF Master!" title for 201-Time Famers is defined but inaccessible](#a-hof-master-title-for-201-time-famers-is-defined-but-inaccessible)
|
||||
- [Slot machine payout sound effects cut each other off](#slot-machine-payout-sound-effects-cut-each-other-off)
|
||||
- [Team Rocket battle music is not used for Executives or Scientists](#team-rocket-battle-music-is-not-used-for-executives-or-scientists)
|
||||
- [No bump noise if standing on tile `$3E`](#no-bump-noise-if-standing-on-tile-3e)
|
||||
@@ -897,6 +898,24 @@ StartTrainerBattle_DetermineWhichAnimation: ; 8c365 (23:4365)
|
||||
*To do:* Fix this bug.
|
||||
|
||||
|
||||
## A "HOF Master!" title for 201-Time Famers is defined but inaccessible
|
||||
|
||||
([Video](https://www.youtube.com/watch?v=iHkWubvxmSg))
|
||||
|
||||
This is a bug with `HallOfFame` in [engine/events/halloffame.asm](/engine/events/halloffame.asm):
|
||||
|
||||
```asm
|
||||
ld hl, wHallOfFameCount
|
||||
ld a, [hl]
|
||||
cp HOF_MASTER_COUNT - 1 ; should be HOF_MASTER_COUNT
|
||||
jr nc, .ok
|
||||
inc [hl]
|
||||
.ok
|
||||
```
|
||||
|
||||
**Fix:** Change `HOF_MASTER_COUNT - 1` to `HOF_MASTER_COUNT`.
|
||||
|
||||
|
||||
## Slot machine payout sound effects cut each other off
|
||||
|
||||
([Video](https://www.youtube.com/watch?v=ojq3xqfRF6I))
|
||||
|
Reference in New Issue
Block a user