pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2025-01-23 09:16:20 -08:00
Code Issues Packages Projects Releases Wiki Activity

Comment the Crystal 1.0 bugs as "BUG:" too

Browse Source
This commit is contained in:
Rangi 2022-12-14 22:30:20 -05:00
parent 8fd66c080f
commit 4387298b2c
4 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
engine/events/battle_tower/load_trainer.asm
View File

@ -30,8 +30,8 @@ if DEF(_CRYSTAL11)
maskbits BATTLETOWER_NUM_UNIQUE_TRAINERS maskbits BATTLETOWER_NUM_UNIQUE_TRAINERS
cp BATTLETOWER_NUM_UNIQUE_TRAINERS cp BATTLETOWER_NUM_UNIQUE_TRAINERS
else else
; Crystal 1.0 used the wrong constant here, so only the first 21 ; BUG: Crystal 1.0 used the wrong constant here, so only the first
; trainers in BattleTowerTrainers can be sampled. ; 21 trainers in BattleTowerTrainers can be sampled.
maskbits BATTLETOWER_NUM_UNIQUE_MON maskbits BATTLETOWER_NUM_UNIQUE_MON
cp BATTLETOWER_NUM_UNIQUE_MON cp BATTLETOWER_NUM_UNIQUE_MON
endc endc

7
engine/events/battle_tower/trainer_text.asm
View File

@ -10,10 +10,9 @@ BattleTowerText::
if DEF(_CRYSTAL11) if DEF(_CRYSTAL11)
ld hl, wBT_OTTrainerClass ld hl, wBT_OTTrainerClass
else else
; BUG ALERT ; BUG: Instead of loading the trainer class,
; Instead of loading the Trainer Class, this routine ; Crystal 1.0 loads the 6th character in the trainer's
; loads the 6th character in the Trainer's name, then ; name, then uses it to get the trainer's gender.
; uses it to get the gender of the trainer.
; As a consequence, the enemy trainer's dialog will ; As a consequence, the enemy trainer's dialog will
; always be sampled from the female array. ; always be sampled from the female array.
ld hl, wBT_OTName + NAME_LENGTH_JAPANESE - 1 ld hl, wBT_OTName + NAME_LENGTH_JAPANESE - 1

4
mobile/mobile_5c.asm
View File

@ -867,8 +867,8 @@ INCBIN "gfx/mobile/stadium2_n64.2bpp"
Stadium2N64Tilemap: Stadium2N64Tilemap:
if DEF(_CRYSTAL11) if DEF(_CRYSTAL11)
; Crystal 1.1 corrupted this tilemap by treating $0a bytes as Unix newlines, ; BUG: Crystal 1.1 corrupted this tilemap by treating $0a bytes as
; and converting them to $0d $0a Windows newlines. ; Unix newlines, and converting them to $0d $0a Windows newlines.
INCBIN "gfx/mobile/stadium2_n64_corrupt.tilemap" INCBIN "gfx/mobile/stadium2_n64_corrupt.tilemap"
else else
INCBIN "gfx/mobile/stadium2_n64.tilemap" INCBIN "gfx/mobile/stadium2_n64.tilemap"

9
ram/wram.asm
View File

@ -743,7 +743,8 @@ if DEF(_CRYSTAL11)
wPokedexStatus:: db wPokedexStatus:: db
wPokedexDataEnd:: wPokedexDataEnd::
else else
wPokedexDataEnd:: ds 1 wPokedexDataEnd::
ds 1
endc endc
ds 2 ds 2
@ -1538,8 +1539,10 @@ wPrevDexEntryJumptableIndex:: db
if DEF(_CRYSTAL11) if DEF(_CRYSTAL11)
wPrevDexEntryBackup:: db wPrevDexEntryBackup:: db
else else
wPrevDexEntryBackup:: ; BUG: Crystal 1.0 reused the same byte in WRAM for
wPokedexStatus:: db ; wPokedexStatus and wPrevDexEntryBackup.
wPokedexStatus::
wPrevDexEntryBackup:: db
endc endc
wUnusedPokedexByte:: db wUnusedPokedexByte:: db