pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2025-12-11 05:02:16 -08:00
Code Issues Packages Projects Releases Wiki Activity

Standardize on lowercase Tilemap and Attrmap

Browse Source 
We used to have a mixture of TileMap and and Tilemap, as well as the
similar AttrMap. Standardize on one.
This commit is contained in:
mid-kid
2020-02-13 18:30:13 +01:00
parent 34ceaac71d
commit 26b8bf003e
84 changed files with 630 additions and 630 deletions
Download Patch File Download Diff File Expand all files Collapse all files

210
engine/gfx/cgb_layouts.asm
View File

File diff suppressed because it is too large Load Diff

28
engine/gfx/color.asm
View File

@@ -103,7 +103,7 @@ InitPartyMenuPalettes:
ld hl, PalPacket_PartyMenu + 1
call CopyFourPalettes
call InitPartyMenuOBPals
call WipeAttrMap
call WipeAttrmap
ret
; SGB layout for SCGB_PARTY_MENU_HP_PALS
@@ -284,7 +284,7 @@ Unreferenced_Function8bec:
ld a, [wEnemyLightScreenCount] ; col
ld c, a
ld a, [wEnemyReflectCount] ; row
hlcoord 0, 0, wAttrMap
hlcoord 0, 0, wAttrmap
ld de, SCREEN_WIDTH
.loop
and a
@@ -320,8 +320,8 @@ ApplyMonOrTrainerPals:
.load_palettes
ld de, wBGPals1
call LoadPalette_White_Col1_Col2_Black
call WipeAttrMap
call ApplyAttrMap
call WipeAttrmap
call ApplyAttrmap
call ApplyPals
ret
@@ -359,7 +359,7 @@ ApplyHPBarPals:
.PartyMenu:
ld e, c
inc e
hlcoord 11, 1, wAttrMap
hlcoord 11, 1, wAttrmap
ld bc, 2 * SCREEN_WIDTH
ld a, [wCurPartyMon]
.loop
@@ -437,8 +437,8 @@ LoadMailPalettes:
ld a, BANK(wBGPals1)
call FarCopyWRAM
call ApplyPals
call WipeAttrMap
call ApplyAttrMap
call WipeAttrmap
call ApplyAttrmap
ret
.MailPals:
@@ -453,8 +453,8 @@ Unreferenced_Function95f0:
ld a, BANK(wBGPals1)
call FarCopyWRAM
call ApplyPals
call WipeAttrMap
call ApplyAttrMap
call WipeAttrmap
call ApplyAttrmap
ret
.Palette:
@@ -590,8 +590,8 @@ ResetBGPals:
pop af
ret
WipeAttrMap:
hlcoord 0, 0, wAttrMap
WipeAttrmap:
hlcoord 0, 0, wAttrmap
ld bc, SCREEN_WIDTH * SCREEN_HEIGHT
xor a
call ByteFill
@@ -605,7 +605,7 @@ ApplyPals:
call FarCopyWRAM
ret
ApplyAttrMap:
ApplyAttrmap:
ldh a, [rLCDC]
bit rLCDC_ENABLE, a
jr z, .UpdateVBank1
@@ -622,7 +622,7 @@ ApplyAttrMap:
ret
.UpdateVBank1:
hlcoord 0, 0, wAttrMap
hlcoord 0, 0, wAttrmap
debgcoord 0, 0
ld b, SCREEN_HEIGHT
ld a, $1
@@ -659,7 +659,7 @@ CGB_ApplyPartyMenuHPPals:
ld a, [de]
inc a
ld e, a
hlcoord 11, 2, wAttrMap
hlcoord 11, 2, wAttrmap
ld bc, 2 * SCREEN_WIDTH
ld a, [wSGBPals]
.loop

64
engine/gfx/crystal_layouts.asm
View File

@@ -42,8 +42,8 @@ MG_Mobile_Layout_FillBox:
jr nz, .row
ret
MG_Mobile_Layout_WipeAttrMap:
hlcoord 0, 0, wAttrMap
MG_Mobile_Layout_WipeAttrmap:
hlcoord 0, 0, wAttrmap
ld bc, SCREEN_HEIGHT * SCREEN_WIDTH
xor a
call ByteFill
@@ -64,14 +64,14 @@ MG_Mobile_Layout_LoadPals:
MG_Mobile_Layout00:
call MG_Mobile_Layout_LoadPals
call MG_Mobile_Layout_WipeAttrMap
call MG_Mobile_Layout_WipeAttrmap
call MG_Mobile_Layout_CreatePalBoxes
farcall ApplyAttrMap
farcall ApplyAttrmap
farcall ApplyPals
ret
MG_Mobile_Layout_CreatePalBoxes:
hlcoord 0, 0, wAttrMap
hlcoord 0, 0, wAttrmap
lb bc, 4, 1
ld a, $1
call MG_Mobile_Layout_FillBox
@@ -81,7 +81,7 @@ MG_Mobile_Layout_CreatePalBoxes:
lb bc, 6, 1
ld a, $3
call MG_Mobile_Layout_FillBox
hlcoord 1, 0, wAttrMap
hlcoord 1, 0, wAttrmap
ld a, $1
lb bc, 3, 18
call MG_Mobile_Layout_FillBox
@@ -91,7 +91,7 @@ MG_Mobile_Layout_CreatePalBoxes:
lb bc, 12, 18
ld a, $3
call MG_Mobile_Layout_FillBox
hlcoord 19, 0, wAttrMap
hlcoord 19, 0, wAttrmap
lb bc, 4, 1
ld a, $1
call MG_Mobile_Layout_FillBox
@@ -101,7 +101,7 @@ MG_Mobile_Layout_CreatePalBoxes:
lb bc, 6, 1
ld a, $3
call MG_Mobile_Layout_FillBox
hlcoord 0, 12, wAttrMap
hlcoord 0, 12, wAttrmap
ld bc, 6 * SCREEN_WIDTH
ld a, $7
call ByteFill
@@ -136,12 +136,12 @@ MG_Mobile_Layout01:
ld bc, 1 palettes
ld a, BANK(wBGPals1)
call FarCopyWRAM
call MG_Mobile_Layout_WipeAttrMap
hlcoord 0, 0, wAttrMap
call MG_Mobile_Layout_WipeAttrmap
hlcoord 0, 0, wAttrmap
ld bc, SCREEN_WIDTH * SCREEN_HEIGHT
xor a
call ByteFill
hlcoord 0, 14, wAttrMap
hlcoord 0, 14, wAttrmap
ld bc, 4 * SCREEN_WIDTH
ld a, $7
call ByteFill
@@ -155,7 +155,7 @@ MG_Mobile_Layout01:
call Function49496
.asm_49467
farcall ApplyAttrMap
farcall ApplyAttrmap
farcall ApplyPals
ld a, $1
ldh [hCGBPalUpdate], a
@@ -168,26 +168,26 @@ MG_Mobile_Layout01:
RGB 00, 00, 00
Function49480:
hlcoord 0, 0, wAttrMap
hlcoord 0, 0, wAttrmap
lb bc, 4, SCREEN_WIDTH
ld a, $7
call MG_Mobile_Layout_FillBox
hlcoord 0, 2, wAttrMap
hlcoord 0, 2, wAttrmap
ld a, $4
ld [hl], a
hlcoord 19, 2, wAttrMap
hlcoord 19, 2, wAttrmap
ld [hl], a
ret
Function49496:
hlcoord 0, 0, wAttrMap
hlcoord 0, 0, wAttrmap
lb bc, 2, SCREEN_WIDTH
ld a, $7
call MG_Mobile_Layout_FillBox
hlcoord 0, 1, wAttrMap
hlcoord 0, 1, wAttrmap
ld a, $4
ld [hl], a
hlcoord 19, 1, wAttrMap
hlcoord 19, 1, wAttrmap
ld [hl], a
ret
@@ -200,8 +200,8 @@ MG_Mobile_Layout02:
ld a, BANK(wBGPals1)
call FarCopyWRAM
farcall ApplyPals
call MG_Mobile_Layout_WipeAttrMap
farcall ApplyAttrMap
call MG_Mobile_Layout_WipeAttrmap
farcall ApplyAttrmap
ld hl, .Palette_4973a
ld de, wOBPals1
ld bc, 1 palettes
@@ -234,43 +234,43 @@ Function49742:
INCLUDE "gfx/unknown/49757.pal"
_InitMG_Mobile_LinkTradePalMap:
hlcoord 0, 0, wAttrMap
hlcoord 0, 0, wAttrmap
lb bc, 16, 2
ld a, $4
call MG_Mobile_Layout_FillBox
ld a, $3
ldcoord_a 0, 1, wAttrMap
ldcoord_a 0, 14, wAttrMap
hlcoord 2, 0, wAttrMap
ldcoord_a 0, 1, wAttrmap
ldcoord_a 0, 14, wAttrmap
hlcoord 2, 0, wAttrmap
lb bc, 8, 18
ld a, $5
call MG_Mobile_Layout_FillBox
hlcoord 2, 8, wAttrMap
hlcoord 2, 8, wAttrmap
lb bc, 8, 18
ld a, $6
call MG_Mobile_Layout_FillBox
hlcoord 0, 16, wAttrMap
hlcoord 0, 16, wAttrmap
lb bc, 2, SCREEN_WIDTH
ld a, $4
call MG_Mobile_Layout_FillBox
ld a, $3
lb bc, 6, 1
hlcoord 6, 1, wAttrMap
hlcoord 6, 1, wAttrmap
call MG_Mobile_Layout_FillBox
ld a, $3
lb bc, 6, 1
hlcoord 17, 1, wAttrMap
hlcoord 17, 1, wAttrmap
call MG_Mobile_Layout_FillBox
ld a, $3
lb bc, 6, 1
hlcoord 6, 9, wAttrMap
hlcoord 6, 9, wAttrmap
call MG_Mobile_Layout_FillBox
ld a, $3
lb bc, 6, 1
hlcoord 17, 9, wAttrMap
hlcoord 17, 9, wAttrmap
call MG_Mobile_Layout_FillBox
ld a, $2
hlcoord 2, 16, wAttrMap
hlcoord 2, 16, wAttrmap
ld [hli], a
ld a, $7
ld [hli], a
@@ -278,7 +278,7 @@ _InitMG_Mobile_LinkTradePalMap:
ld [hli], a
ld a, $2
ld [hl], a
hlcoord 2, 17, wAttrMap
hlcoord 2, 17, wAttrmap
ld a, $3
ld bc, 6
call ByteFill

114
engine/gfx/dma_transfer.asm
View File

@@ -1,49 +1,49 @@
HDMATransferAttrMapAndTileMapToWRAMBank3::
HDMATransferAttrmapAndTilemapToWRAMBank3::
ld hl, .Function
jp CallInSafeGFXMode
.Function:
decoord 0, 0, wAttrMap
ld hl, wScratchAttrMap
call PadAttrMapForHDMATransfer
decoord 0, 0, wAttrmap
ld hl, wScratchAttrmap
call PadAttrmapForHDMATransfer
decoord 0, 0
ld hl, wScratchTileMap
ld hl, wScratchTilemap
call PadTilemapForHDMATransfer
ld a, $0
ldh [rVBK], a
ld hl, wScratchTileMap
ld hl, wScratchTilemap
call HDMATransferToWRAMBank3
ld a, $1
ldh [rVBK], a
ld hl, wScratchAttrMap
ld hl, wScratchAttrmap
call HDMATransferToWRAMBank3
ret
HDMATransferTileMapToWRAMBank3::
HDMATransferTilemapToWRAMBank3::
ld hl, .Function
jp CallInSafeGFXMode
.Function:
decoord 0, 0
ld hl, wScratchTileMap
ld hl, wScratchTilemap
call PadTilemapForHDMATransfer
ld a, $0
ldh [rVBK], a
ld hl, wScratchTileMap
ld hl, wScratchTilemap
call HDMATransferToWRAMBank3
ret
HDMATransferAttrMapToWRAMBank3:
HDMATransferAttrmapToWRAMBank3:
ld hl, .Function
jp CallInSafeGFXMode
.Function:
decoord 0, 0, wAttrMap
ld hl, wScratchAttrMap
call PadAttrMapForHDMATransfer
decoord 0, 0, wAttrmap
ld hl, wScratchAttrmap
call PadAttrmapForHDMATransfer
ld a, $1
ldh [rVBK], a
ld hl, wScratchAttrMap
ld hl, wScratchAttrmap
call HDMATransferToWRAMBank3
ret
@@ -52,11 +52,11 @@ ReloadMapPart::
jp CallInSafeGFXMode
.Function:
decoord 0, 0, wAttrMap
ld hl, wScratchAttrMap
call PadAttrMapForHDMATransfer
decoord 0, 0, wAttrmap
ld hl, wScratchAttrmap
call PadAttrmapForHDMATransfer
decoord 0, 0
ld hl, wScratchTileMap
ld hl, wScratchTilemap
call PadTilemapForHDMATransfer
call DelayFrame
@@ -65,11 +65,11 @@ ReloadMapPart::
push af
ld a, $1
ldh [rVBK], a
ld hl, wScratchAttrMap
ld hl, wScratchAttrmap
call HDMATransfer_Wait127Scanlines_toBGMap
ld a, $0
ldh [rVBK], a
ld hl, wScratchTileMap
ld hl, wScratchTilemap
call HDMATransfer_Wait127Scanlines_toBGMap
pop af
ldh [rVBK], a
@@ -83,11 +83,11 @@ Mobile_ReloadMapPart:
jp CallInSafeGFXMode
.Function:
decoord 0, 0, wAttrMap
ld hl, wScratchAttrMap
call PadAttrMapForHDMATransfer
decoord 0, 0, wAttrmap
ld hl, wScratchAttrmap
call PadAttrmapForHDMATransfer
decoord 0, 0
ld hl, wScratchTileMap
ld hl, wScratchTilemap
call PadTilemapForHDMATransfer
call DelayFrame
@@ -96,11 +96,11 @@ Mobile_ReloadMapPart:
push af
ld a, $1
ldh [rVBK], a
ld hl, wScratchAttrMap
ld hl, wScratchAttrmap
call HDMATransfer_NoDI
ld a, $0
ldh [rVBK], a
ld hl, wScratchTileMap
ld hl, wScratchTilemap
call HDMATransfer_NoDI
pop af
ldh [rVBK], a
@@ -144,20 +144,20 @@ Mobile_ReloadMapPart:
call HDMATransferToWRAMBank3
ret
OpenAndCloseMenu_HDMATransferTileMapAndAttrMap::
OpenAndCloseMenu_HDMATransferTilemapAndAttrmap::
; OpenText
ld hl, .Function
jp CallInSafeGFXMode
.Function:
; Transfer wAttrMap and Tilemap to BGMap
; Transfer wAttrmap and Tilemap to BGMap
; Fill vBGAttrs with $00
; Fill vBGTiles with " "
decoord 0, 0, wAttrMap
ld hl, wScratchAttrMap
call PadAttrMapForHDMATransfer
decoord 0, 0, wAttrmap
ld hl, wScratchAttrmap
call PadAttrmapForHDMATransfer
decoord 0, 0
ld hl, wScratchTileMap
ld hl, wScratchTilemap
call PadTilemapForHDMATransfer
call DelayFrame
@@ -166,40 +166,40 @@ OpenAndCloseMenu_HDMATransferTileMapAndAttrMap::
push af
ld a, $1
ldh [rVBK], a
ld hl, wScratchAttrMap
ld hl, wScratchAttrmap
call HDMATransfer_Wait123Scanlines_toBGMap
ld a, $0
ldh [rVBK], a
ld hl, wScratchTileMap
ld hl, wScratchTilemap
call HDMATransfer_Wait123Scanlines_toBGMap
pop af
ldh [rVBK], a
ei
ret
Mobile_OpenAndCloseMenu_HDMATransferTileMapAndAttrMap:
Mobile_OpenAndCloseMenu_HDMATransferTilemapAndAttrmap:
ld hl, .Function
jp CallInSafeGFXMode
.Function:
; Transfer wAttrMap and Tilemap to BGMap
; Transfer wAttrmap and Tilemap to BGMap
; Fill vBGAttrs with $00
; Fill vBGTiles with $ff
decoord 0, 0, wAttrMap
ld hl, wScratchAttrMap
call PadAttrMapForHDMATransfer
decoord 0, 0, wAttrmap
ld hl, wScratchAttrmap
call PadAttrmapForHDMATransfer
ld c, $ff
decoord 0, 0
ld hl, wScratchTileMap
ld hl, wScratchTilemap
call PadMapForHDMATransfer
ld a, $1
ldh [rVBK], a
ld hl, wScratchAttrMap
ld hl, wScratchAttrmap
call HDMATransfer_Wait127Scanlines_toBGMap
ld a, $0
ldh [rVBK], a
ld hl, wScratchTileMap
ld hl, wScratchTilemap
call HDMATransfer_Wait127Scanlines_toBGMap
ret
@@ -213,7 +213,7 @@ CallInSafeGFXMode:
ldh [hMapAnims], a
ldh a, [rSVBK]
push af
ld a, BANK(wScratchTileMap)
ld a, BANK(wScratchTilemap)
ldh [rSVBK], a
ldh a, [rVBK]
push af
@@ -410,7 +410,7 @@ PadTilemapForHDMATransfer:
ld c, " "
jr PadMapForHDMATransfer
PadAttrMapForHDMATransfer:
PadAttrmapForHDMATransfer:
ld c, $0
PadMapForHDMATransfer:
@@ -455,13 +455,13 @@ _Get2bpp::
; switch to WRAM bank 6
ldh a, [rSVBK]
push af
ld a, BANK(wScratchTileMap)
ld a, BANK(wScratchTilemap)
ldh [rSVBK], a
push bc
push hl
; Copy c tiles of the 2bpp from b:de to wScratchTileMap
; Copy c tiles of the 2bpp from b:de to wScratchTilemap
ld a, b ; bank
ld l, c ; number of tiles
ld h, $0
@@ -474,7 +474,7 @@ _Get2bpp::
ld c, l
ld h, d ; address
ld l, e
ld de, wScratchTileMap
ld de, wScratchTilemap
call FarCopyBytes
pop hl
@@ -486,7 +486,7 @@ _Get2bpp::
ld d, h
ld e, l
ld hl, wScratchTileMap
ld hl, wScratchTilemap
call HDMATransfer_Wait127Scanlines
; restore the previous bank
@@ -523,7 +523,7 @@ _Get1bpp::
.bankswitch
ldh a, [rSVBK]
push af
ld a, BANK(wScratchTileMap)
ld a, BANK(wScratchTilemap)
ldh [rSVBK], a
push bc
@@ -539,7 +539,7 @@ _Get1bpp::
ld b, h
ld h, d
ld l, e
ld de, wScratchTileMap
ld de, wScratchTilemap
call FarCopyBytesDouble_DoubleBankSwitch
pop hl
@@ -551,7 +551,7 @@ _Get1bpp::
ld d, h
ld e, l
ld hl, wScratchTileMap
ld hl, wScratchTilemap
call HDMATransfer_Wait127Scanlines
pop af
@@ -563,22 +563,22 @@ HDMATransfer_OnlyTopFourRows:
jp CallInSafeGFXMode
.Function:
ld hl, wScratchTileMap
ld hl, wScratchTilemap
decoord 0, 0
call .Copy
ld hl, wScratchTileMap + $80
decoord 0, 0, wAttrMap
ld hl, wScratchTilemap + $80
decoord 0, 0, wAttrmap
call .Copy
ld a, $1
ldh [rVBK], a
ld c, $8
ld hl, wScratchTileMap + $80
ld hl, wScratchTilemap + $80
debgcoord 0, 0, vBGMap1
call HDMATransfer_Wait127Scanlines
ld a, $0
ldh [rVBK], a
ld c, $8
ld hl, wScratchTileMap
ld hl, wScratchTilemap
debgcoord 0, 0, vBGMap1
call HDMATransfer_Wait127Scanlines
ret

16
engine/gfx/pic_animation.asm
View File

@@ -87,7 +87,7 @@ AnimateFrontpic:
.loop
call SetUpPokeAnim
push af
farcall HDMATransferTileMapToWRAMBank3
farcall HDMATransferTilemapToWRAMBank3
pop af
jr nc, .loop
ret
@@ -261,9 +261,9 @@ PokeAnim_DeinitFrames:
ld a, BANK(wPokeAnimCoord)
ldh [rSVBK], a
call PokeAnim_PlaceGraphic
farcall HDMATransferTileMapToWRAMBank3
farcall HDMATransferTilemapToWRAMBank3
call PokeAnim_SetVBank0
farcall HDMATransferAttrMapToWRAMBank3
farcall HDMATransferAttrmapToWRAMBank3
pop af
ldh [rSVBK], a
ret
@@ -830,13 +830,13 @@ PokeAnim_SetVBank1:
xor a
ldh [hBGMapMode], a
call .SetFlag
farcall HDMATransferAttrMapToWRAMBank3
farcall HDMATransferAttrmapToWRAMBank3
pop af
ldh [rSVBK], a
ret
.SetFlag:
call PokeAnim_GetAttrMapCoord
call PokeAnim_GetAttrmapCoord
ld b, 7
ld c, 7
ld de, SCREEN_WIDTH
@@ -858,7 +858,7 @@ PokeAnim_SetVBank1:
ret
PokeAnim_SetVBank0:
call PokeAnim_GetAttrMapCoord
call PokeAnim_GetAttrmapCoord
ld b, 7
ld c, 7
ld de, SCREEN_WIDTH
@@ -879,12 +879,12 @@ PokeAnim_SetVBank0:
jr nz, .row
ret
PokeAnim_GetAttrMapCoord:
PokeAnim_GetAttrmapCoord:
ld hl, wPokeAnimCoord
ld a, [hli]
ld h, [hl]
ld l, a
ld de, wAttrMap - wTileMap
ld de, wAttrmap - wTilemap
add hl, de
ret