As suggested in the code review:
- More traditional placment of the const specifier, e.g. const unsigned char * instead of unsigned char const *
- Matching casts to also cast to const unsigned char * instead of of unsigned char *
Co-Authored-By: Frank Dana <ferdnyc@gmail.com>
As mentioned in issue #202 QImage::bits() and QImage::scanLine() make
a deep copy of the source image. This is completely unnecessary when
read-only access to the pixel data is required. Changing to
QImage::constBits() and QImage::constScanLine() solves this. Both
functions were introduced in Qt 4.7.
https://doc.qt.io/qt-5/qimage.html#constBits
* Add ImageMagick 7 compatibility
A new header, `imclude/MagickUtilities.h`, is created to hold the
compatibility `#define`s.
The image-conversion code in `src/Frame.cpp` received the only
major changes — instead of doing the export by hand (and having
to account for changes in the underlying API), it uses the
`MagickCore::ExportImagePixels()` function which does basically
the same work, but accounts for all of the API changes for us.
The API of that function is _unchanged_ from IM6 to IM7.
TODO: `MagickCore::ExportImagePixels()` will return an `exception`
struct if it encounters any problems. Currently the code ignores
that, which it should not.
* Add ImageMagick 7 compatibility
A new header, `imclude/MagickUtilities.h`, is created to hold the
compatibility `#define`s.
The image-conversion code in `src/Frame.cpp` received the only
major changes — instead of doing the export by hand (and having
to account for changes in the underlying API), it uses the
`MagickCore::ExportImagePixels()` function which does basically
the same work, but accounts for all of the API changes for us.
The API of that function is _unchanged_ from IM6 to IM7.
TODO: `MagickCore::ExportImagePixels()` will return an `exception`
struct if it encounters any problems. Currently the code ignores
that, which it should not.
Thanks @ferdnyc
