Commit Graph

2598 Commits

Author SHA1 Message Date
Jonathan Thomas
2c193463ce Experimental: No QImage cleanup 2022-07-26 17:07:54 -05:00
Jonathan Thomas
0164bd28be Experimental: Change method of copying QImage from previous frames to use qimage.copy method. 2022-07-26 15:40:57 -05:00
Jonathan Thomas
f2852e8c34 Experimental: additional logging around AddImage() calls 2022-07-26 15:21:25 -05:00
Jonathan Thomas
89321d3bae Experimental: adding debug logging to Frame destructor and QImage cleanup. Also, preventing processing of empty samples 2022-07-26 15:09:57 -05:00
Jonathan Thomas
285059baad Experimental: adding debug symbols 2022-07-25 17:24:35 -05:00
Jonathan Thomas
297349033e Experimental FFmpegReader::Close changes, adding new drain decoder logic on Close 2022-07-25 16:27:31 -05:00
Jonathan Thomas
68f273d9d1 Experimental FFmpegReader::Close changes 2022-07-23 19:44:01 -05:00
Jonathan Thomas
3883d2d8aa Experimental FFmpegReader::Close changes 2022-07-23 18:47:42 -05:00
Jonathan Thomas
70bf0ade98 Refactoring FFmpegReader::Close, trying to prevent a crash on Windows 2022-07-22 18:00:28 -05:00
Jonathan Thomas
54971bac84 Removing some logic in FFmpegReader::Close which clears the video and audio stream - which can cause a crash if the decoder is still working on a packet. Reverting this code. 2022-07-22 17:04:52 -05:00
Jonathan Thomas
156fed2f49 Adding debugging to FFmpegReader::Close and removing a discard property that is probably unneeded 2022-07-22 16:50:02 -05:00
Jonathan Thomas
671e8ce455 Clean up of whitespace, and removal of unneeded logic on CheckWorkingFrames() method. It is okay to finalize a frame from a stream that has not decoded a packet yet... although it would be unlikely. 2022-07-21 16:50:23 -05:00
Jonathan Thomas
dd25b7835d Removing failing macos from our GitHub build CI 2022-07-21 15:25:26 -05:00
Jonathan Thomas
9202d94ee6 Fixing whitespace issues (converting spaces back to tabs... for now) 2022-07-21 15:00:08 -05:00
Jonathan Thomas
f200c00e4c Fixing Codacy issues 2022-07-21 14:21:44 -05:00
Jonathan Thomas
f4966b2567 Large refactor of timestamps on FFmpegReader (PTS / presentation time stamps):
- Improved PTS offset logic (to offset our streams so that at least one of them starts at position 0.0)
- Removed missing frame detection (no needed anymore)
- Use timestamps to reason about missing frames
- Fixed many async decoding issues (jumbled frames, missing beginning or ending frames)
- Much improved support for video/audio files with missing chunks/gaps (i.e. missing timestamps)
- Improved CheckWorkingFrames() method, to determine when working frames are ready to be finalized
- Improved FPS detection for invalid or missing FPS
2022-07-21 13:56:29 -05:00
Jonathan Thomas
d093004dcf Fixing timeline tests. Recent FrameMapper bug fixes changed the mapping slightly, for certain tests 2022-07-21 10:07:34 -05:00
Jonathan Thomas
cba676463d Fixing invalid frame mapping calculation (when using a linear algorithm to map framerates). We were accidentally adding +1 to the video_length, causing a slight rounding error, causing some random frames to be skipped.
For example, if a video with 100 frames was mapped to the same framerate, we would calculate the frame increment: 101 / 100 (instead of 100 / 100). In this simple example, the value increment should be 1.0, matching the source frames exactly.
2022-06-25 17:42:30 -05:00
Jonathan Thomas
d2c7e856bb Fixing invalid "end frame" calculation for clips (we were accidentally adding +1) to the last frame of every clip, causing a repeat of the clip's last frame.
For example, if a video had only 10 frames (video_length), timeline would calculate the start_frame as 1, and end_frame as 11, which is incorrect. It should use start_frame as 1, end_frame as 10.
2022-06-25 17:39:48 -05:00
Jonathan Thomas
d243db8aaa Adding new GetFrames method to CacheBase, to return an ordered vector of Frame objects. Useful when needing to iterate through the current cached frames. 2022-06-25 17:32:36 -05:00
Jonathan Thomas
5776efd71c Merge pull request #834 from OpenShot/fix-object-detector-class-name
Fix regression caused by Object Detector renamed to Object Detection
2022-06-22 14:27:01 -05:00
Jonathan Thomas
7355ac3c55 Fix regression caused by https://github.com/OpenShot/libopenshot/pull/827, where we changed the class_name of Object Detector 2022-06-21 11:30:30 -05:00
Frank Dana
7c6fcb0c51 Merge pull request #828 from ferdnyc/catch-upgrade
Make unit tests work with Catch2v3 (for macOS CI)
2022-06-18 05:53:35 -04:00
dependabot[bot]
54c9650599 Bump actions/cache from 2 to 3.0.1 (#821)
Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3.0.1.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/v2...v3.0.1)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-06-18 05:28:07 -04:00
FeRD (Frank Dana)
6c5ffe1c1d HACK: 'using namespace Catch' in v3 header 2022-06-18 04:45:50 -04:00