Makes nearly all `file_path` arguments optional, unless the exception deals
with file operations specifically (e.g. InvalidFile still requires file_path)
This changes the type of the private `path` variable to QString
internally (which we were converting it to for a bunch of operations
anyway), and uses QString's more robust string-manipulation and
comparison methods to ensure that only filenames that _end in_ an
.svg/.svgz extension (case-insensitively) are recognized as SVG files.
Previously, a filename such as "Title.svg.png" would be interpreted as
an SVG file.
The change in QString type is purely internal, all of the class's
interfaces remain the same, and accept `std::string path`. We simply
convert it to/from QString at opposite places in the code, now.
Overrides go at the end of the declaration. Qt also has the `Q_DECL_OVERRIDE` preprocessor define, which expands to `override` only when building the code using C++11 or higher.
* Remove a SWIG pragma from Frame.h (gcc warns on it)
* Place the equivalent %warnfilter in the openshot.i files
* Set openshot.i PROPERTY GENERATED_COMPILE_OPTIONS with flags to
disable warning spew in generated SWIG code, if -Wall is used
(Also, remove 'using namespace std' from Frame.h, and add std::
prefixes to necessary variables.)
The range was listed as 0 – 100, but implemented as -1 – +1. Edited documentation to reflect reality.
Reported by @jeffski like a year and a half ago.
Fixes#71
Give the AppendDebugMethod() declaration a set of default values for
all parameters after the first. (It uses `""` and `-1.0`, which are
what callers were passing in anyway.) This way, callers have the
_option_ to eschew this kind of thing:
```
ZmqLogger::Instance()->AppendDebugMethod("Message", "start", start,
"length", length, "", -1, "", -1, "", -1, "", -1);
```
instead, they can use the functionally equivalent:
```
ZmqLogger::Instance()->AppendDebugMethod("Message", "start", start,
"length", length);
```
Passing meaningless args is the compiler's job, not the programmer's.
Some fixes for `-Wall`-readiness:
* Removed `using namespace std;` from the header and
added `std::` prefixes where needed (`std::string`)
* Replaced `throw ()` in declarations with `noexcept`,
as `throw ()` is [deprecated in c++11][1]
* Several exception classes had a `file_path` member
variable, despite never using it. Removed the
unused class member.
[1]:<https://en.cppreference.com/w/cpp/language/noexcept_spec>