- Previously 'av_make_error_string' was defined in FFmpegUtilities.h
for the sole purpose of redefining `av_err2str()` as a call to that
function. `av_err2str()` was then used in our code, often in string
contexts where its output was cast to `std::string`.
- Since that was excessively circular, instead the function is named
`av_err2string()`, and it's used directly in contexts where a
std::string is expected.
- `av_err2str()` is still #defined as `av_err2string(...).c_str()`
Since commit bfa050409c (2015-08-24),
there is no code in libopenshot which ever throws TooManySeeks.
- Removed catch() statements for TooManySeeks from multiple functions
- Removed the exception from Exceptions.h
- in Qt/AudioPlaybackThread.h:
- Removed the "SafeTimeSliceThread" class definition, as it only
existed to catch TooManySeeks.
- Replaced SafeTimeSliceThread with a standard juce::TimeSliceThread
The backward conversion int16_t to float in libopenshot has range
(1.0; -1.0], thus conversion -1.0f to int16_t should be secured.
Float values can exceed the (1.0; -1.0) range. This can cause
distortion in audio instead of limiting values at max/min for the
int16_t.
- Parsing from string to Json::Value is now done by utility function
openshot::stringToJson() in Json.cpp, all SetJson() methods call it.
- Expand use of const member functions and args where appropriate.
- Use std::to_string() to format int/float values as strings.
- Correct mentions of nonexistent Json::JsonValue type in docstrings
