openshot/libopenshot
0
0
Fork 0
mirror of https://github.com/OpenShot/libopenshot.git synced 2026-03-02 08:53:52 -08:00
Code Issues Packages Projects Releases Wiki Activity

Protect the video and audio codec name discovery flow, to prevent crash from unknown codecs.

Browse Source
This commit is contained in:
Jonathan Thomas
2025-09-07 15:02:26 -05:00
parent dd62f5b49e
commit fbef1bcf04
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/FFmpegWriter.cpp
View File

@@ -126,17 +126,18 @@ void FFmpegWriter::auto_detect_format() {
// Determine what format to use when encoding this output filename
oc->oformat = av_guess_format(NULL, path.c_str(), NULL);
if (oc->oformat == nullptr) {
throw InvalidFormat(
"Could not deduce output format from file extension.", path);
throw InvalidFormat("Could not deduce output format from file extension.", path);
}
// Update video codec name
if (oc->oformat->video_codec != AV_CODEC_ID_NONE && info.has_video)
info.vcodec = avcodec_find_encoder(oc->oformat->video_codec)->name;
// Update audio codec name
if (oc->oformat->audio_codec != AV_CODEC_ID_NONE && info.has_audio)
info.acodec = avcodec_find_encoder(oc->oformat->audio_codec)->name;
// Update video & audio codec name
if (oc->oformat->video_codec != AV_CODEC_ID_NONE && info.has_video) {
const AVCodec *vcodec = avcodec_find_encoder(oc->oformat->video_codec);
info.vcodec = vcodec ? vcodec->name : std::string();
}
if (oc->oformat->audio_codec != AV_CODEC_ID_NONE && info.has_audio) {
const AVCodec *acodec = avcodec_find_encoder(oc->oformat->audio_codec);
info.acodec = acodec ? acodec->name : std::string();
}
}
// initialize streams