You've already forked libopenshot
mirror of
https://github.com/OpenShot/libopenshot.git
synced 2026-03-02 08:53:52 -08:00
Merge pull request #309 from ferdnyc/no-initfileinfo
Remove mentions of nonexistent InitFileInfo()
This commit is contained in:
@@ -57,8 +57,7 @@ namespace openshot
|
||||
* @brief This struct contains info about a media file, such as height, width, frames per second, etc...
|
||||
*
|
||||
* Each derived class of ReaderBase is responsible for updating this struct to reflect accurate information
|
||||
* about the streams. Derived classes of ReaderBase should call the InitFileInfo() method to initialize the
|
||||
* default values of this struct.
|
||||
* about the streams.
|
||||
*/
|
||||
struct ReaderInfo
|
||||
{
|
||||
@@ -95,7 +94,7 @@ namespace openshot
|
||||
*
|
||||
* Readers are types of classes that read video, audio, and image files, and
|
||||
* return openshot::Frame objects. The only requirements for a 'reader', are to
|
||||
* derive from this base class, implement the GetFrame method, and call the InitFileInfo() method.
|
||||
* derive from this base class, implement the GetFrame method, and populate ReaderInfo.
|
||||
*/
|
||||
class ReaderBase
|
||||
{
|
||||
|
||||
@@ -32,7 +32,7 @@
|
||||
|
||||
using namespace openshot;
|
||||
|
||||
// Initialize the values of the FileInfo struct
|
||||
// Initialize the values of the EffectInfo struct
|
||||
void EffectBase::InitEffectInfo()
|
||||
{
|
||||
// Init clip settings
|
||||
|
||||
@@ -59,7 +59,6 @@ TEST(ReaderBase_Derived_Class)
|
||||
TestReader t1;
|
||||
|
||||
// Check some of the default values of the FileInfo struct on the base class
|
||||
// If InitFileInfo() is not called in the derived class, these checks would fail.
|
||||
CHECK_EQUAL(false, t1.info.has_audio);
|
||||
CHECK_EQUAL(false, t1.info.has_audio);
|
||||
CHECK_CLOSE(0.0f, t1.info.duration, 0.00001);
|
||||
|
||||
Reference in New Issue
Block a user