openshot/libopenshot
0
0
Fork 0
mirror of https://github.com/OpenShot/libopenshot.git synced 2026-03-02 08:53:52 -08:00
Code Issues Packages Projects Releases Wiki Activity

Check if the codec supports CRF when setting q values

Browse Source
This commit is contained in:
eisneinechse
2019-03-10 13:09:47 -07:00
parent b5ebc996ee
commit a170d7db38
1 changed files with 22 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/FFmpegWriter.cpp
View File

@@ -1140,13 +1140,28 @@ AVStream* FFmpegWriter::add_video_stream()
// Defaults are used because mpeg2 otherwise had problems
}
else {
if (info.video_bit_rate < 40) {
c->qmin = 0;
c->qmax = 63;
}
else {
c->qmin = info.video_bit_rate - 5;
c->qmax = 63;
// Check if codec supports crf
switch (c->codec_id) {
#if (LIBAVCODEC_VERSION_MAJOR >= 58)
case AV_CODEC_ID_AV1 :
#endif
case AV_CODEC_ID_VP8 :
case AV_CODEC_ID_VP9 :
case AV_CODEC_ID_H264 :
case AV_CODEC_ID_H265 :
if (info.video_bit_rate < 40) {
c->qmin = 0;
c->qmax = 63;
}
else {
c->qmin = info.video_bit_rate - 5;
c->qmax = 63;
}
break;
default:
// Here should be the setting for codecs that don't support crf
// For now defaults are used
break;
}
}