openshot/libopenshot
0
0
Fork 0
mirror of https://github.com/OpenShot/libopenshot.git synced 2026-03-02 08:53:52 -08:00
Code Issues Packages Projects Releases Wiki Activity

Adding hvc1 tag for apple playback support of h.265 files. Also fixing a regression in the is_mp4/is_mov logic.

Browse Source
This commit is contained in:
Jonathan Thomas
2025-03-09 19:21:29 -05:00
parent 76d6a9a73e
commit 10145df409
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/FFmpegWriter.cpp
View File

@@ -643,18 +643,23 @@ void FFmpegWriter::WriteHeader() {
AV_SET_FILENAME(oc, path.c_str());
// Add general metadata (if any)
for (std::map<std::string, std::string>::iterator iter = info.metadata.begin(); iter != info.metadata.end(); ++iter) {
for (auto iter = info.metadata.begin(); iter != info.metadata.end(); ++iter) {
av_dict_set(&oc->metadata, iter->first.c_str(), iter->second.c_str(), 0);
}
// Set multiplexing parameters
AVDictionary *dict = NULL;
// For HEVC (H265) to playback on Apple devices: https://github.com/OpenShot/libopenshot/issues/990
if (info.has_video && video_codec_ctx && video_codec_ctx->codec_id == AV_CODEC_ID_HEVC) {
av_dict_set(&mux_dict, "tag:v", "hvc1", 0);
}
bool is_mp4 = strcmp(oc->oformat->name, "mp4");
bool is_mov = strcmp(oc->oformat->name, "mov");
// Set dictionary preset only for MP4 and MOV files
// Set multiplexing parameters (only for MP4/MOV containers)
AVDictionary *dict = NULL;
bool is_mp4 = (strcmp(oc->oformat->name, "mp4") == 0);
bool is_mov = (strcmp(oc->oformat->name, "mov") == 0);
if (is_mp4 || is_mov)
{
av_dict_copy(&dict, mux_dict, 0);
}
// Write the stream header
if (avformat_write_header(oc, &dict) != 0) {