net/upnp: time to stop using get_interface_ip() in plugins

The function is opportunistic and has weird VIP glue which is not
needed in 98% of the code.
This commit is contained in:
Franco Fichtner
2023-09-18 10:00:02 +02:00
parent 28e8bc0cf0
commit f2413b5013
2 changed files with 2 additions and 2 deletions
+1 -1
View File
@@ -1,6 +1,6 @@
PLUGIN_NAME= upnp
PLUGIN_VERSION= 1.5
PLUGIN_REVISION= 3
PLUGIN_REVISION= 4
PLUGIN_DEPENDS= miniupnpd
PLUGIN_COMMENT= Universal Plug and Play Service
PLUGIN_MAINTAINER= franco@opnsense.org
@@ -146,7 +146,7 @@ function miniupnpd_configure_do($verbose = false)
$if = get_real_interface($iface);
/* above function returns iface if fail */
if ($if != $iface) {
$addr = get_interface_ip($iface);
list ($addr) = interfaces_primary_address($iface);
if (!empty($addr)) {
$config_text .= "listening_ip={$if}";
if (!empty($upnp_config['overridesubnet'])) {