Merge pull request #2107 from fraenki/bind_builtin

dns/bind: small quality of life improvements
This commit is contained in:
Frank Wall
2020-11-15 11:05:05 +01:00
committed by GitHub
4 changed files with 18 additions and 7 deletions
+1 -2
View File
@@ -1,6 +1,5 @@
PLUGIN_NAME= bind
PLUGIN_VERSION= 1.13
PLUGIN_REVISION= 1
PLUGIN_VERSION= 1.14
PLUGIN_COMMENT= BIND domain name service
PLUGIN_DEPENDS= bind916
PLUGIN_MAINTAINER= m.muenz@gmail.com
+7
View File
@@ -8,6 +8,13 @@ necessary for asking and answering name service questions.
Plugin Changelog
================
1.14
* Reject built-in ACL names
* Fix truncated checkboxes
* Add button to delete selected items
* Relax ACL name mask (allow underscores and hyphens)
1.13
* Update BIND to 9.16
@@ -12,8 +12,8 @@
<name type="TextField">
<default></default>
<Required>Y</Required>
<mask>/^([0-9a-zA-Z]){1,32}$/u</mask>
<ValidationMessage>Should be a string between 1 and 32 characters. Allowed characters are 0-9a-zA-Z</ValidationMessage>
<mask>/^(?!any$|localhost$|localnets$|none$)[0-9a-zA-Z_\-]{1,32}$/u</mask>
<ValidationMessage>Should be a string between 1 and 32 characters. Allowed characters are 0-9a-zA-Z_-. Built-in ACL names must not be used: any, localhost, localnets, none.</ValidationMessage>
</name>
<networks type="NetworkField">
<default></default>
@@ -55,7 +55,7 @@ POSSIBILITY OF SUCH DAMAGE.
</div>
</div>
<div id="acls" class="tab-pane fade in">
<table id="grid-acls" class="table table-responsive" data-editDialog="dialogEditBindAcl">
<table id="grid-acls" class="table table-condensed table-hover table-striped table-responsive" data-editDialog="dialogEditBindAcl">
<thead>
<tr>
<th data-column-id="enabled" data-type="string" data-formatter="rowtoggle">{{ lang._('Enabled') }}</th>
@@ -72,6 +72,7 @@ POSSIBILITY OF SUCH DAMAGE.
<td colspan="5"></td>
<td>
<button data-action="add" type="button" class="btn btn-xs btn-default"><span class="fa fa-plus"></span></button>
<button data-action="deleteSelected" type="button" class="btn btn-xs btn-default"><span class="fa fa-trash-o"></span></button>
</td>
</tr>
</tfoot>
@@ -86,7 +87,7 @@ POSSIBILITY OF SUCH DAMAGE.
<div class="alert alert-warning" role="alert" style="min-height:65px;">
<div style="margin-top: 8px;">{{ lang._('Zone management is still in experimental state, use with caution.') }}</div>
</div>
<table id="grid-domains" class="table table-responsive" data-editAlert="ChangeMessage" data-editDialog="dialogEditBindDomain">
<table id="grid-domains" class="table table-condensed table-hover table-striped table-responsive" data-editAlert="ChangeMessage" data-editDialog="dialogEditBindDomain">
<thead>
<tr>
<th data-column-id="enabled" data-type="string" data-formatter="rowtoggle">{{ lang._('Enabled') }}</th>
@@ -108,6 +109,7 @@ POSSIBILITY OF SUCH DAMAGE.
<td colspan="5"></td>
<td>
<button data-action="add" type="button" class="btn btn-xs btn-default"><span class="fa fa-plus"></span></button>
<button data-action="deleteSelected" type="button" class="btn btn-xs btn-default"><span class="fa fa-trash-o"></span></button>
</td>
</tr>
</tfoot>
@@ -117,7 +119,7 @@ POSSIBILITY OF SUCH DAMAGE.
<h2>{{ lang._('Records') }}</h2>
</div>
<div id="record-area">
<table id="grid-records" class="table table-responsive" data-editAlert="ChangeMessage" data-editDialog="dialogEditBindRecord">
<table id="grid-records" class="table table-condensed table-hover table-striped table-responsive" data-editAlert="ChangeMessage" data-editDialog="dialogEditBindRecord">
<thead>
<tr>
<th data-column-id="enabled" data-type="string" data-formatter="rowtoggle">{{ lang._('Enabled') }}</th>
@@ -136,6 +138,7 @@ POSSIBILITY OF SUCH DAMAGE.
<td colspan="5"></td>
<td>
<button id="recordAddBtn" data-action="add" type="button" class="btn btn-xs btn-default"><span class="fa fa-plus"></span></button>
<button id="recordDelBtn" data-action="deleteSelected" type="button" class="btn btn-xs btn-default"><span class="fa fa-trash-o"></span></button>
</td>
</tr>
</tfoot>
@@ -219,9 +222,11 @@ $( document ).ready(function() {
if (ids.length > 0) {
request['domain'] = ids[0];
$("#recordAddBtn").show();
$("#recordDelBtn").show();
$("#record-area").show();
} else {
$("#recordAddBtn").hide();
$("#recordDelBtn").hide();
$("#record-area").hide();
}
return request;