netbird/plugins
0
0
Fork 0
mirror of https://github.com/netbirdio/plugins.git synced 2026-05-22 18:44:07 -07:00
Code Issues Packages Projects Releases Wiki Activity

security/acme-client: fix shell processes getting stuck, refs #3745

Browse Source 
This deals with the following issues that occured while performing
extensive testing:
- acme.sh processes got stuck forever
- PHP memory exhaustion
- PHP processes with high CPU usage
This commit is contained in:
Frank Wall
2024-01-11 00:25:35 +01:00
parent 7e73d5ab87
commit 64f2f3f082
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeUtils.php
+6 -6
View File
@@ -197,14 +197,14 @@ class LeUtils
// This workaround ensures that the accurate return code
// is reliably returned.
fclose($proc_pipes[0]);
$output = array();
while (!feof($proc_pipes[1])) {
$output[] = rtrim(fgets($proc_pipes[1], 1024), "\n");
stream_set_blocking($proc_pipes[1], false);
stream_set_blocking($proc_pipes[2], false);
while (!feof($proc_pipes[1]) || !feof($proc_pipes[2])) {
$stdout = fread($proc_pipes[1], 1024);
$stderr = fread($proc_pipes[2], 1024);
usleep(50000);
}
fclose($proc_pipes[1]);
while (!feof($proc_pipes[2])) {
$output[] = rtrim(fgets($proc_pipes[2], 1024), "\n");
}
fclose($proc_pipes[2]);
// Get exit code