netbird/plugins
0
0
Fork 0
mirror of https://github.com/netbirdio/plugins.git synced 2026-05-22 18:44:07 -07:00
Code Issues Packages Projects Releases Wiki Activity

www/caddy: Change display of domain and port combination in Model Relation Field (#3927)

Browse Source 
* Update Caddy.xml - Replace ":" with "." in Model Relation Field.

Since a stray ":" when leaving the port empty could cause confusion, I have opted to replace it with a "."

This adheres to the standard of FQDNs ending with a "DOT" at the end (RFC 1034). Note: This changes only what is displayed, not the stored data itself.

This change makes an empty port in the GUI look like this:

example.com.

And with a port, like this:

example.com.443

(Compare to: https://github.com/opnsense/plugins/issues/3917#issuecomment-2064230068 )

* Update Makefile - Bump revision to 1

* Actually just use a space, that one causes the least confusion.

* Update www/caddy/Makefile

---------

Co-authored-by: Franco Fichtner <franco@lastsummer.de>
This commit is contained in:
Monviech
2024-04-22 09:39:35 +02:00
committed by GitHub
co-authored by Franco Fichtner
parent 1897803d1f
commit 4a39ea0d0c
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
www/caddy/src/opnsense/mvc/app/models/OPNsense/Caddy/Caddy.xml
+3 -3
View File
@@ -163,7 +163,7 @@
<source>OPNsense.Caddy.Caddy</source>
<items>reverseproxy.reverse</items>
<display>FromDomain,FromPort</display>
<display_format>%s:%s</display_format>
<display_format>%s %s</display_format>
</reverseproxy>
</Model>
</reverse>
@@ -215,7 +215,7 @@
<source>OPNsense.Caddy.Caddy</source>
<items>reverseproxy.reverse</items>
<display>FromDomain,FromPort</display>
<display_format>%s:%s</display_format>
<display_format>%s %s</display_format>
</reverseproxy>
</Model>
</reverse>
@@ -225,7 +225,7 @@
<source>OPNsense.Caddy.Caddy</source>
<items>reverseproxy.subdomain</items>
<display>FromDomain,FromPort</display>
<display_format>%s:%s</display_format>
<display_format>%s %s</display_format>
</reverseproxy>
</Model>
</subdomain>