dns/dnscrypt-proxy: safeguard

dns/dnscrypt-proxy/Makefile

@@ -1,5 +1,6 @@
 PLUGIN_NAME=		dnscrypt-proxy
 PLUGIN_VERSION=		1.14
+PLUGIN_REVISION=	1
 PLUGIN_COMMENT=		Flexible DNS proxy supporting DNSCrypt and DoH
 PLUGIN_DEPENDS=		dnscrypt-proxy2
 PLUGIN_MAINTAINER=	m.muenz@gmail.com

dns/dnscrypt-proxy/src/opnsense/mvc/app/models/OPNsense/Dnscryptproxy/General.php

@@ -63,6 +63,10 @@ class General extends BaseModel
                 if (empty($service['dns_ports'])) {
                     continue;
                 }
+                if (!is_array($service['dns_ports'])) {
+                    syslog(LOG_ERR, sprintf('Service %s (%s) reported a faulty "dns_ports" entry.', $service['description'], $service['name']));
+                    continue;
+                }
                 if ($service['name'] != 'dnscrypt-proxy' && count(array_intersect(array_keys($ports), $service['dns_ports']))) {
                     $messages->appendMessage(new Message(
                         sprintf(gettext('%s is currently using one of these ports.'), $service['description']),